diff options
| author | Alex Lo <alexlo@gmail.com> | 2017-03-07 14:55:17 -0500 |
|---|---|---|
| committer | René Moser <mail@renemoser.net> | 2017-03-07 20:55:17 +0100 |
| commit | 8e910cce8aa46e37896b72c1f17de4377f4bc82c (patch) | |
| tree | 890905aeeebbf106580bfedef6242f24f35a4415 /test | |
| parent | e0d38fb137546ca8e16d6bcb1d2d98a101e98414 (diff) | |
| download | ansible-8e910cce8aa46e37896b72c1f17de4377f4bc82c.tar.gz | |
ec2_group: description is only required when group state is present (#19791)
* description is only required when group state is present
also note that AWS requires a non-empty description when creating a security group
* clarify description requirement
Diffstat (limited to 'test')
| -rw-r--r-- | test/integration/roles/test_ec2_group/tasks/main.yml | 21 |
1 files changed, 17 insertions, 4 deletions
diff --git a/test/integration/roles/test_ec2_group/tasks/main.yml b/test/integration/roles/test_ec2_group/tasks/main.yml index 7558b8e5d1..8435794bce 100644 --- a/test/integration/roles/test_ec2_group/tasks/main.yml +++ b/test/integration/roles/test_ec2_group/tasks/main.yml @@ -18,7 +18,7 @@ assert: that: - 'result.failed' - - 'result.msg == "missing required arguments: description,name"' + - 'result.msg == "missing required arguments: name"' # ============================================================ - name: test failure with only name @@ -31,7 +31,7 @@ assert: that: - 'result.failed' - - 'result.msg == "missing required arguments: description"' + - 'result.msg == "Must provide description when state is present."' # ============================================================ - name: test failure with only description @@ -47,6 +47,21 @@ - 'result.msg == "missing required arguments: name"' # ============================================================ +- name: test failure with empty description (AWS API requires non-empty string desc) + ec2_group: + name='{{ec2_group_name}}' + description='' + region='{{ec2_region}}' + register: result + ignore_errors: true + +- name: assert failure with empty description + assert: + that: + - 'result.failed' + - 'result.msg == "Must provide description when state is present."' + +# ============================================================ - name: test invalid region parameter ec2_group: name='{{ec2_group_name}}' @@ -213,7 +228,6 @@ - name: test state=absent (expected changed=true) ec2_group: name='{{ec2_group_name}}' - description='{{ec2_group_description}}' state=absent environment: EC2_REGION: '{{ec2_region}}' @@ -231,7 +245,6 @@ - name: test state=absent (expected changed=false) ec2_group: name='{{ec2_group_name}}' - description='{{ec2_group_description}}' state=absent environment: EC2_REGION: '{{ec2_region}}' |