summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Some further cleanup in the meta branchmeta_meta_metaJames Cammarata2016-08-255-98/+78
| | | | | | * adds squashing to objects, which allows them to be squashed down to a final "view" before post_validate to avoid expensive evaluations of parent attributes
* Selectively assign the getter for better performanceJames Cammarata2016-08-243-21/+60
| | | | | | Introduces the `inherit` param for FieldAttributes, which is now used in BaseMeta when constructing the getter property to enhance performance by reducing the amount of work the getter generally has to do.
* Meta meta metaJames Cammarata2016-08-245-159/+111
|
* Merge pull request #17189 from privateip/eosPeter Sprygada2016-08-222-155/+108
|\ | | | | updates eos shared module
| * updates eos shared modulePeter Sprygada2016-08-222-155/+108
| | | | | | | | | | | | | | * adds support for netcli methods * adds support for netcfg methods * Cli class now derives from CliBase * adds eos_config action plugin
* | Give native strings to selinux library functions. (#17184)Toshio Kuratomi2016-08-224-29/+242
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Give native strings to selinux library functions. SELinux takes pathnames as native strings. That means we need to convert to bytes on python2 and convert to text on python3. Fixes #17155 * Read kitchen documentation, make module_utils params more like kitchen API * Remove none nonstring strategy and add strict * Raise TypeError on invalid nonstring strategy * Document to_native() * Make unittests for testing module_utils.text
* | Fix tmpfile misspelled as tmplfile (#17183)Toshio Kuratomi2016-08-221-1/+1
| |
* | Fix docker connection plugin version tests and py2.6 compat (#16841)Adrian Likins2016-08-222-14/+50
|/ | | | | | | | | | | | | | * Rm py2.7+ code in docker connection plugin The docker connection plugin was using subprocess.check_output which only exists in python 2.7 and later. Connection plugins need to support python2.6 so this replaces it with Popen/communicate() * Handle docker ver errors in docker connection Add unit tests for DockerConnection Fixes #16971
* Merge pull request #17173 from privateip/iosPeter Sprygada2016-08-221-2/+2
|\ | | | | minor update to the ios shared module
| * minor update to the ios shared modulePeter Sprygada2016-08-211-2/+2
| | | | | | | | | | This completes the refactor for the ios shared module to change the derived class from NetCli to CliBase.
* | Merge pull request #17172 from privateip/nxosPeter Sprygada2016-08-222-99/+117
|\ \ | | | | | | updates nxos shared module refactor
| * | updates nxos shared module refactorPeter Sprygada2016-08-212-99/+117
| |/ | | | | | | | | | | This commit updates the nxos transport shared plugins for 2.2. This includes updates to both Cli and Nxapi. This commit also includes the nxos_config action plugin
* | more ways to detect lxcBrian Coca2016-08-221-3/+3
|/ | | | thanks to @wAmpire for new method and pointing out limitations of existing
* Merge pull request #17168 from privateip/clibasePeter Sprygada2016-08-202-98/+81
|\ | | | | replaces NetCli in network with CliBase in shell
| * replaces NetCli in network with CliBase in shellPeter Sprygada2016-08-202-98/+81
| | | | | | | | | | This doesn't change any of the behavior but moves NetCli to CliBase and relcates the object to the shell module
* | Update python3 docs for some of the recent decisions about porting (#17169)Toshio Kuratomi2016-08-201-0/+69
| |
* | Enable some basic.py tests on python3 (#17167)Toshio Kuratomi2016-08-203-5/+0
| |
* | Cleanup basic.py code now that six is available (#17158)Toshio Kuratomi2016-08-201-131/+125
|/ | | | | | | | | | | | | | * Cleanup basic.py code now that six is available We had some hacks in basic.py to allow us python2 and python3 compatibility. Those can now be offloaded to the six library that we're bundling. * Cleanup basic.py code now that six is available We had some hacks in basic.py to allow us python2 and python3 compatibility. Those can now be offloaded to the six library that we're bundling.
* Merge pull request #17166 from privateip/iosPeter Sprygada2016-08-201-4/+4
|\ | | | | fix import statement in ios shared module
| * fix import statement in ios shared modulePeter Sprygada2016-08-201-4/+4
| | | | | | | | This fixes the import statement when netcmd was renamed to netcli
* | Merge pull request #17165 from privateip/networkPeter Sprygada2016-08-201-1/+1
|\ \ | | | | | | fix broken import statement from netcli rename
| * | fix broken import statement from netcli renamePeter Sprygada2016-08-201-1/+1
| |/ | | | | | | | | The network module needed to be updated with the correct module name when netcmd was renamed to netcli
* | Merge pull request #17164 from privateip/netcliPeter Sprygada2016-08-201-0/+0
|\ \ | |/ |/| rename netcmd module to netcli
| * rename netcmd module to netcliPeter Sprygada2016-08-201-0/+0
|/ | | | | | This is part of the 2.2 refactor to extract the Cli class into a separate module. This renames netcmd to netcli which is consistent with the network shared modules implementations
* Merge pull request #17163 from privateip/networkPeter Sprygada2016-08-201-82/+9
|\ | | | | removes Cli and Config objects from network into separate modules
| * removes Cli and Config objects from network into separate modulesPeter Sprygada2016-08-201-82/+9
|/ | | | | This completes the refactor of Cli and Config moving them into separate modules netcmd and netcfg respectively.
* Merge pull request #17162 from privateip/iosPeter Sprygada2016-08-201-73/+23
|\ | | | | removes functions from ios module
| * removes functions from ios modulePeter Sprygada2016-08-201-73/+23
|/ | | | | | This removes top level functions from the ios module and moves them into the specific modules. This update also includes some clean up of the Cli transport
* Merge pull request #17161 from privateip/netcmdPeter Sprygada2016-08-201-59/+143
|\ | | | | moves Cli and Command class from network to netcmd module
| * moves Cli and Command class from network to netcmd modulePeter Sprygada2016-08-201-59/+143
| | | | | | | | | | | | | | | | | | | | This restructure moves the Cli object to netcmd and includes a roll up of inor bugfix updates to CommandRunner * CommandRunner now only allows one instance of a command in the stack and raise an exception if a duplidate command is detected * CommandRunner now caches returns based on command and output * CommandRunner is not responsible for creating Command instances
* | Move py34 mock_open compat to compat/test/mock (#17157)Adrian Likins2016-08-192-81/+80
| | | | | | | | | | | | | | | | test/units/plugins/action/test_action.py had code for handling a bug in python 3.4's mock_open that causes errors when reading binary data. Moved to compat/tests/mock.py so other tests can use it by default.
* | Merge pull request #16316 from alikins/alikins_docsite_makescottb2016-08-191-1/+1
|\ \ | | | | | | Fewer deps for 'make webdocs' from top level
| * | Fewer deps for 'make webdocs' from top levelAdrian Likins2016-06-282-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously it also built the MANPAGES target requiring asciidoc and libxml, before starting a 'make docs' in docsite. Also change the #! line in hacking/dump_playbook_attributes.py to not specify python2... yet.
* | | Merge pull request #16331 from coryfklein/develscottb2016-08-191-0/+1
|\ \ \ | | | | | | | | Add missing documentation about defaults/main.yml
| * | | Add missing documentation about defaults/main.ymlCory Klein2016-06-161-0/+1
| | | |
* | | | Edited https://github.com/ansible/ansible/pull/17128Scott Butler2016-08-191-4/+3
| | | |
* | | | Merge pull request #17128 from bcoca/DONTscottb2016-08-191-0/+7
|\ \ \ \ | | | | | | | | | | Thanks @bcoca; will merge and do some minor wordsmithing.
| * | | | corrected typo, expanded server typesBrian Coca2016-08-171-1/+1
| | | | |
| * | | | dont do itBrian Coca2016-08-171-0/+7
| | | | |
* | | | | Make tests more cross platform. (#17154)Matt Clay2016-08-194-22/+19
| |_|_|/ |/| | |
* | | | Merge pull request #17149 from privateip/plugin-net-configPeter Sprygada2016-08-191-5/+17
|\ \ \ \ | | | | | | | | | | action plugin net_config will now remove any private result key
| * | | | action plugin net_config will now remove any private result keyPeter Sprygada2016-08-191-5/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This update will now remove any keys from results that are created using the private names. Private names are identified as double underscore (__) on either side of the key name
* | | | | Merge pull request #17150 from privateip/netcfgPeter Sprygada2016-08-191-1/+36
|\ \ \ \ \ | |/ / / / |/| | | | pull Config object out of network and into netcfg
| * | | | pull Config object out of network and into netcfgPeter Sprygada2016-08-191-1/+36
|/ / / / | | | | | | | | | | | | | | | | This moves the Config class from network and into netcfg module with no added features. This is simply a reorganization of code.
* | | | vmware_inventory script improvements (#17142)jctanner2016-08-191-119/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * vmware_inventory script improvements * switch instance finding method to use containerview based searches * overhaul the serialization method for objects * Cleanup the debug outputs * Add a warning about performance
* | | | actions/unarchive: fix unarchive from remote url (#17126)Dusty Mabe2016-08-192-5/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * actions/unarchive: fix unarchive from remote url Currently unarchive from remote url does not work because the core unarchive module was updated to support 'remote_src' [1], but the unarchive action plugin was not updated for this. This causes failures because the action plugin assumes it needs to copy a file to the remote server, but in the case of downloading a file from a remote url a local file does not exist, so an error occurs when the file is not found. [1] https://github.com/ansible/ansible-modules-core/commit/467516e * test_unarchive: fix test with wrong remote_src use The non-ascii filenames test had improperly set remote_src=yes even though it was actually copying the file from the local machine (i.e. the file did not already exist remotely). This test was passing until the remote_src behavior of unarchive was fixed in 276550f.
* | | | [DOC FIX] Time Limited Background Operations topic styles (#17129)Alan Justino da Silva2016-08-181-2/+2
| | | | | | | | | | | | The styles are leaking, by not closing the "coding" part on the right place
* | | | py3 print fixnitzmahone2016-08-181-35/+36
| | | |
* | | | add cloudforms inventory script (#17037)Josh Preston2016-08-182-0/+493
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * add cloudforms inventory script based on the foreman inventory script, features: * cached results (default 600 seconds) * paginated host results (default 100 hosts) * ssl verification (default True) * arguments to flush cache and run in debug mode * suggested rework * removed second cache / dict with duplicate info * added purge_actions configuration option to remove the actions from a host (defaults to False) * added prefer_ip_address configuration option so give the option of using ip address instead of name (defaults to True) * removed self variables — just use the arguments directly * added --pretty command line option to pretty print results * renamed _resolve_params to _resolve_host * implement suggestions * removed not used import * added warnings to help debug connection issues * renamed self.cache to self.hosts for clarity * now will use the first ip address as ansible_ssh_host * flipped default for prefer_ip_address config option to false - preserve name, and specify ansible_ssh_host as ip address * added checks and warnings to configuration options, sane defaults for all except required: ** `url` - the first part of the cloudforms server url (https://cfme.example.com) ** `username` - the cloudforms username to log in with ** `password` - the password for the cloudforms user specified * removed redundant call to fetch host information (since we’re paging results, no need to split the calls) * added warning for unexpected responses from CloudForms * debug for returned sting now prints the string instead of forcing to JSON * removed no longer needed methods to fetch host information * using ‘key in list’ instead of ‘list.has_key(key)’ * correctly formatted groups and allowed nested groups * now create groups for `location`, `type` and `vendor`, with appropriate sub-groups and children * made to_safe honor config option to clean group names for ansible consumption * remove prefer_ip_address configuration option no longer needed since we will specify `ansible_ssh_host` as the returned ip address. * removed dns_name no longer needed, will preserve `host[name]` as name in Ansible. * purge actions from hostvars changed purge_actions to True * flake8 suggestion for whitespace * fix undefined r variable in warning output use the correct ret variable * Default purge_actions to True We probably don’t need them, but it is configurable, so just default to remove them. * Add configuration option to nest cloudforms tags disabled by default, the nest_tags option will expand cloudforms tags into a nested group/subgroup structure. Otherwise, it will use the whole tag name. * added purging the actions removed in previous clean up in error. * fixed undefined variable specified the correct variable for logging.
* | | | Clean up PlaybookExecutor logic for batches and errorsissue_15954James Cammarata2016-08-181-10/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The calculation for max_fail_percentage was moved into the linear strategy a while back, and works better there in the stategy layer rather than at the PBE layer. This patch removes it from the PBE layer and tweaks the logic controlling whether or not the next batch is run. Fixes #15954