summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Fix incorrect examples with random filter (#50137)"revert-50137-fix_random_filter_examplesBrian Coca2018-12-191-2/+2
| | | | This reverts commit 9a7dbd52139f22c9c0e5f3f127efb0f8956c6f6a.
* Revert "Update git.py (#50139)"Brian Coca2018-12-190-0/+0
| | | | This reverts commit 2e63c3432f97599394b0e2a17caed148b11c004f.
* Revert "Fix typo: or -> on (#50123)"Brian Coca2018-12-190-0/+0
| | | | This reverts commit f43217d520d5218395adc4657744124a1d8ee4f1.
* Revert "Pluribus Networks admin service module with unit tests (#49854)"Brian Coca2018-12-190-0/+0
| | | | This reverts commit 8ca02d83591a1a776d3f5cd5e31653bdcda87fc6.
* Revert "Pluribus Networks dhcp filter module with unit tests (#49848)"Brian Coca2018-12-190-0/+0
| | | | This reverts commit afdd4e23439f03c86e0468aebe61aff88ab8929a.
* Revert "Added organization in the scm_credential get (#49884)"Brian Coca2018-12-190-0/+0
| | | | This reverts commit 65c7424a358c4d48fd37abd4267dec60e6c18515.
* Revert "rabbitmq_binding: Fix using empty routing key (#48597)"Brian Coca2018-12-190-0/+0
| | | | This reverts commit 12c37802e84bfa6602ed0dc39bb63f2a203aaac7.
* Revert "corrected valid type values in RETURN (#50148)"Brian Coca2018-12-190-0/+0
| | | | This reverts commit 1a9fcd9a1004286e42d1dbded1ce57e43d32949a.
* Fix incorrect examples with random filter (#50137)Dmitry Lihachev2018-12-191-2/+2
|
* Fix mandatory statement error for junos modules (#50074)Ganesh Nalawade2018-12-193-4/+29
| | | | | | | | | | | | | | | | * Fix mandatory statement error for junos modules Fixes #40267 * Add error regex in junos terminal plugin to error out in case of commit fails * If commit fails add logic to discard changes before existing else next task will result in error * Add integration test * Minor update
* Fix no metadata traceback in validate-modules.Matt Clay2018-12-191-1/+1
|
* win_copy - fix remote dir copy when it contains an empty dir (#50126)Jordan Borean2018-12-193-4/+63
|
* fixed an issue with parameter breaking idempotency (#50117)Wojciech Wypior2018-12-181-0/+16
| | | | | | * fixed an issue with parameter breaking idempotency * Update bigip_pool_member.py
* changed oData filters (#50112)Wojciech Wypior2018-12-182-9/+17
| | | | | | | | * changed oData filters * Update bigip_asm_policy_fetch.py * Update bigip_asm_policy_import.py
* added asm endpoint facts (#50114)Wojciech Wypior2018-12-181-401/+1398
| | | | | | * added asm endpoint facts * Update bigip_device_facts.py
* added bigip_asm_policy_manage (#50115)Wojciech Wypior2018-12-182-0/+1396
| | | | | | * added bigip_asm_policy_manage * Update bigip_asm_policy_manage.py
* fixed crash in facts (#50120)Zim Kalinowski2018-12-181-1/+3
|
* added ASM policy server technology module (#50116)Wojciech Wypior2018-12-182-0/+610
| | | | | | * added ASM policy server technology module * Update bigip_asm_policy_server_technology.py
* Make the timeout decorator raise an exception out of the function's scope ↵Toshio Kuratomi2018-12-183-28/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#49921) * Revert "allow caller to deal with timeout (#49449)" This reverts commit 63279823a77320b8cdf7f69d61af6eddaa5ebf33. Flawed on many levels * Adds poor API to a public function * Papers over the fact that the public function is doing something bad by catching exceptions it cannot handle in the first place * Papers over the real cause of the issue which is a bug in the timeout decorator * Doesn't reraise properly * Catches the wrong exception Fixes #49824 Fixes #49817 * Make the timeout decorator properly raise an exception outside of the function's scope signal handlers which raise exceptions will never work well because the exception can be raised anywhere in the called code. This leads to exception race conditions where the exceptions could end up being hanlded by unintended pieces of the called code. The timeout decorator was using just that idiom. It was especially bad because the decorator syntactically occurs outside of the called code but because of the signal handler, the exception was being raised inside of the called code. This change uses a thread instead of a signal to manage the timeout in parallel to the execution of the decorated function. Since raising of the exception happens inside of the decorator, now, instead of inside of a signal handler, the timeout exception is raised from outside of the called code as expected which makes reasoning about where exceptions are to be expected intuitive again. Fixes #43884 * Add a common case test. Adding an integration test driven from our unittests. Most of the time we'll timeout in run_command which is running things in a subprocess. Create a test for that specific case in case anything funky comes up between threading and execve. * Don't use OSError-based TimeoutError as a base class Unlike most standard exceptions, OSError has a specific parameter list with specific meanings. Instead follow the example of other stdlib functions, concurrent.futures and multiprocessing and define a separate TimeoutException. * Add comment and docstring to point out that this is not hte Python3 TimeoutError
* Warn of standard behavior of 'default' key store (#49903)Tom Dietrich2018-12-191-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | * Warn of standard behavior of 'default' key store The default key store typically results in the key being stored as user. In instances where we're trying to install a cert to enable SSL binding in IIS, this will result in an unbind-able cert, as the IIS APPPOOL identity will not be able to read the private key, and presents a very cryptic error of 'A specified logon session does not exist'. +label: docsite_pr * fix trailing whitespace * Use C(user) reference * specify what's required for successful iis import - store_location's default value is currently 'LocalMachine' but if this changes it could result in the documentation being inaccurate - key_exportable is not required for a successful IIS import * remove stray = dang cat Co-Authored-By: tdietrich513 <tom.dietrich@gmail.com>
* Fix return typesToshio Kuratomi2018-12-186-6/+6
| | | | We're now stricter on naming the return types. Replace string with str.
* Convert to reduced list of known types (#50010)Dag Wieers2018-12-19908-4821/+4822
|
* VALID_ACTIONS for cli subcommands will now be a frozenset (#50058)Toshio Kuratomi2018-12-194-7/+7
|
* facts: detect FreeBSD KVM guests (#50030)Martin Krizek2018-12-193-2/+13
| | | Fixes: #49158
* facts: correctly detect multiple ipv6 addresses per device (#50020)Martin Krizek2018-12-192-5/+7
| | | Fixes #49473
* Fix with_ini example and unittestYannig Perré2018-12-182-14/+16
| | | | | | | | | * Fix example in ini.py * Fix unittest in test_ini.py to pass CI as latest ansible returns list in different order. To prevent such issues in future results are sorted * PEP8 E501 styling improvements Co-Authored-By: Sergii Golovatiuk <sgolovat@redhat.com>
* Return correct error message to userAbhijeet Kasurde2018-12-181-2/+3
| | | | | | | botocore.exceptions.ClientError does not have message, which fails fail_json. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Review commentsAbhijeet Kasurde2018-12-181-4/+7
| | | | Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Update unit tests for configmanagerAbhijeet Kasurde2018-12-182-70/+84
| | | | Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* win_lineinfile - fix malformed returned json (#50066)Jordan Borean2018-12-192-4/+6
|
* no-smart-quotes: Skip files by path in code-smell (#45881)Dag Wieers2018-12-181-2/+9
| | | | | | | | | * no-smart-quotes: Skip files by path in code-smell This is to ensure the generated docs do not trigger code-smell issues on contributor systems. * Implement feedback from review
* Small documentation update: Clarify daemon-reload always executing. (#49889)Michaël de Groot2018-12-181-2/+3
| | | | | * Small documentation update * shortens and clarifies line
* Do switch to apt if aptitude is not installed (#30738)Michael Scherer2018-12-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | Trying to use the apt module on a freshly install 16.04 Ubuntu VM with "ansible -m apt -a 'name=* state=latest' all" fail with this backtrace: Traceback (most recent call last): File \"/tmp/ansible_2inxygge/ansible_module_apt.py\", line 1055, in <module> main() File \"/tmp/ansible_2inxygge/ansible_module_apt.py\", line 998, in main upgrade(module, 'yes', force_yes, p['default_release'], use_apt_get, dpkg_options) File \"/tmp/ansible_2inxygge/ansible_module_apt.py\", line 759, in upgrade apt_cmd_path = m.get_bin_path(apt_cmd, required=True) File \"/tmp/ansible_2inxygge/ansible_modlib.zip/ansible/module_utils/basic.py\", line 2182, in get_bin_path File \"/usr/lib/python3.5/posixpath.py\", line 89, in join genericpath._check_arg_types('join', a, *p) File \"/usr/lib/python3.5/genericpath.py\", line 143, in _check_arg_types (funcname, s.__class__.__name__)) from None TypeError: join() argument must be str or bytes, not 'NoneType' It seems that since aptitude is not installed on Xenial, so APTITUDE_CMD is None and we later hit the bug in the upgrade function since it assume APTITUDE_CMD is set.
* Remove the use of mock from validate-modules (#50098)Matt Martz2018-12-181-20/+34
| | | | | | * Remove the use of mock from validate-modules * Monkeypatch AnsibleModule.__init__ not AnsibleModule
* plugin_formatter.py: Improve the output when processing docs (#46541)Dag Wieers2018-12-182-6/+35
| | | | | | | | | | | | | | | | | | * Improve the output when processing files * Update docs/bin/plugin_formatter.py Co-Authored-By: dagwieers <dag@wieers.com> * Show progress indicator. * Don't pp.pformat() huge structures when they aren't used anyway. This saves ~10 seconds on my machine. * Only show ASCII spinner if stdout is a TTY. * Fix: E722 do not use bare 'except'
* Remove dead code in ansible-inventoryToshio Kuratomi2018-12-181-27/+3
| | | | This piece of code is only needed with ansible < 2.3.x (which is now EOL)
* Remove older version_added information from docs (#50097)Dag Wieers2018-12-181-1/+1
|
* added handlers_from (#49220)Brian Coca2018-12-188-2/+72
| | | | | | | | * added handlers_from fixes #46769
* GetManagerNicInventory (#49961)Xander Madsen2018-12-182-5/+20
| | | | | | | | | | | | * Add GetManagerNicInventory command for Manager category, and tweak redfish_utils' get_nic_inventory to accommodate manager nic interfaces * Remove get_manager_nic_inventory, since it is unnecessary while using get_manager in get_nic_inventory * Rework get_nic_inventory() to take a resource_type as a string, which will be just the category parameter from redfish_facts, making it clearer * remove extraneous blank line to conform with pep8 * Add GetManagerNicInventory example task to EXAMPLES docstring
* Sanity fixes in various modules (#50080)Dag Wieers2018-12-1823-342/+374
|
* ios retry config if section filter fails (#49485)Nathaniel Case2018-12-181-2/+12
| | | | | | * Attempt to work around devices that don't understand | section * Fix case of no flags
* Upgrade README to have 4k+ contributors listed (#50093)Sviatoslav Sydorenko2018-12-181-1/+1
|
* Pluribus networks admin session timeout module with unit tests (#50012)rajaspachipulusu172018-12-182-0/+177
| | | | | | | * Pluribus networks admin session timeout module with unit tests * Doc fix * Removed unused imports * Removed unwanted global variable
* Improve module vmware_local_role_manager (#47870)Christian Kotte2018-12-182-164/+193
| | | | * add check mode support * improve output
* VMware: new module vmware_host_ad_auth (#47901)Christian Kotte2018-12-183-0/+503
|
* Fix activate of the disks in ovirt_vm and ovirt_disk modules (#49762)Ondra Machacek2018-12-182-3/+9
| | | | | | | | * ovirt_disk: Add activate parameter * ovirt_vm: Fix waiting on lun disks Signed-off-by: Ondra Machacek <omachace@redhat.com>
* VMware: new module vmware_dvswitch_uplink_pg (#48846)Christian Kotte2018-12-183-0/+608
|
* openssl_privatekey: add ECC support (#49416)Felix Fontein2018-12-186-105/+701
| | | | | | | | | | | | | | | | | | | | | | * Add cryptography backend for openssl_privatekey. * Adding ECC support. No support for X25519 and X449, since they don't support serialization. * Improve finterprint calculation to work with Python 3. * Add fingerprint check. * Fix typo. * Use separate curve option for elliptic curves, and use type 'ECC'. * Using curve names as defined in IANA registry. * Bump minimal supported cryptography version. Older versions might work as well, but I couldn't test them. * Improve documentation.
* fixing vm state change when vm created with attached disk (#50071)Zim Kalinowski2018-12-181-15/+28
| | | | | | | | * fixing vm state change when vm created with attached disk * minor fixes * fixing hanging indent
* ACI: Fix module parameters (#50051)Dag Wieers2018-12-186-12/+12
| | | | | | * Fix parameter type of private_key * Fix parameters of various ACI modules
View Lorry Controller Status