| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/
|/|
| |
| |
| |
| |
| | |
Instead of bombing out of the strategy, we now properly mark hosts failed
so that the play iterator can handle block rescue/always properly.
Fixes #14024
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When using a playbook-level include, we now catch any errors raised during
the conditional evaluation step and set a flag to indicate we need to pass
those conditionals on to the included play (most likely because they contain
inventory variables for evaluation).
Fixes #14003
|
|/
|
|
|
|
|
|
| |
This causes problems when fetching parent attributes, as the include
was being skipped because the parent block would fetch the attribute
from the parent play first.
Fixes #13872
|
| |
|
|
|
|
|
|
|
| |
The provider argument accepts the set of device common arguments as a
dict object. Individual connection arguments can still be included and
take priority over the provider argument. This update includes additions
to the nxos doc fragment
|
|
|
|
|
|
|
| |
New argument `provider` added to the ios shared module that provides
the ability to pass all of the common ios arguments as a dict. This commit
includes some minor bugfixes and refactoring of names. It also includes
udpates to the ios documentation fragment for the new argument
|
|
|
|
|
|
|
|
| |
Adds a new argument `provider` to the eos shared module and updates the
eos doc fragment. This commit includes some additional minor fixes and
code refactors for naming conventions. The `provider` argument allows the
shared module arguments to be passed as a dict object instead of having
to pass each argument invididually.
|
|
|
|
| |
This reverts commit 1b46a422aa52a90c9dd7b168be1fed9c4273b6b2.
|
|
|
|
| |
Can occur if we exit the timeout before the settings were changed
|
|
|
|
|
|
|
| |
This commit adds a new argument `provider` to the iosxr shared module that
allows common connection parameters to be passed as a dict object. The
constraints on the args still applies. This commit also updates the iosxr
doc fragment.
|
|
|
|
|
|
| |
Adds new argument `provider` to the openswitch shared module. The provider
argument can pass all openswitch connection arguments as a dict object. This
update includes adding the provider argument to the openswitch doc fragment
|
|
|
|
|
|
| |
This commit adds a new argument `provider` to the junos shared module. The
argument allows the set of common connection args to be passed to the
junos shared module. This commit also updates the junos doc fragment
|
|
|
|
|
|
| |
This commit provides an argument to provide a path to the private key
file. This will allow paramiko to use the key file as opposed to only
username / password combinations for CLI connections.
|
|
|
|
|
|
|
| |
Corrects inheritence of the boolean value, which needs some special
consideration from other (string/int) values.
Fixes #13872
|
| |
|
|
|
|
| |
Fixes #13917
|
|
|
|
| |
Fixes #13857
|
|
|
|
|
|
| |
Letting it pass would just cause an error later on (no such file found)
so it's better to catch it here and know that we have users dealing with
non-utf8 pathnames than to have to track it down from later on.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UnicodeError tracebacks.
Note that the fix for display normalizing to unicode is correct but the
fix for pathnames is probably not. Changing pathnames to unicode type
means that we will handle utf8 pathnames fine but pathnames can be any
sequence of bytes that do not contain null. We do not handle sequences
of bytes that are not valid utf8 here. To do that we need to revamp the
handling of basedir and paths to transform to bytes instead of unicode.
Didn't want to do that in 2.0.x as it will potentially introduce other
bugs as we find all the places that we combine basedir with other path
elements. Since no one has raised that as an issue thus far so it's not
something we need to handle yet. But it's something to keep in mind for
the future.
To test utf8 handling, create a utf8 directory and run a playbook from
within there.
To test non-utf8 handling (currently doesn't work as stated above), create
a directory with non-utf8 chars an run a playbook from there. In bash,
create that directory like this: mkdir $'\377'
Fixes #13937
|
| |
|
|
|
|
| |
previous 'fix' broke on 2.4
|
|
|
|
|
|
|
| |
Clearing the flag after the first host was advanced caused all other
hosts to not advance at all.
Fixes #13864
|
| |
|
| |
|
| |
|
|
|
|
|
| |
it should be common enough to not be able to read files in some jailed/container environments
even though permissions tell us otherwise
|
|
|
|
|
| |
Fixes #13964
Fixes #13967
|
|\
| |
| | |
Specify the correct default options for sudo_flags
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The correct default options for sudo_flags can be found at: https://github.com/ansible/ansible/blob/devel/lib/ansible/constants.py#L181
Slightly alter explanation of '-H' so as not to confuse it with -E, --preserve-env (which preserves existing environment variables).
When adding the two other options, include short explanations of those options.
Add note about '-n', which did not appear in 1.x I believe, and which bit me.
|
| |
| |
| | |
see https://github.com/ansible/ansible/blob/devel/lib/ansible/constants.py#L181
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Don't re-use the existing connection if the remote_addr field of
the play context has changed
* When overriding variables in PlayContext (from task/variables),
don't set the same attribute based on a different variable name
if we had already previously set it from another variable name
Fixes #13880
|
|\ \
| | |
| | | |
Added example of running commands on a remote Windows Server
|
| | |
| | |
| | | |
Added example of running commands on a remote Windows Server
|
|\ \ \
| | | |
| | | | |
minor wording fixes
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
multiline
See the Bug report for a specific error case with local connection,
sudo, and the raw module
Fixes #13728
|
| | | |
| | | |
| | | |
| | | |
| | | | |
combine_vars shoudl really be data types, but some just get in
in test, add dict to mock and avoid combine_vars using object
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Fixes #13921
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This task format is valid in 1.x, but was broken in 2.x:
- local_action:
module: shell echo "hello world"
|
|\ \ \ \
| |_|_|/
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Relocate the assignment of the host address to the remote_addr field
in the play context, which was only done when the connection was created
(it's now done after the post_validate() is called on the play context)
* Make the assignment of the play context to the connection an else, since
it's not required if the connection is not reused
|
| |\ \ \
|/ / / /
| | | |
| | | | |
ktaragorn-patch-1
|
| | | |
| | | |
| | | |
| | | |
| | | | |
If this isnt updated, the _connection is reused, and thus has an outdated _play_context
This results in outdated `success_key` and `prompt` causing issues if sudo is run in a loop
Refer to the issue #13763 for more debugging and details
|
| | | |
| | | |
| | | |
| | | | |
Fixes #13832
|
|\ \ \ \
| |_|/ /
|/| | | |
doc fragments for vmware and vca modules
|
| | | | |
|
| |_|/
|/| | |
|
|\ \ \
| | | |
| | | | |
Fix typos.
|