summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Fix incorrect handling of any_errors_fatal in the linear strategyJames Cammarata2016-01-201-5/+12
| |/ |/| | | | | | | | | | | Instead of bombing out of the strategy, we now properly mark hosts failed so that the play iterator can handle block rescue/always properly. Fixes #14024
* | Forward conditionals onto included plays when conditional eval errorsJames Cammarata2016-01-201-3/+17
| | | | | | | | | | | | | | | | | | When using a playbook-level include, we now catch any errors raised during the conditional evaluation step and set a flag to indicate we need to pass those conditionals on to the included play (most likely because they contain inventory variables for evaluation). Fixes #14003
* | Don't assign both parent blocks and task includes to blocksJames Cammarata2016-01-191-2/+7
|/ | | | | | | | This causes problems when fetching parent attributes, as the include was being skipped because the parent block would fetch the attribute from the parent play first. Fixes #13872
* clarified with_fileBrian Coca2016-01-191-1/+1
|
* adds provider argument to nxos shared modulePeter Sprygada2016-01-192-13/+21
| | | | | | | The provider argument accepts the set of device common arguments as a dict object. Individual connection arguments can still be included and take priority over the provider argument. This update includes additions to the nxos doc fragment
* adds provider argument to ios shared modulePeter Sprygada2016-01-192-12/+20
| | | | | | | New argument `provider` added to the ios shared module that provides the ability to pass all of the common ios arguments as a dict. This commit includes some minor bugfixes and refactoring of names. It also includes udpates to the ios documentation fragment for the new argument
* add provider argument to eos shared modulePeter Sprygada2016-01-192-12/+31
| | | | | | | | Adds a new argument `provider` to the eos shared module and updates the eos doc fragment. This commit includes some additional minor fixes and code refactors for naming conventions. The `provider` argument allows the shared module arguments to be passed as a dict object instead of having to pass each argument invididually.
* Revert "Properly look for parent become attribute"James Cammarata2016-01-192-5/+4
| | | | This reverts commit 1b46a422aa52a90c9dd7b168be1fed9c4273b6b2.
* Don't tracback trying to retore settingsToshio Kuratomi2016-01-191-1/+3
| | | | Can occur if we exit the timeout before the settings were changed
* add provider to iosxr shared modulePeter Sprygada2016-01-192-13/+21
| | | | | | | This commit adds a new argument `provider` to the iosxr shared module that allows common connection parameters to be passed as a dict object. The constraints on the args still applies. This commit also updates the iosxr doc fragment.
* adds provider argument to openswitch shared modulePeter Sprygada2016-01-192-14/+31
| | | | | | Adds new argument `provider` to the openswitch shared module. The provider argument can pass all openswitch connection arguments as a dict object. This update includes adding the provider argument to the openswitch doc fragment
* adds provider argument to junos shared modulePeter Sprygada2016-01-192-23/+26
| | | | | | This commit adds a new argument `provider` to the junos shared module. The argument allows the set of common connection args to be passed to the junos shared module. This commit also updates the junos doc fragment
* adds private key file support to shell shared modulePeter Sprygada2016-01-191-4/+7
| | | | | | This commit provides an argument to provide a path to the private key file. This will allow paramiko to use the key file as opposed to only username / password combinations for CLI connections.
* Properly look for parent become attributeJames Cammarata2016-01-192-4/+5
| | | | | | | Corrects inheritence of the boolean value, which needs some special consideration from other (string/int) values. Fixes #13872
* Relocate use of ERROR to display class, to avoid doubling upJames Cammarata2016-01-193-11/+11
|
* Catch INI section parsing misses and raise an appropriate errorJames Cammarata2016-01-191-1/+4
| | | | Fixes #13917
* Fix role hashing failure/traceback when params contain listsJames Cammarata2016-01-191-1/+4
| | | | Fixes #13857
* Set decoding of path to unicode to raise an exception if non-utf8Toshio Kuratomi2016-01-191-2/+2
| | | | | | Letting it pass would just cause an error later on (no such file found) so it's better to catch it here and know that we have users dealing with non-utf8 pathnames than to have to track it down from later on.
* Make all parts of messages and pathnames into unicode so that we don't get ↵Toshio Kuratomi2016-01-192-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | UnicodeError tracebacks. Note that the fix for display normalizing to unicode is correct but the fix for pathnames is probably not. Changing pathnames to unicode type means that we will handle utf8 pathnames fine but pathnames can be any sequence of bytes that do not contain null. We do not handle sequences of bytes that are not valid utf8 here. To do that we need to revamp the handling of basedir and paths to transform to bytes instead of unicode. Didn't want to do that in 2.0.x as it will potentially introduce other bugs as we find all the places that we combine basedir with other path elements. Since no one has raised that as an issue thus far so it's not something we need to handle yet. But it's something to keep in mind for the future. To test utf8 handling, create a utf8 directory and run a playbook from within there. To test non-utf8 handling (currently doesn't work as stated above), create a directory with non-utf8 chars an run a playbook from there. In bash, create that directory like this: mkdir $'\377' Fixes #13937
* clarify role include pathsBrian Coca2016-01-191-1/+1
|
* fixed exception handling to be 2.4 compatibleBrian Coca2016-01-191-9/+11
| | | | previous 'fix' broke on 2.4
* Don't clear start at task flag until all hosts are advancedJames Cammarata2016-01-181-23/+28
| | | | | | | Clearing the flag after the first host was advanced caused all other hosts to not advance at all. Fixes #13864
* added missed ec2_vpc_net_factsBrian Coca2016-01-181-0/+1
|
* be consistent about conversion to_strBrian Coca2016-01-181-1/+1
|
* updated submodule refsBrian Coca2016-01-182-12/+15
|
* ignore exceptions in get_file_contentsBrian Coca2016-01-181-0/+3
| | | | | it should be common enough to not be able to read files in some jailed/container environments even though permissions tell us otherwise
* Turn results that come from traceback messages into unicode, not str.Toshio Kuratomi2016-01-181-1/+2
| | | | | Fixes #13964 Fixes #13967
* Merge pull request #13934 from dlangille/dlangille-patch-2Brian Coca2016-01-181-4/+5
|\ | | | | Specify the correct default options for sudo_flags
| * Specify the correct default values for sudo_flagsDan Langille2016-01-161-3/+4
| | | | | | | | | | | | | | | | | | The correct default options for sudo_flags can be found at: https://github.com/ansible/ansible/blob/devel/lib/ansible/constants.py#L181 Slightly alter explanation of '-H' so as not to confuse it with -E, --preserve-env (which preserves existing environment variables). When adding the two other options, include short explanations of those options. Add note about '-n', which did not appear in 1.x I believe, and which bit me.
| * Add correct default options for sudo_flagsDan Langille2016-01-161-1/+1
| | | | | | see https://github.com/ansible/ansible/blob/devel/lib/ansible/constants.py#L181
* | Fix with loop + delegate issuesJames Cammarata2016-01-182-1/+6
| | | | | | | | | | | | | | | | | | | | * Don't re-use the existing connection if the remote_addr field of the play context has changed * When overriding variables in PlayContext (from task/variables), don't set the same attribute based on a different variable name if we had already previously set it from another variable name Fixes #13880
* | Merge pull request #13923 from slimandslam/patch-1Brian Coca2016-01-181-0/+8
|\ \ | | | | | | Added example of running commands on a remote Windows Server
| * | Added example of running commands on a remote Windows ServerJ Levitt2016-01-151-0/+8
| | | | | | | | | Added example of running commands on a remote Windows Server
* | | Merge pull request #13922 from rgroten/patch-2Brian Coca2016-01-181-3/+3
|\ \ \ | | | | | | | | minor wording fixes
| * | | minor wording fixesRyan Groten2016-01-151-3/+3
| | | |
* | | | Update submodule refsToshio Kuratomi2016-01-182-15/+12
| | | |
* | | | Fix proposed by @Yannig to fix become success detection when the output is ↵Toshio Kuratomi2016-01-181-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | multiline See the Bug report for a specific error case with local connection, sudo, and the raw module Fixes #13728
* | | | correctly deals with non serializable typeBrian Coca2016-01-182-2/+10
| | | | | | | | | | | | | | | | | | | | combine_vars shoudl really be data types, but some just get in in test, add dict to mock and avoid combine_vars using object
* | | | better init detectionBrian Coca2016-01-181-7/+6
| | | |
* | | | Fix set_fact + run_once to assign variables to all hosts in the listJames Cammarata2016-01-181-10/+10
| | | | | | | | | | | | | | | | Fixes #13921
* | | | Allow module args as k=v pairs when using the module: option with local_actionJames Cammarata2016-01-181-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | This task format is valid in 1.x, but was broken in 2.x: - local_action: module: shell echo "hello world"
* | | | Merge branch 'ktaragorn-patch-1' into develJames Cammarata2016-01-181-3/+9
|\ \ \ \ | |_|_|/ |/| | |
| * | | Minor cleanup when reassigning play context to reused connectionsJames Cammarata2016-01-181-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Relocate the assignment of the host address to the remote_addr field in the play context, which was only done when the connection was created (it's now done after the post_validate() is called on the play context) * Make the assignment of the play context to the connection an else, since it's not required if the connection is not reused
| * | | Merge branch 'patch-1' of https://github.com/ktaragorn/ansible into ↵James Cammarata2016-01-181-0/+3
| |\ \ \ |/ / / / | | | | | | | | ktaragorn-patch-1
| * | | Fixes #13763 Update connections _play_context on every iterationKarthik T2016-01-111-0/+3
| | | | | | | | | | | | | | | | | | | | If this isnt updated, the _connection is reused, and thus has an outdated _play_context This results in outdated `success_key` and `prompt` causing issues if sudo is run in a loop Refer to the issue #13763 for more debugging and details
* | | | Fix erroneous fetch fail when fail_on_missing is set to FalseToshio Kuratomi2016-01-151-2/+4
| | | | | | | | | | | | | | | | Fixes #13832
* | | | Merge pull request #13819 from chrrrles/vmware_doc_fragmentsChrrrles Paul2016-01-152-0/+120
|\ \ \ \ | |_|/ / |/| | | doc fragments for vmware and vca modules
| * | | doc fragments for vmware_ vca_Charles Paul2016-01-122-0/+120
| | | |
* | | | fixes documentation stringPeter Sprygada2016-01-151-1/+1
| |_|/ |/| |
* | | Merge pull request #13919 from dkasak/patch-2Brian Coca2016-01-151-1/+1
|\ \ \ | | | | | | | | Fix typos.