| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
This reverts commit ee46fe2910f0d5c56f2cd7850039d7b0742d83cb.
|
|
|
|
| |
This reverts commit 2a91ba71b2d5a6c9dd51546ec614eb8504984bcd.
|
|
|
| |
(cherry picked from commit 093662390150491a81e8762d24d96a4258b0aa0d)
|
|
|
|
|
| |
* and fix test error
(cherry picked from commit 88763c7347af98a765650739cfbf562bfc2dd40c)
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
combine_vars uses dict.update() to replace keys
(cherry picked from commit 5e03e322de5b43b69c8aad5c0cb92e82ce0f3d17)
* Add tests for merging and replacing vars from inventory sources (#73181)
(cherry picked from commit 9de2da8a7ee1c0219b804b6afc7b090101106743)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* [stable-2.10] Add macOS 11 to CI (#72622)
* Fix connection_paramiko_ssh test for macOS 11
* Update Azure Pipelines config
* Add changelog
(cherry picked from commit a7e834071c)
Co-authored-by: Sam Doran <sdoran@redhat.com>
* Prefer venv for tests
* Update pip integration test to use venv on py3.
(cherry picked from commit 456e9b7a33d7a6f24b1e87b7785ba46980471197)
Co-authored-by: Matt Clay <matt@mystile.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
together (#73016) (#73177)
Do the right thing on Linux when password lock and a password hash are provided by writing
out the password hash prepended by the appropriate lock string rather than using -U and -L.
This is the correct way to set and lock the account in one command.
On BSD, run separate commands as appropriate since locking and setting the password cannot
be done in a single action.
FreeBSD requires running several commands to get the account in the desired state. As a result,
the rc, output, and error from all commands need to be combined and evaluated so an accurate
and complete summary can be given at the end of module execution.
* Improve integration tests to cover this scenario.
* Break up user integration tests into smaller files
* Properly lock account when creating a new account and password is supplied
* Simplify rc collection in FreeBSD class
Since the _handle_lock() method was added, the rc would be set to None, which could make
task change reporting incorrect. My first attempt to solve this used a set and was a bit too
complicated. Simplify it my comparing the rc from _handle_lock() and the current value of rc.
* Improve the Linux password hash and locking behavior
If password lock and hash are provided, set the hash and lock the account by using a password
hash since -L cannot be used with -p.
* Ensure -U and -L are not combined with -p since they are mutually exclusive to usermod.
* Clarify password_lock behavior..
(cherry picked from commit 264e08f21a15213a4db76339888d3dfa2f2d6abb)
Co-authored-by: Sam Doran <sdoran@redhat.com>
|
|
|
|
| |
Fixes #70690
(cherry picked from commit 83764ad)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change:
- module_utils.basic.is_special_selinux_path() used a string ==
bytestring comparison which returned False and made Ansible think that
certain filesystems aren't, in fact, special-cased, when they should
be. Ensure both sides of the == are bytestrings.
Test Plan:
- Added `copy` integration tests for this case.
Tickets:
- Fixes #70244
Signed-off-by: Rick Elrod <rick@elrod.me>.
(cherry picked from commit 688cd8657bcd4610aa268913be67e76778bc6940)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(#73013)
PR #72702 introduced a bug that changed the unit name when splitting it up for the purpose
of searching for the unit. This only happens on unit file templates on systems that have a 5.8
or newer kernel and a version of systemd that does not contain a bugfix that causes systmed
to fail to parse dbus.
* Use facts rather than a manual probe to determine if systmed is present
* Remove unnecessary block
* Use vars files instead of set_fact
* Add tests for using a templated unit file
* Update changelog fragment
* Use template to get correct path to sleep binary
(cherry picked from commit 48803604cd)
Co-authored-by: Sam Doooran <sdoran@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename pylint plugin and add tests. (#70225)
* Update ansible-test pylint Python support. (#72972)
* Add integration tests for sanity test failures.
(cherry picked from commit fa48678a08115cc3cd8ef29777370f8db708d9b1)
* Python 3.8 is now officially supported.
* Python 3.9 is now skipped with a warning.
(cherry picked from commit 37d09f24882c1f03be9900e610d53587cfa6bbd6)
* Allow key None to prevent errors with import test.
(cherry picked from commit dbc2c996ab361151fce8d1244f67413eb27aa50c)
Backport of https://github.com/ansible/ansible/pull/73003
Co-authored-by: Felix Fontein <felix@fontein.de>
|
|
|
|
|
|
|
|
| |
Having the trap exit with a specific code will override
the exit code that caused the trap to run, which could
mask errors
(cherry picked from commit 5157a92139)
Co-authored-by: Sam Doran <sdoran@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* ansible-galaxy collection list and verify now utilize collections in site-packages.
This is a short term fix for #70147. The long term fix needs to handle
install (but that discussion is also bound up in how upgrade is going to
work and where things can get installed so it's deferred for 2.11.)
* Add test for ansible-galaxy collection list with site-packages
Co-authored-by: David Moreau Simard <moi@dmsimard.com>
Co-authored-by: Jordan Borean <jborean93@gmail.com>
(cherry picked from commit e7dee73774b0b436551e4993ba917eec1e03af2d)
Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Ensure we only reset the connection when one has been previously established. Fixes #65812
* Ensure psrp doesn't trace
* winrm too
* Indentation fix
(cherry picked from commit a3b6485)
Co-authored-by: Matt Martz <matt@sivel.net>
|
|
|
|
|
|
|
|
| |
* Fix 'role_name : tast_name' notation if task contains role name
* Add tests for notifying handler names which contain the role name
Co-authored-by: Thomas Wouters <thomaswouters@gmail.com>
(cherry picked from commit 0ed7bfc694e5e2efe49fa0e1c8fea0a392c78c04)
|
|
|
| |
(cherry picked from commit 252685092cacdd0f8b485ed6f105ec7acc29c7a4)
|
| |
|
|
|
| |
(cherry picked from commit ebd8c101fd4ee9c2ddd54658c833d2e135294cec)
|
|
|
|
|
|
|
|
|
|
|
| |
(#72710) (#72849)
* add a reminder about ignore-*.txt entries, fix formatting, add symlink removal note
* Update docs/docsite/rst/dev_guide/developing_collections.rst
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: David Moreau Simard <moi@dmsimard.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
(cherry picked from commit 0a7fcd135cdefe843c0d7098a237b6b0c1c5da02)
|
|
|
|
| |
files to use FQCNs (#72848)
|
|
|
|
|
|
|
| |
* Update apt.py, add an example that references the suggested workaround in #25414
(cherry picked from commit 1e1b8e7acae7b2322a004a563a86548e78a20216)
(cherry picked from commit 180bbfed6a8fc2ca0ba5614db2b27391350a200d)
* Added changelog fragment
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* ansible-test - prefer venv over virtualenv on Python 3 (#73000)
Also pin virtualenv to 16.7.10 for older Mac OS X systems. This was the version being installed
anway with the previous constraint (<20).
On systems with Python 3, now prefer venv over virtualenv. Test to see if venv is functional since
some systems have a non-functional venv installation (such as Debian).
(cherry picked from commit 850a77f6391cc09b7296e831877adcf4052f5404)
* Make the new ansible-test venv behavior opt-in
Co-authored-by: Sam Doooran <sdoran@redhat.com>
|
| |
|
|
|
|
| |
This is not functionality that exists.
(cherry picked from commit 8450858651f2c50153c38ba9273684a2ec2d7335)
|
|
|
|
|
|
| |
(cherry picked from commit 0eb1e22cd9)
Co-authored-by: Sam Doran <sdoran@redhat.com>
|
|
|
| |
(cherry picked from commit c9f28c1735e892cf09654028b3f85e71ada1e032)
|
|
|
|
|
|
| |
Use correct syntax for installation of role from local git repository. Fixes: #72217
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 776274143fc255d24c0fba8e6b37aa38041fe471)
|
|
|
|
|
|
|
|
|
| |
* Add link to all module and plugin indexes, use glob setting for toctree.
* Adjust .gitignore
* Fix docs make clean: now that there's a static file in rst/collections, we have to be more
explicit about how we clean the generated files out of that directory.
Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
(cherry picked from commit b514200126f98517d71fddbc636e91700e65e8f9)
|
|
|
|
| |
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
(cherry picked from commit 1d8760779c25b2dbbe902bda799408b1cb1f0556)
|
|
|
|
|
| |
(cherry picked from commit 0a3c5d9dcc5d8b17ba73634b7d5398ba22fa3c5e)
Co-authored-by: Sandra McCann <samccann@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
The recent update of ptyprocess to 0.7.0 is incompatible with Python 2.6 and
is causing test failures.
* Add setup_pexpect role to expect test
(cherry picked from commit 003a9e890d)
Co-authored-by: Sam Doooran <sdoran@redhat.com>
|
|
|
|
|
|
|
|
| |
* Increase fetch depth to reduce the frequency of full test runs for out-of-date PRs.
* Update scripts to match those which will be used in collections.
(cherry picked from commit 3274e02fd87b93975d409ec47661b8011b1a7fbf)
Co-authored-by: Matt Clay <mclay@redhat.com>
|
| |
|
| |
|
|
|
|
|
| |
(cherry picked from commit 36ab3d1189075000693cea928f32839bfabae36c)
Co-authored-by: Matt Clay <mclay@redhat.com>
|
|
|
|
|
| |
* add docs survey banner, with date
(cherry picked from commit 609879331550a485c787880919c738b2de1eebb1)
|
| |
|
| |
|
|
|
|
|
| |
* avoid fatal exception on invalid collection name used in ansible-doc filter
(cherry picked from commit 4f0e2fff957c67415958e71a03fe4fc7dabce87e)
|
|
|
|
|
|
|
|
|
| |
permissions (#72516) (#72713)
* Added check for none on netstat_path variable
* Added changelog
(cherry picked from commit e879f12fb9629842f6c9c1a18ebd9dfd3e23de32)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* remove redundant remote_user for local setting
local action plugin already does and this also should fix
fork/thread issue by removing use of pwd library
fixes #59642
(cherry picked from commit 488b9d6c35b22205522c964182480e398e2cf4bc)
* ensure local exposes correct user (#72543)
* ensure local exposes correct user
avoid corner case in which delegation relied on
playcontext fallback which was removed
fixes #72541
(cherry picked from commit aa4d53ccdfe9fb8f5a97e058703286adfbc91d08)
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Consolidate logic for determining whether or not session is interactive
into a single function, is_interactive()
* Increase test coverage
I wasn't able to find a good way of simulating running a backgrounded test with CI since the
whole test is essentially run not in a TTY, which is similar enough to cause the new is_interactive()
function to always return false.
(cherry picked from commit 4b8cb6582b)
Co-authored-by: Sam Doran <sdoran@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
(#72684)
* Added integration tests for this scenario
(cherry picked from commit fb092a82a1a013fd38a37b90b305fc9a8fa11a13)
* Slight tweak to galaxy source selection (#72685)
(cherry picked from commit 18e5628b1911ec95de914fb3305f87cb88a2b3fe)
|
|
|
|
|
|
|
|
|
| |
* Return error if cwd directory does not exist (#72390)
* Return warning or error if cwd directory does not exist, in AnsibleModule.run_command()
(cherry picked from commit 5654de6fceeabb190111d5fb5d3e092a7e5d7f3b)
* added flag in run_command signature to control behaviour when cwd does not exist
|
|
|
|
|
| |
(cherry picked from commit c1da427a5e)
Co-authored-by: Amin Vakil <info@aminvakil.com>
|
|
|
|
|
|
|
| |
they are already installed (#72423) (#72424)
(cherry picked from commit 809d5fc398)
Co-authored-by: Jordan Borean <jborean93@gmail.com>
|
|
|
|
|
|
|
| |
When enumerating connections with psutil, catch and ignore errors to avoid returning a stack trace.
Co-authored-by: Matt Martz <matt@sivel.net>
(cherry picked from commit fb09fd2a23)
|