summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* New release v2.10.6rc1v2.10.6rc1Rick Elrod2021-02-084-1/+123
|
* [stable-2.10] Temporary fix for cryptography issues. (#73530). (#73533)Matt Clay2021-02-0810-5/+52
| | | | | (cherry picked from commit 1a2da990a403e1c836574c5883ec0c17a98d2a65) Co-authored-by: Matt Clay <mclay@redhat.com>
* Bump antsibull-changelog version for changelog sanity test.Felix Fontein2021-02-082-1/+3
| | | | (cherry picked from commit 82cdd7e735eb6244bd9eb23c5c11bf82111f267c)
* [stable-2.10] pause - adjust warning when run in background (#73182) (#73231)Sam Doran2021-02-073-7/+23
| | | | | | | | | | | When the pause module is run in the background and seconds parameter is provided, do not warn. * Add tests * Fix existing tests The test wasn't failing when it should have. (cherry picked from commit 0e6c334115) Co-authored-by: Sam Doran <sdoran@redhat.com>
* bugfix: use to_text(stdout) in psrp.Connection.put_file method (#73491) - ↵Jordan Borean2021-02-072-1/+3
| | | | | | | 2.10 (#73496) (cherry picked from commit f271d02a9fa07299ea4fccbd7554a1bcec1782dc) Co-authored-by: jakegatsby <39974194+jakegatsby@users.noreply.github.com>
* [stable-2.10] Fix YAML error message when error is at the end of the file ↵Sam Doran2021-02-073-8/+54
| | | | | | | | | | | | | | | | | (#73241) (#73296) If a YAML file fails to load due to a syntax error in a file, or there is an error in the last line of a file, PyYAML reports the last line number of the file as the index where the error occurred. When reading the file lines, we use that index to the get the relevant line. If the index value is out of range, the relevant line is lost for error reporting. Subtract one from the index value to avoid the IndexError in this specific scenario. It is possible to still get an IndexError, which will be handled as it is currently. * Update existing tests and add new tests (cherry picked from commit e8d4b62b41) Co-authored-by: Sam Doran <sdoran@redhat.com>
* Use a pty for local connections (#73023) (#73281)Brian Coca2021-02-074-2/+36
| | | | | | Fixes #38696 Co-authored-by: James Cammarata <jimi@sngx.net> (cherry picked from commit 30d93995ddcf92636919c2238435064a8089e240)
* Always mention the name of the deprecated plugin in routing deprecation ↵Felix Fontein2021-02-072-4/+8
| | | | | messages (#73059) (#73237) (cherry picked from commit df9cf368c0bb5ff2f7152402b30a0f27a5571389)
* [stable-2.10] facts - properly report virtualization facts for Linux guests ↵Sam Doran2021-02-074-0/+33
| | | | | | | on bhyve (#73204). (#73233) (cherry picked from commit df451636e74fe6f0021a5555392f84c2bf194432) Co-authored-by: Sam Doran <sdoran@redhat.com>
* fix inventory source parse error handling (#73160) (#73276)Brian Coca2021-02-073-8/+27
| | | | | | | fixes #51025 added test cases (cherry picked from commit 1e27d4052a95d8f19c63d6a37909b3ec690ac832)
* Local vars should have highest precedence in AnsibleJ2Vars (#72830) (#73370)Martin Krizek2021-02-0714-22/+93
| | | | | | | | | | | | | | | | | | | | Ability to add local variables into AnsibleJ2Vars was added in 18a9eff11f0a6e51b17405ce596bd9ff7e676320 to fix #6653. Local variables are added using ``AnsibleJ2Vars.add_locals()`` method when creating a new context - typically when including/importing a template with context. For that use case local template variables created using ``set`` should override variables from higher contexts - either from the play or any parent template, or both; Jinja behaves the same way. Also removes AnsibleJ2Vars.extras instance variable which is not used. Also adds missing test for #6653. Fixes #72262 Fixes #72615 ci_complete (cherry picked from commit a2af8432f36ec8cc5368a747f1211d2b9ba01f2e)
* no_log mask suboption fallback values and defaults CVE-2021-20228 (#73487) ↵Jordan Borean2021-02-077-11/+125
| | | | | (#73494) (cherry picked from commit 0cdc410dce6658e93c06fa27e0100ddbb11e7015)
* fix typo (#73479)Akira Yokochi2021-02-071-3/+3
| | | (cherry picked from commit f72dec16eaa96295e750e1ab70ef265a788a0170)
* git: verify, only use --raw when we need it (#70900) (#73473)Rick Elrod2021-02-074-3/+28
| | | | | | | | | | | | | | | Change: - Allow older git to verify tags again - Enable verification tests everywhere, even if most of them only work on newer git. Some of them work on older git and they test the --raw parameter. Test Plan: - Re-enabled subset of git tests Tickets: - Fixes #64469 Signed-off-by: Rick Elrod <rick@elrod.me>
* Fix warning for nonexistent inventory cache (#72840) (#73443)Sloane Hertel2021-02-077-6/+93
| | | | | * Fix inventory cache warning by checking if the key exists before loading it (cherry picked from commit 840bdc1e10f1f0d3c8c0ce4109e9724b466202c0)
* ensure unsafe writes fallback (#70722) (#73144)Brian Coca2021-02-077-11/+79
| | | | | | | | | | | | * Ensure we actually fallback to unsafe_writes when set to true add integration test add fix for get_url not passing the parameter from args (cherry picked from commit 932ba3616067007fd5e449611a34e7e3837fc8ae) * Added clog missing for issue 70722 (#73175) (cherry picked from commit d6670da1d7bc81dccd522d1bc27cc25164ef1aba)
* [stable-2.10] import_playbook - change additional params to deprecation ↵Sam Doran2021-02-076-3/+12
| | | | | | | | | | (#72987) (#73015) I incorrectly recommended this be set as a warning when it should have been a deprecation. * Fix deprecation sanity test to not required a collection name when not inside a collection (cherry picked from commit 8e022ef00a) Co-authored-by: Sam Doooran <sdoran@redhat.com>
* [setup_rpm_repo test] Ensure rpm-build is present (#73516) (#73518)Rick Elrod2021-02-053-0/+3
| | | | | | | | | | | | | | Change: - Other targets might remove rpm-build as they clean up after themselves. Ensure that it's present in setup_rpm_repo because rpmfluff needs it. Test Plan: - Local experimentation with yum_repository and mysql_db (the latter of which depends on a handler which was removing rpm-build) on stable-2.9. Signed-off-by: Rick Elrod <rick@elrod.me> (cherry picked from commit aca5b0e43be4d7bd067abc6631978b1cdfa75d84)
* [stable-2.10] Make yum_repository test more reliable (#73467)Sam Doran2021-02-0313-74/+138
| | | | | | | | | | | | | * Improve setup_rpm_repo - add handlers to remove repos - add variable to control whethere or not repos are created * Use local repo for all distros * Change repo creation script to module. (cherry picked from commit 997b2d2a1955ccb4e70f805c18dc3e227e86c678) Co-authored-by: Sam Doran <sdoran@redhat.com>
* validate_modules: fails with .id attribute not found (#73322)Gonéri Le Bouder2021-02-032-0/+5
| | | | | | | | | | | | | | | | | | | | | | | * validate_modules: fails with .id attribute not found This patch addresses a problem in the `found_try_except_import` test. This module tries to identify lines like: `HAS_FOO = True` In this case, the target (`HAS_FOO`) is of type `ast.Name` and has a `id` attribute which provide the name. In my case, I've a line that set a module attribute`. In this case, the target (`module.var`) has the type `ast.Attribute` and no `id` attribute. The code trigger an `AttributeError` exception. This patch ensures we compare a `ast.Name`. * Update test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/main.py (cherry picked from commit 7cf80f50d16b7a7a2ba9f1318bdca5df53936369)
* Documentation: fix formatting (#73186)Andrew Klychkov2021-02-0310-106/+110
|
* Make sure to mention collection version for version_added as well. (#73270) ↵Felix Fontein2021-02-033-5/+7
| | | | | (#73280) (cherry picked from commit 73aa571305f52df2a0995b77f51dafdc3787eb96)
* add new glossary terms for 2.10 (#71813) (#73293)David Moreau Simard2021-02-031-0/+27
| | | | | | | | * add new terms for 2.10 Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com> (cherry picked from commit 4aedd1b987150baae4b11200de916c87c53e6d30) Co-authored-by: Sandra McCann <samccann@redhat.com>
* Remove 'type: complex' from the example, and mention that it should be ↵Felix Fontein2021-02-031-2/+4
| | | | | avoided. (#73171) (#73222) (cherry picked from commit 270385f9490a0c9ee30fb3e17df7a09dd2a37433)
* Fix `versionadded` syntax @ galaxy user guide (#73350)Sviatoslav Sydorenko2021-02-021-1/+1
| | | (cherry picked from commit 6abeabaff1356d0f4b88e87b5dd1eb86f81993ed)
* Mention that C(...) should be used for inline code. (#73312) (#73374)Felix Fontein2021-02-021-1/+1
| | | (cherry picked from commit 76604397cb0940d27646d8764bc6d7c1c088aabd)
* Revert "[ansible-test] Bump CentOS 6 image (yum repos) (#73446) (#73447)" ↵Rick Elrod2021-02-012-3/+1
| | | | | (#73450) This reverts commit e4f8d528b9d6641db764736d68af01703ca49b8b.
* [ansible-test] Bump CentOS 6 image (yum repos) (#73446) (#73447)Rick Elrod2021-02-012-1/+3
| | | | | | | Change: - Bump centos6 image version to one which includes multiple fallbacks for vault.centos.org content. Signed-off-by: Rick Elrod <rick@elrod.me>
* [2.10] Add Ubuntu 20.04 to CI and ansible-test (#69161) (#73365)Rick Elrod2021-01-2613-12/+55
| | | | | | | | | | | | Change: - Add Ubuntu 20.04 to CI now that venv is default instead of virtualenv in ansible-test. Test Plan: - CI Tickets: - Fixes #69203 Signed-off-by: Rick Elrod <rick@elrod.me>
* [stable-2.10] Use a versioned pip bootstrapper in ansible-test. (#73359)Matt Clay2021-01-252-4/+3
| | | | | (cherry picked from commit fc590aeb2104c2c4e6a3aacba53852da1d7a26d9) Co-authored-by: Matt Clay <matt@mystile.com>
* [stable-2.10] Handle get-pip.py breaking change on Python 2.7.Matt Clay2021-01-232-1/+11
| | | | | | (cherry picked from commit 484e4af4d0b0f8ba88f73c20f592bb107eb9396a) Co-authored-by: Matt Clay <matt@mystile.com>
* Update Ansible release version to v2.10.5.post0.Rick Elrod2021-01-181-1/+1
|
* New release v2.10.5v2.10.5Rick Elrod2021-01-184-4/+18
|
* Revert "update the docs requirements versions (#73108) (#73251)"Sandra McCann2021-01-151-3/+3
| | | | This reverts commit ee46fe2910f0d5c56f2cd7850039d7b0742d83cb.
* Revert "update rstcheck and sphinx versions in contraints (#73176) (#73249)"Sandra McCann2021-01-151-2/+1
| | | | This reverts commit 2a91ba71b2d5a6c9dd51546ec614eb8504984bcd.
* update the docs requirements versions (#73108) (#73251)Sandra McCann2021-01-151-3/+3
| | | (cherry picked from commit 093662390150491a81e8762d24d96a4258b0aa0d)
* update rstcheck and sphinx versions in contraints (#73176) (#73249)Sandra McCann2021-01-151-1/+2
| | | | | * and fix test error (cherry picked from commit 88763c7347af98a765650739cfbf562bfc2dd40c)
* Update Ansible release version to v2.10.5rc1.post0.Rick Elrod2021-01-111-1/+1
|
* New release v2.10.5rc1v2.10.5rc1Rick Elrod2021-01-114-1/+101
|
* [2.10] Pass the top level dictionaries to combine_vars (#72979) (#73146)Sloane Hertel2021-01-117-2/+66
| | | | | | | | | combine_vars uses dict.update() to replace keys (cherry picked from commit 5e03e322de5b43b69c8aad5c0cb92e82ce0f3d17) * Add tests for merging and replacing vars from inventory sources (#73181) (cherry picked from commit 9de2da8a7ee1c0219b804b6afc7b090101106743)
* [stable-2.10] Add macOS 11 to CI (#72622) (#73180)Sam Doran2021-01-1118-18/+42
| | | | | | | | | | | | | | | | | | * [stable-2.10] Add macOS 11 to CI (#72622) * Fix connection_paramiko_ssh test for macOS 11 * Update Azure Pipelines config * Add changelog (cherry picked from commit a7e834071c) Co-authored-by: Sam Doran <sdoran@redhat.com> * Prefer venv for tests * Update pip integration test to use venv on py3. (cherry picked from commit 456e9b7a33d7a6f24b1e87b7785ba46980471197) Co-authored-by: Matt Clay <matt@mystile.com>
* [stable-2.10] user - properly handle password and password lock when used ↵Sam Doran2021-01-1119-1149/+1283
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | together (#73016) (#73177) Do the right thing on Linux when password lock and a password hash are provided by writing out the password hash prepended by the appropriate lock string rather than using -U and -L. This is the correct way to set and lock the account in one command. On BSD, run separate commands as appropriate since locking and setting the password cannot be done in a single action. FreeBSD requires running several commands to get the account in the desired state. As a result, the rc, output, and error from all commands need to be combined and evaluated so an accurate and complete summary can be given at the end of module execution. * Improve integration tests to cover this scenario. * Break up user integration tests into smaller files * Properly lock account when creating a new account and password is supplied * Simplify rc collection in FreeBSD class Since the _handle_lock() method was added, the rc would be set to None, which could make task change reporting incorrect. My first attempt to solve this used a set and was a bit too complicated. Simplify it my comparing the rc from _handle_lock() and the current value of rc. * Improve the Linux password hash and locking behavior If password lock and hash are provided, set the hash and lock the account by using a password hash since -L cannot be used with -p. * Ensure -U and -L are not combined with -p since they are mutually exclusive to usermod. * Clarify password_lock behavior.. (cherry picked from commit 264e08f21a15213a4db76339888d3dfa2f2d6abb) Co-authored-by: Sam Doran <sdoran@redhat.com>
* [stable-2.10] Fix async interpreter parsing (#72636) (#72923)Matt Martz2021-01-116-8/+29
| | | | Fixes #70690 (cherry picked from commit 83764ad)
* [stable-2.10] Fix string/bytestring comparsion in m_u.basic (#70439) (#73129)Sam Doran2021-01-113-2/+40
| | | | | | | | | | | | | | | | Change: - module_utils.basic.is_special_selinux_path() used a string == bytestring comparison which returned False and made Ansible think that certain filesystems aren't, in fact, special-cased, when they should be. Ensure both sides of the == are bytestrings. Test Plan: - Added `copy` integration tests for this case. Tickets: - Fixes #70244 Signed-off-by: Rick Elrod <rick@elrod.me>. (cherry picked from commit 688cd8657bcd4610aa268913be67e76778bc6940)
* [stable-2.10] systemd - do not overwrite unit name when searching (#72985) ↵Sam Doran2021-01-118-68/+143
| | | | | | | | | | | | | | | | | | (#73013) PR #72702 introduced a bug that changed the unit name when splitting it up for the purpose of searching for the unit. This only happens on unit file templates on systems that have a 5.8 or newer kernel and a version of systemd that does not contain a bugfix that causes systmed to fail to parse dbus. * Use facts rather than a manual probe to determine if systmed is present * Remove unnecessary block * Use vars files instead of set_fact * Add tests for using a templated unit file * Update changelog fragment * Use template to get correct path to sleep binary (cherry picked from commit 48803604cd) Co-authored-by: Sam Doooran <sdoran@redhat.com>
* Update ansible-test pylint Python support. (#72997)Matt Clay2021-01-1112-58/+156
| | | | | | | | | | | | | | | | | * Rename pylint plugin and add tests. (#70225) * Update ansible-test pylint Python support. (#72972) * Add integration tests for sanity test failures. (cherry picked from commit fa48678a08115cc3cd8ef29777370f8db708d9b1) * Python 3.8 is now officially supported. * Python 3.9 is now skipped with a warning. (cherry picked from commit 37d09f24882c1f03be9900e610d53587cfa6bbd6) * Allow key None to prevent errors with import test. (cherry picked from commit dbc2c996ab361151fce8d1244f67413eb27aa50c) Backport of https://github.com/ansible/ansible/pull/73003 Co-authored-by: Felix Fontein <felix@fontein.de>
* [stable-2.10] Remove exit code from traps in tests (#72968)Sam Doran2021-01-111-1/+0
| | | | | | | | Having the trap exit with a specific code will override the exit code that caused the trap to run, which could mask errors (cherry picked from commit 5157a92139) Co-authored-by: Sam Doran <sdoran@redhat.com>
* Collection list site packages (#70173) (#72940)Jordan Borean2021-01-113-2/+18
| | | | | | | | | | | | | | | * ansible-galaxy collection list and verify now utilize collections in site-packages. This is a short term fix for #70147. The long term fix needs to handle install (but that discussion is also bound up in how upgrade is going to work and where things can get installed so it's deferred for 2.11.) * Add test for ansible-galaxy collection list with site-packages Co-authored-by: David Moreau Simard <moi@dmsimard.com> Co-authored-by: Jordan Borean <jborean93@gmail.com> (cherry picked from commit e7dee73774b0b436551e4993ba917eec1e03af2d) Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
* [stable-2.10] Fix reset_connection paramiko, winrm, psrp (#72688) (#72925)Matt Martz2021-01-116-0/+16
| | | | | | | | | | | | * Ensure we only reset the connection when one has been previously established. Fixes #65812 * Ensure psrp doesn't trace * winrm too * Indentation fix (cherry picked from commit a3b6485) Co-authored-by: Matt Martz <matt@sivel.net>
* Fix task get_name to always prepend the role name (#72511) (#72919)Sloane Hertel2021-01-115-5/+35
| | | | | | | | * Fix 'role_name : tast_name' notation if task contains role name * Add tests for notifying handler names which contain the role name Co-authored-by: Thomas Wouters <thomaswouters@gmail.com> (cherry picked from commit 0ed7bfc694e5e2efe49fa0e1c8fea0a392c78c04)
View Lorry Controller Status