summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* New release v2.9.18rc1v2.9.18rc1Rick Elrod2021-02-084-1/+128
|
* postgresql_query: fix datetime.timedelta type handling (#73520)Andrew Klychkov2021-02-073-0/+40
|
* no_log mask suboption fallback values and defaults CVE-2021-20228 (#73487) ↵Jordan Borean2021-02-077-11/+125
| | | | | (#73493) (cherry picked from commit 0cdc410dce6658e93c06fa27e0100ddbb11e7015)
* bugfix: use to_text(stdout) in psrp.Connection.put_file method (#73491) - ↵Jordan Borean2021-02-052-1/+3
| | | | | | | | 2.9 (#73495) * bugfix: use to_text(stdout) in psrp.Connection.put_file method (#73491) Co-authored-by: jakegatsby <jakegatsby@example.com> (cherry picked from commit f271d02a9fa07299ea4fccbd7554a1bcec1782dc)
* [setup_rpm_repo test] Ensure rpm-build is present (#73516) (#73515)Rick Elrod2021-02-053-0/+3
| | | | | | | | | | | | | | Change: - Other targets might remove rpm-build as they clean up after themselves. Ensure that it's present in setup_rpm_repo because rpmfluff needs it. Test Plan: - Local experimentation with yum_repository and mysql_db (the latter of which depends on a handler which was removing rpm-build) on stable-2.9. Signed-off-by: Rick Elrod <rick@elrod.me> (cherry picked from commit aca5b0e43be4d7bd067abc6631978b1cdfa75d84)
* [bp-2.9] snmp_facts: Hide user sensitive information in console (#73188)Abhijeet Kasurde2021-02-052-2/+4
| | | | | | | | **SECURITY** - CVE-2021-20178 Hide user sensitive information like `privkey` and `authkey` while logging in console. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* [stable-2.9] pause - adjust warning when run in background (#73182) (#73230)Sam Doran2021-02-053-7/+23
| | | | | | | | | | | When the pause module is run in the background and seconds parameter is provided, do not warn. * Add tests * Fix existing tests The test wasn't failing when it should have. (cherry picked from commit 0e6c334115) Co-authored-by: Sam Doran <sdoran@redhat.com>
* [stable-2.9] facts - properly report virtualization facts for Linux guests ↵Sam Doran2021-02-054-0/+33
| | | | | | | on bhyve (#73204). (#73234) (cherry picked from commit df451636e74fe6f0021a5555392f84c2bf194432) Co-authored-by: Sam Doran <sdoran@redhat.com>
* [bp-2.9] bitbucket_pipeline_variable: Hide secured values in console log ↵Abhijeet Kasurde2021-02-052-3/+13
| | | | | | | | | | (#73243) **SECURITY** - CVE-2021-20180 Hide user sensitive information which is marked as ``secured`` while logging in console. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* mysql_user: Add missed privileges support (#73271)Andrew Klychkov2021-02-052-1/+17
| | | Co-authored-by: Andrew Klychkov <andrew.klychkov@gmail.com>
* postgresql_ping, postgresql_info: fix crash related to PgSQL version parsing ↵Andrew Klychkov2021-02-053-2/+5
| | | | | (#73285) Co-authored-by: Andrew Klychkov <andrew.klychkov@gmail.com>
* postgresql_set: Return a message when a passed parameter has not been found ↵Andrew Klychkov2021-02-053-0/+23
| | | | | (#73286) Co-authored-by: Andrew Klychkov <andrew.klychkov@gmail.com>
* [stable-2.9] Fix YAML error message when error is at the end of the file ↵Sam Doran2021-02-053-8/+54
| | | | | | | | | | | | | | | | | (#73241) (#73297) If a YAML file fails to load due to a syntax error in a file, or there is an error in the last line of a file, PyYAML reports the last line number of the file as the index where the error occurred. When reading the file lines, we use that index to the get the relevant line. If the index value is out of range, the relevant line is lost for error reporting. Subtract one from the index value to avoid the IndexError in this specific scenario. It is possible to still get an IndexError, which will be handled as it is currently. * Update existing tests and add new tests (cherry picked from commit e8d4b62b41) Co-authored-by: Sam Doran <sdoran@redhat.com>
* Local vars should have highest precedence in AnsibleJ2Vars (#72830) (#73369)Martin Krizek2021-02-0514-22/+93
| | | | | | | | | | | | | | | | | | | | Ability to add local variables into AnsibleJ2Vars was added in 18a9eff11f0a6e51b17405ce596bd9ff7e676320 to fix #6653. Local variables are added using ``AnsibleJ2Vars.add_locals()`` method when creating a new context - typically when including/importing a template with context. For that use case local template variables created using ``set`` should override variables from higher contexts - either from the play or any parent template, or both; Jinja behaves the same way. Also removes AnsibleJ2Vars.extras instance variable which is not used. Also adds missing test for #6653. Fixes #72262 Fixes #72615 ci_complete (cherry picked from commit a2af8432f36ec8cc5368a747f1211d2b9ba01f2e)
* Support large folder size comparisons for win_find (#58466) (#73382)Jordan Borean2021-02-052-1/+3
| | | | | | | Changed [int] to [int64] to support larger folders. Otherwise module fails as soon as a large folder is encountered. (cherry picked from commit 8def67939dbd5dbba84fe160f3ad187c76ebe63a) Co-authored-by: joshinryz <josh.robinett@gmail.com>
* postgresql_query: fix decimal handling (#73414)Andrew Klychkov2021-02-053-1/+45
| | | Co-authored-by: Andrew Klychkov <andrew.klychkov@gmail.com>
* [2.9] Fix warning for nonexistent inventory cache (#72840) (#73444)Sloane Hertel2021-02-057-6/+93
| | | | | * Fix inventory cache warning by checking if the key exists before loading it (cherry picked from commit 840bdc1e10f1f0d3c8c0ce4109e9724b466202c0)
* no_log keycloak_client's registration_access_token (#73502)Rick Elrod2021-02-052-1/+2
| | | | | | | | | Change: - Address missing no_log change from #73489. Tickets: - Refs #73489 Signed-off-by: Rick Elrod <rick@elrod.me>
* [security] Add no_log to several module args (CVE-2021-20191) [2.9] (#73489)Rick Elrod2021-02-0439-50/+122
| | | | | | | | | | | | | Change: - A number of modules were missing no_log=True where they should have had it. Test Plan: - Lots of grepping. Tickets: - Refs https://github.com/ansible-collections/community.general/pull/1725 Signed-off-by: Rick Elrod <rick@elrod.me>
* [stable-2.9] Make yum_repository test more reliable (#73467)Sam Doran2021-02-0313-74/+138
| | | | | | | | | | | | | * Improve setup_rpm_repo - add handlers to remove repos - add variable to control whethere or not repos are created * Use local repo for all distros * Change repo creation script to module. (cherry picked from commit 997b2d2a1955ccb4e70f805c18dc3e227e86c678) Co-authored-by: Sam Doran <sdoran@redhat.com>
* postgresql_user: add clarification about no_password_changes option (#73287)Andrew Klychkov2021-02-031-1/+6
| | | Co-authored-by: Andrew Klychkov <andrew.klychkov@gmail.com>
* [stable-2.9] Use a versioned pip bootstrapper in ansible-test. (#73360)Matt Clay2021-01-252-4/+3
| | | | | (cherry picked from commit fc590aeb2104c2c4e6a3aacba53852da1d7a26d9) Co-authored-by: Matt Clay <matt@mystile.com>
* [stable-2.9] Update ansible-test pylint Python support. (#72972) (#73355)Matt Clay2021-01-253-4/+6
| | | | | | | | * [stable-2.9] Update ansible-test pylint Python support. (#72972) * Update ansible-test pylint Python support. * Python 3.8 is now officially supported. (cherry picked from commit 37d09f24882c1f03be9900e610d53587cfa6bbd6)
* [stable-2.9] Handle get-pip.py breaking change on Python 2.7.Matt Clay2021-01-232-1/+11
| | | | | | (cherry picked from commit 484e4af4d0b0f8ba88f73c20f592bb107eb9396a) Co-authored-by: Matt Clay <matt@mystile.com>
* Update Ansible release version to v2.9.17.post0.Rick Elrod2021-01-181-1/+1
|
* New release v2.9.17v2.9.17Rick Elrod2021-01-184-4/+12
|
* Revert "[2.9]update the docs requirements versions (#73108) (#73252)" (#73261)Alicia Cozine2021-01-151-2/+2
| | | | | This reverts commit 6ae2146d023a74b28d3d85635f4a18d308c0a19c. Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
* [2.9]update the docs requirements versions (#73108) (#73252)Sandra McCann2021-01-151-2/+2
| | | | | | | * update the docs requirements versions (#73108) (cherry picked from commit 093662390150491a81e8762d24d96a4258b0aa0d) * remove antsibull
* Update Ansible release version to v2.9.17rc1.post0.Rick Elrod2021-01-111-1/+1
|
* New release v2.9.17rc1v2.9.17rc1Rick Elrod2021-01-114-1/+61
|
* [2.9] Pass the top level dictionaries to combine_vars (#72979) (#73147)Sloane Hertel2021-01-117-2/+66
| | | | | | | | | combine_vars uses dict.update() to replace keys (cherry picked from commit 5e03e322de5b43b69c8aad5c0cb92e82ce0f3d17) * Add tests for merging and replacing vars from inventory sources (#73181) (cherry picked from commit 9de2da8a7ee1c0219b804b6afc7b090101106743)
* Ensure that data within a tuple is marked as unsafe (#65918) (#73044)Felix Fontein2021-01-115-20/+46
| | | | | | | | | | * Use is_sequence, and Mapping throughout, add support for tuples. Fixes #65722 * Address tests * Remove unused import * Add changelog * Add docstring for clarity (cherry picked from commit f8654de851a841d33d2d2e76942c68a758535e56) Co-authored-by: Matt Martz <matt@sivel.net>
* [stable-2.9] user - properly handle password and password lock when used ↵Sam Doran2021-01-1119-1099/+1253
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | together (#73016) (#73178) Do the right thing on Linux when password lock and a password hash are provided by writing out the password hash prepended by the appropriate lock string rather than using -U and -L. This is the correct way to set and lock the account in one command. On BSD, run separate commands as appropriate since locking and setting the password cannot be done in a single action. FreeBSD requires running several commands to get the account in the desired state. As a result, the rc, output, and error from all commands need to be combined and evaluated so an accurate and complete summary can be given at the end of module execution. * Improve integration tests to cover this scenario. * Break up user integration tests into smaller files * Properly lock account when creating a new account and password is supplied * Simplify rc collection in FreeBSD class Since the _handle_lock() method was added, the rc would be set to None, which could make task change reporting incorrect. My first attempt to solve this used a set and was a bit too complicated. Simplify it my comparing the rc from _handle_lock() and the current value of rc. * Improve the Linux password hash and locking behavior If password lock and hash are provided, set the hash and lock the account by using a password hash since -L cannot be used with -p. * Ensure -U and -L are not combined with -p since they are mutually exclusive to usermod. * Clarify password_lock behavior.. (cherry picked from commit 264e08f21a15213a4db76339888d3dfa2f2d6abb) Co-authored-by: Sam Doran <sdoran@redhat.com>
* backport support for python-kubernetes v12 to ansible 2.9 (#72792)Richard Megginson2021-01-104-1/+51
| | | | | | Support for using python-kubernetes v12 has been added to the new upstream repo: https://github.com/ansible-collections/community.kubernetes/blob/main/plugins/module_utils/common.py#L256-L261 This PR backports that support to ansible 2.9
* Fix freeform actions with FQCN. (#72958)Felix Fontein2021-01-103-2/+10
|
* [stable-2.9] Fix bigiq_device_info (#72943)Wojciech Wypior2021-01-102-9/+24
| | | | * fix iteration error with _transform_name_attribute function * add information on BIG-IQ 7.x support
* [stable-2.9] Fix docker_image tests (#72953)Felix Fontein2021-01-102-6/+6
| | | | | * Backport of https://github.com/ansible-collections/community.docker/pull/47 to stable-2.9. * Also fix old-options.
* Backport of ↵Felix Fontein2021-01-103-5/+62
| | | | https://github.com/ansible-collections/community.docker/commit/5eef093e994ce4bb10529b1c5da38c4992f5b3c4 (#73067)
* [stable-2.9] systemd - do not overwrite unit name when searching (#72985) ↵Sam Doran2021-01-108-38/+118
| | | | | | | | | | | | | | | | | | | | | | | | (#73014) * systemd - do not overwrite unit name when searching PR #72702 introduced a bug that changed the unit name when splitting it up for the purpose of searching for the unit. This only happens on unit file templates on systems that have a 5.8 or newer kernel and a version of systemd that does not contain a bugfix that causes systmed to fail to parse dbus. * Use facts rather than a manual probe to determine if systmed is present * Remove unnecessary block * Use vars files instead of set_fact * Add tests for using a templated unit file * Update changelog fragment * Use template to get correct path to sleep binary (cherry picked from commit 48803604cd3f8640ed8dd36357044a3fd51b6490)
* [stable-2.9] Remove exit code from traps in tests (#72969)Sam Doran2021-01-101-1/+0
| | | | | | | | Having the trap exit with a specific code will override the exit code that caused the trap to run, which could mask errors (cherry picked from commit 5157a92139) Co-authored-by: Sam Doran <sdoran@redhat.com>
* [stable-2.9] Fix reset_connection paramiko, winrm, psrp (#72688) (#72926)Matt Martz2021-01-106-0/+16
| | | | | | | | | | | * Ensure we only reset the connection when one has been previously established. Fixes #65812 * Ensure psrp doesn't trace * winrm too (cherry picked from commit a3b6485073a0bbd2574285b4087d10dcfd80d494) Co-authored-by: Matt Martz <matt@sivel.net>
* [stable-2.9] Fix async interpreter parsing (#72636) (#72924)Matt Martz2021-01-106-8/+29
| | | | | | | | | * Fix async interpreter parsing. Fixes #70690 * Target localhost instead of remote host * Don't forget inventory * Address shellcheck issue (cherry picked from commit 83764ad) Co-authored-by: Matt Martz <matt@sivel.net>
* Support venv in ansible-test virtualenv scripts (#73164)Matt Clay2021-01-084-3/+17
| | | | | | | | | | | | | | | | * ansible-test - prefer venv over virtualenv on Python 3 (#73000) Also pin virtualenv to 16.7.10 for older Mac OS X systems. This was the version being installed anway with the previous constraint (<20). On systems with Python 3, now prefer venv over virtualenv. Test to see if venv is functional since some systems have a non-functional venv installation (such as Debian). (cherry picked from commit 850a77f6391cc09b7296e831877adcf4052f5404) (cherry picked from commit a48b3d2089807ff0ab34ddacfcc90de49903d10e) * Make the new ansible-test venv behavior opt-in Co-authored-by: Sam Doooran <sdoran@redhat.com>
* docker_image: always push, also when tagging is not necessaryFelix Fontein2021-01-083-3/+81
| | | Backport of https://github.com/ansible-collections/community.docker/commit/117f1322138c9910add8f43adb2f08e7ee5998d8 (#73066)
* [stable-2.9] Fix string/bytestring comparsion in m_u.basic (#70439) (#73130)Sam Doran2021-01-083-2/+40
| | | | | | | | | | | | | | | | | | Change: - module_utils.basic.is_special_selinux_path() used a string == bytestring comparison which returned False and made Ansible think that certain filesystems aren't, in fact, special-cased, when they should be. Ensure both sides of the == are bytestrings. Test Plan: - Added `copy` integration tests for this case. Tickets: - Fixes #70244 Signed-off-by: Rick Elrod <rick@elrod.me>. (cherry picked from commit 688cd8657bcd4610aa268913be67e76778bc6940) Co-authored-by: Rick Elrod <rick@elrod.me>
* [stable-2.9] Update azure pipelines containerSam Doran2021-01-081-1/+1
| | | | | | (cherry picked from commit 0eb1e22cd9) Co-authored-by: Sam Doran <sdoran@redhat.com>
* [stable-2.9] Constrain pexpect and ptyprocess (#73109)Sam Doooran2021-01-045-3/+13
| | | | | | | | | | The recent update of ptyprocess to 0.7.0 is incompatible with Python 2.6 and is causing test failures. * Add setup_pexpect role to expect test (cherry picked from commit 003a9e890d) Co-authored-by: Sam Doooran <sdoran@redhat.com>
* [stable-2.9] Add coverage exporting to ansible-test (#72982)Matt Clay2020-12-156-4/+54
| | | | | | | | | | | | | | | * Add `--venv-system-site-packages` to ansible-test. (cherry picked from commit 934d6b235bd04a8aef570f4e4a5d6e0abe550318) Backport of https://github.com/ansible/ansible/pull/65615 * [stable-2.9] Add coverage exporting to ansible-test A new `--export` option for `ansible-test coverage combine` allows multi-step aggregation of code coverage for CI pipelines.. (cherry picked from commit fa2be89cd44f0c867f24351c3ba73d5e849cb507) Backport of https://github.com/ansible/ansible/pull/72563
* [stable-2.9] Update Azure Pipelines scripts and config. (#72986)Matt Clay2020-12-153-2/+14
| | | | | | | | * Increase fetch depth to reduce the frequency of full test runs for out-of-date PRs. * Update scripts to match those which will be used in collections. (cherry picked from commit 3274e02fd87b93975d409ec47661b8011b1a7fbf) Co-authored-by: Matt Clay <mclay@redhat.com>
* Update Ansible release version to v2.9.16.post0.Rick Elrod2020-12-141-1/+1
|