summaryrefslogtreecommitdiff
path: root/changelogs
Commit message (Collapse)AuthorAgeFilesLines
* New release v2.11.0rc2v2.11.0rc2Rick Elrod2021-04-063-0/+33
|
* Use a file-like obj for stdout/stderr for deadlock workaround (#74156) (#74160)Martin Krizek2021-04-061-0/+2
| | | | | Fixes #74149 (cherry picked from commit 96f94c0fef18cf25f772a2b241b9c4ce9ab9b74e)
* New release v2.11.0rc1v2.11.0rc1Rick Elrod2021-04-053-0/+64
|
* [stable-2.11] Add ansible-test constraint for decorator. (#74128)Matt Clay2021-04-051-0/+2
| | | | | (cherry picked from commit f436058fadc880a7a290ff617a468108a738b8b3) Co-authored-by: Matt Clay <matt@mystile.com>
* Fix 2.11 changelog ancestor, missed at 2.10 branching (#74123)stable-2.11-branchpointRick Elrod2021-04-051-1/+1
| | | Signed-off-by: Rick Elrod <rick@elrod.me>
* Implement workaround for stdout deadlock in multiprocessing shutdown (#74099)Matt Martz2021-04-051-0/+3
|
* Add ansible-test six constraint for Python 2.6.Matt Clay2021-04-011-0/+2
|
* Fix debug factsetter (#74067)Brian Coca2021-03-311-0/+2
| | | | * prevent debug from setting namespaced facts as tlv * also added tests
* Fix ansible-test coverage exporting.Matt Clay2021-03-301-0/+6
| | | | | ci_complete ci_coverage
* import openbsd patches (#74056)chemsaf32021-03-302-0/+4
| | | | | * add openbsd service info * Create openbsd-service.yml * Update var name
* New release v2.11.0b4 (#74063)v2.11.0b4Rick Elrod2021-03-293-0/+67
|
* nonzero exit code on `ansible galaxy collection verify` failures (#74051)Matt Davis2021-03-291-0/+2
|
* pause - do not continue with '\r' when timeout is set (#74030)Alexander Sowitzki2021-03-291-0/+2
| | | | | Original function of pause was, to only allow user input (finished with enter) when no timeout was set. This restores the behaviour.
* add --offline option to galaxy collection verify (#74040)Matt Davis2021-03-291-0/+2
| | | | | * --offline allows in-place verify for installed collections with manifests * manifest hash, collection name, version, and path are now always displayed * test updates
* Revert "Add duplicated set filter and documentation (#72729)" (#74053)Felix Fontein2021-03-271-3/+0
| | | | | This reverts commit 99a6627c60d8734d90f6982107eebb9de24ba54d. * ci_complete
* Add duplicated set filter and documentation (#72729)Baptiste Mille-Mathias2021-03-271-0/+3
| | | Co-authored-by: Kerry <kerry@flatline-studios.com>
* Correctly set path and fullpath for template vars (#73924)Brian Coca2021-03-261-0/+2
| | | | | | * Correctly set path and fullpath for template vars don't expect path to always be full path also added exception/tb on action fail
* Fix setup subset (#74022)Brian Coca2021-03-261-0/+2
| | | | | | * fix error msg on bad subset * added test * handle more raised but not handled fact exceptions
* argspec validation - fix apply_defaults (#74029)Felix Fontein2021-03-241-0/+2
| | | * Add test
* fix wait_for looping when missing net module (#73963)Brian Coca2021-03-231-0/+2
| | | fixes #43486
* less blocking on fact reading (#73951)Brian Coca2021-03-231-0/+2
| | | | | | | * less blocking on fact reading Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
* Fix wrong backup directory var name in apt module (#73840)Xabier Napal2021-03-221-0/+4
| | | * Fix wrong backup directory var name in apt module
* New release v2.11.0b3 (#73977)v2.11.0b3Rick Elrod2021-03-193-0/+70
|
* Use ArgumentSpecValidator in AnsibleModule (#73703)Sam Doran2021-03-191-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Begin using ArgumentSpecValidator in AnsibleModule * Add check parameters to ArgumentSpecValidator Add additional parameters for specifying required and mutually exclusive parameters. Add code to the .validate() method that runs these additional checks. * Make errors related to unsupported parameters match existing behavior Update the punctuation in the message slightly to make it more readable. Add a property to ArgumentSpecValidator to hold valid parameter names. * Set default values after performining checks * FIx sanity test failure * Use correct parameters when checking sub options * Use a dict when iterating over check functions Referencing by key names makes things a bit more readable IMO. * Fix bug in comparison for sub options evaluation * Add options_context to check functions This allows the parent parameter to be added the the error message if a validation error occurs in a sub option. * Fix bug in apply_defaults behavior of sub spec validation * Accept options_conext in get_unsupported_parameters() If options_context is supplied, a tuple of parent key names of unsupported parameter will be created. This allows the full "path" to the unsupported parameter to be reported. * Build path to the unsupported parameter for error messages. * Remove unused import * Update recursive finder test * Skip if running in check mode This was done in the _check_arguments() method. That was moved to a function that has no way of calling fail_json(), so it must be done outside of validation. This is a silght change in behavior, but I believe the correct one. Previously, only unsupported parameters would cause a failure. All other checks would not be executed if the modlue did not support check mode. This would hide validation failures in check mode. * The great purge Remove all methods related to argument spec validation from AnsibleModule * Keep _name and kind in the caller and out of the validator This seems a bit awkward since this means the caller could end up with {name} and {kind} in the error message if they don't run the messages through the .format() method with name and kind parameters. * Double moustaches work I wasn't sure if they get stripped or not. Looks like they do. Neat trick. * Add changelog * Update unsupported parameter test The error message changed to include name and kind. * Remove unused import * Add better documentation for ArgumentSpecValidator class * Fix example * Few more docs fixes * Mark required and mutually exclusive attributes as private * Mark validate functions as private * Reorganize functions in validation.py * Remove unused imports in basic.py related to argument spec validation * Create errors is module_utils We have errors in lib/ansible/errors/ but those cannot be used by modules. * Update recursive finder test * Move errors to file rather than __init__.py * Change ArgumentSpecValidator.validate() interface Raise AnsibleValidationErrorMultiple on validation error which contains all AnsibleValidationError exceptions for validation failures. Return the validated parameters if validation is successful rather than True/False. Update docs and tests. * Get attribute in loop so that the attribute name can also be used as a parameter * Shorten line * Update calling code in AnsibleModule for new validator interface * Update calling code in validate_argument_spec based in new validation interface * Base custom exception class off of Exception * Call the __init__ method of the base Exception class to populate args * Ensure no_log values are always updated * Make custom exceptions more hierarchical This redefines AnsibleError from lib/ansible/errors with a different signature since that cannot be used by modules. This may be a bad idea. Maybe lib/ansible/errors should be moved to module_utils, or AnsibleError defined in this commit should use the same signature as the original. * Just go back to basing off Exception * Return ValidationResult object on successful validation Create a ValidationResult class. Return a ValidationResult from ArgumentSpecValidator.validate() when validation is successful. Update class and method docs. Update unit tests based on interface change. * Make it easier to get error objects from AnsibleValidationResultMultiple This makes the interface cleaner when getting individual error objects contained in a single AnsibleValidationResultMultiple instance. * Define custom exception for each type of validation failure These errors indicate where a validation error occured. Currently they are empty but could contain specific data for each exception type in the future. * Update tests based on (yet another) interface change * Mark several more functions as private These are all doing rather "internal" things. The ArgumentSpecValidator class is the preferred public interface. * Move warnings and deprecations to result object Rather than calling deprecate() and warn() directly, store them on the result object so the caller can decide what to do with them. * Use subclass for module arg spec validation The subclass uses global warning and deprecations feature * Fix up docs * Remove legal_inputs munging from _handle_aliases() This is done in AnsibleModule by the _set_internal_properties() method. It only makes sense to do that for an AnsibleModule instance (it should update the parameters before performing validation) and shouldn't be done by the validator. Create a private function just for getting legal inputs since that is done in a couple of places. It may make sense store that on the ValidationResult object. * Increase test coverage * Remove unnecessary conditional ci_complete * Mark warnings and deprecations as private in the ValidationResult They can be made public once we come up with a way to make them more generally useful, probably by creating cusom objects to store the data in more structure way. * Mark valid_parameter_names as private and populate it during initialization * Use a global for storing the list of additonal checks to perform This list is used by the main validate method as well as the sub spec validation.
* find - set proper default based on use_regex (#73961)Brian Coca2021-03-191-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | When using "use_regex: yes" and setting an excludes: without specifying a pattern: the existing code passes the file-glob '*' to the regex matcher. This results in an internal invalid-regex exception being thrown. This maintains the old semantics of a default match-all for pattern: but switches the default to '.*' when use_regex is specified. The code made sense as-is before excludes: was added (2.5). In that case, it made no sense to set use_regex but *not* set a pattern. However, with excludes: it now makes sense to only want to exclude a given regex but not specify a specific matching pattern. Closes: #50067 * moved change to new location added changelog * Update lib/ansible/modules/find.py Co-authored-by: Ian Wienand <iwienand@redhat.com>
* Fix a bug adding unrelated candidates to the plugin loader redirect_list ↵Sloane Hertel2021-03-181-0/+2
| | | | | | | | | | | | | | | (#73863) * Fix a bug adding unrelated candidates to the plugin loader redirect_list * Add tests for the redirect list * test redirect list for builtin module * test redirect list for redirected builtin module * test redirect list for collection module * test redirect list for redirected collection module * test redirect list for legacy module * changelog
* Amazon: Fix distribution facts for older releaseAbhijeet Kasurde2021-03-181-0/+2
| | | | | | | | | Ansible can gather distribution facts for older Amazon Linux with /etc/os-release data. Fixes: #73946 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Send callbacks directly from the TaskExecutor instead of TaskResults ↵Matt Martz2021-03-181-0/+5
| | | | masquerading as callbacks (#73927)
* ansible-pull: Run All Playbooks When Multiple Are Supplied (#73172)sommersoft2021-03-171-0/+2
| | | | | | | * ansible-pull: run all playbooks when multiple are supplied * add test for ansible-pull with multiple playbooks supplied from cli * add changelog fragment
* Ensure task from the worker is finalized/squashed (#73881)Matt Martz2021-03-161-0/+5
| | | * Ensure task from the worker is finalized/squashed. Fixes #57399. Fixes #49942
* New release v2.11.0b2 (#73915)v2.11.0b2Rick Elrod2021-03-153-0/+108
|
* Allow for searching handler subdir for included tasks (#73809)David Shrewsbury2021-03-151-0/+2
| | | | * Allow for searching handler subdir for included tasks
* setup - virtualization facts add Red Hat vendor (#72876)Martin Nečas2021-03-151-0/+2
| | | Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
* Ensure unit test paths for connection and inventory plugins are based on the ↵Mark Chappell2021-03-121-0/+2
| | | | context (#73877)
* fix su localization optoinBrian Coca2021-03-111-0/+2
| | | | fixes #73837
* moved vs deprecated world readable tmp setting (#73825)Brian Coca2021-03-111-0/+2
|
* validate-modules: make sure that options that potentially contain secret ↵Felix Fontein2021-03-111-0/+2
| | | | | | | | data have no_log set (#73508) * Catch more potential errors (and increase false-positive rate). * Flag some false-positives in lib/ansible/modules/ with no_log=False. Co-authored-by: John Barker <john@johnrbarker.com>
* add optional module_utils import support (#73832)Matt Davis2021-03-101-0/+4
| | | | | | | | | * add optional module_utils import support Treat core and collections module_utils imports nested within any Python block statement (eg, `try`, `if`) as optional. This allows Ansible modules to implement runtime fallback behavior for missing module_utils (eg from a newer version of ansible-core), where previously, the module payload builder would always fail when unable to locate a module_util (regardless of any runtime behavior the module may implement). * sanity test fixes ci_complete
* Update `resource_prefix` syntax for ansible-test.Matt Clay2021-03-101-0/+4
|
* Nonfatal facts (#73804)Brian Coca2021-03-081-0/+2
| | | | | | | | | | continue with local facts vs at script error actually capture execution errors better error messages in general add more local facts tests fixes #52427
* distribution: Add Amazon Linux distribution facts (#73767)Abhijeet Kasurde2021-03-051-0/+2
| | | | | | | | * Update Amazon Linux Distribution facts gathering logic * Update tests Fixes: #73742 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Auto cleanup of async cache file (#73760)David Shrewsbury2021-03-041-0/+2
| | | | | * Auto cleanup of async cache file * Add changelog
* Set fact fixes (#73684)Brian Coca2021-03-031-0/+2
| | | | | | * fixes to set_fact correctly give error messages that were previously ignored corrected and expanded docs
* Fix notify on import_tasks (#73572)Brian Coca2021-03-031-0/+2
| | | | | * Fix notify on import_tasks also able to apply to blocks now.
* finish migrating ssh plugin to config system (#73708)Brian Coca2021-03-031-0/+3
| | | | | | | | | | | * finish migrating ssh plugin to config system fixes #72739 fixes #57220 * fix connection detection in reset * correct options for connection meta reset Co-authored-by: David Shrewsbury <Shrews@users.noreply.github.com>
* module output is only json objects (#73765)Brian Coca2021-03-031-0/+2
| | | | | | * module output is only json objects remove json lists as they are not valid from modules fixes #73744
* Don't fail for mixed typed keys (#73726)Brian Coca2021-03-031-0/+2
| | | | | | | * Don't fail for mixed typed keys but warn that content cound not be sorted because of this * added tests
* minor detection improvement on j2plugin loader (#73714)Brian Coca2021-03-031-0/+2
| | | * minor improvement on j2plugin loader, comments and var names clarified
* New release v2.11.0b1 (#73761)v2.11.0b1Rick Elrod2021-03-023-4/+2020
|
* Remove old ansible-test windows completion entries.Matt Clay2021-03-021-0/+1
|
View Lorry Controller Status