From b01da1b780baaadaf7c22639bb32bcfc84077f01 Mon Sep 17 00:00:00 2001 From: jjshoe Date: Fri, 18 Apr 2014 21:39:10 -0500 Subject: Ensure the validation string has %s in it --- library/files/copy | 2 ++ library/files/lineinfile | 2 ++ library/files/replace | 2 ++ 3 files changed, 6 insertions(+) diff --git a/library/files/copy b/library/files/copy index 862a1ac77b..47012155f2 100644 --- a/library/files/copy +++ b/library/files/copy @@ -204,6 +204,8 @@ def main(): os.unlink(dest) open(dest, 'w').close() if validate: + if "%s" not in validate: + module.fail_json(msg="validate must contain %%s: %s" % (validate)) (rc,out,err) = module.run_command(validate % src) if rc != 0: module.fail_json(msg="failed to validate: rc:%s error:%s" % (rc,err)) diff --git a/library/files/lineinfile b/library/files/lineinfile index 780764ad7b..ef629382f2 100644 --- a/library/files/lineinfile +++ b/library/files/lineinfile @@ -154,6 +154,8 @@ def write_changes(module,lines,dest): validate = module.params.get('validate', None) valid = not validate if validate: + if "%s" not in validate: + module.fail_json(msg="validate must contain %%s: %s" % (validate)) (rc, out, err) = module.run_command(validate % tmpfile) valid = rc == 0 if rc != 0: diff --git a/library/files/replace b/library/files/replace index f4193ae9f3..98a2a6a4d8 100644 --- a/library/files/replace +++ b/library/files/replace @@ -90,6 +90,8 @@ def write_changes(module,contents,dest): validate = module.params.get('validate', None) valid = not validate if validate: + if "%s" not in validate: + module.fail_json(msg="validate must contain %%s: %s" % (validate)) (rc, out, err) = module.run_command(validate % tmpfile) valid = rc == 0 if rc != 0: -- cgit v1.2.1