diff options
| author | Brian Havard <bjh@apache.org> | 2010-03-30 10:24:17 +0000 |
|---|---|---|
| committer | Brian Havard <bjh@apache.org> | 2010-03-30 10:24:17 +0000 |
| commit | 45b199ad97cd3404e9885aa178a3bd6afa20e043 (patch) | |
| tree | 882c352f788c541a6a8d1449393418c567ebe038 /file_io/os2 | |
| parent | ba766622625df32abfe96956a3a9a27cb30a4b85 (diff) | |
| download | apr-45b199ad97cd3404e9885aa178a3bd6afa20e043.tar.gz | |
OS/2: Clean up some comment questions.
For the record:
/* XXX: No other possible types from FS3? */
No, FILESTATUS3 info can't specify any types besides regular file and directory
which is why we go on to test the file handle if possible.
From DosQueryHType(), values in the low byte of filetype greater than 2 are
described as "reserved" by the API documentation so should never happen.
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@929069 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'file_io/os2')
| -rw-r--r-- | file_io/os2/filestat.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/file_io/os2/filestat.c b/file_io/os2/filestat.c index cd163e41e..6ae39eeb6 100644 --- a/file_io/os2/filestat.c +++ b/file_io/os2/filestat.c @@ -31,7 +31,6 @@ static void FS3_to_finfo(apr_finfo_t *finfo, FILESTATUS3 *fstatus) finfo->filetype = APR_DIR; else finfo->filetype = APR_REG; - /* XXX: No other possible types from FS3? */ finfo->user = 0; finfo->group = 0; @@ -73,8 +72,7 @@ static apr_status_t handle_type(apr_filetype_e *ftype, HFILE file) break; default: - /* Brian, is this correct??? - */ + /* Values greater than 2 are reserved, this should never happen */ *ftype = APR_UNKFILE; break; } |