summaryrefslogtreecommitdiff
path: root/shmem
diff options
context:
space:
mode:
authorJim Jagielski <jim@apache.org>2014-01-25 20:07:52 +0000
committerJim Jagielski <jim@apache.org>2014-01-25 20:07:52 +0000
commit15e16b298aab807cca05973b315b1a1e6bb1589b (patch)
treeb883c737daff78900953eb3f8f45f0ec6d35f513 /shmem
parent5bd9323dca55171e2e1bb5162397792cefc394f9 (diff)
downloadapr-15e16b298aab807cca05973b315b1a1e6bb1589b.tar.gz
FIXME comment
git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1561384 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'shmem')
-rw-r--r--shmem/unix/shm.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/shmem/unix/shm.c b/shmem/unix/shm.c
index f180c2044..bdb7e6615 100644
--- a/shmem/unix/shm.c
+++ b/shmem/unix/shm.c
@@ -308,6 +308,7 @@ APR_DECLARE(apr_status_t) apr_shm_create(apr_shm_t **m,
}
#endif /* APR_USE_SHMEM_MMAP_TMP */
#if APR_USE_SHMEM_MMAP_SHM
+ /* FIXME: SysV uses 0600... should we? */
tmpfd = shm_open(shm_name, O_RDWR | O_CREAT | O_EXCL, 0644);
if (tmpfd == -1) {
return errno;
@@ -534,6 +535,7 @@ APR_DECLARE(apr_status_t) apr_shm_attach(apr_shm_t **m,
#if APR_USE_SHMEM_MMAP_SHM
const char *shm_name = make_shm_open_safe_name(filename, pool);
+ /* FIXME: SysV uses 0600... should we? */
tmpfd = shm_open(shm_name, O_RDWR, 0644);
if (tmpfd == -1) {
return errno;