diff options
author | Eric Covener <covener@apache.org> | 2016-11-22 01:58:06 +0000 |
---|---|---|
committer | Eric Covener <covener@apache.org> | 2016-11-22 01:58:06 +0000 |
commit | 47b6f6b13194b9121a11062f2192cf215356f121 (patch) | |
tree | f8994158d17458800f8481f5eaf40b3dcf2e4b1b | |
parent | 4958104f465e3f308977da44d370dd625b709da4 (diff) | |
download | httpd-47b6f6b13194b9121a11062f2192cf215356f121.tar.gz |
Merge r1770786 from trunk:
remove Location: header checks for absolute URL
https://tools.ietf.org/html/rfc7231#section-7.1.2
The "Location" header field is used in some responses to refer to a
specific resource in relation to the response. The type of
relationship is defined by the combination of request method and
status code semantics.
Location = URI-reference
The field value consists of a single URI-reference. When it has the
form of a relative reference ([RFC3986], Section 4.2), the final
value is computed by resolving it against the effective request URI
([RFC3986], Section 5).
There is even an example with no scheme:
Location: /People.html#tim
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x-merge-http-strict@1770789 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r-- | modules/http/http_filters.c | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/modules/http/http_filters.c b/modules/http/http_filters.c index 94595b4113..d3e634e2d3 100644 --- a/modules/http/http_filters.c +++ b/modules/http/http_filters.c @@ -749,27 +749,7 @@ static APR_INLINE int check_headers(request_rec *r) if (!apr_table_do(check_header, &ctx, r->headers_out, NULL)) return 0; /* problem has been logged by check_header() */ - if ((loc = apr_table_get(r->headers_out, "Location")) != NULL) { - const char *scheme_end = ap_strchr_c(loc, ':'); - - /* - * Check that the URI has a valid scheme and is absolute - * XXX Should we do a full uri parse here? - */ - if (!ap_is_url(loc)) - goto bad; - - if (scheme_end[1] != '/' || scheme_end[2] != '/') - goto bad; - } - return 1; - -bad: - ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(02431) - "Bad Location header in response: '%s', aborting request", - loc); - return 0; } typedef struct header_struct { |