summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Hughes <richard@hughsie.com>2016-08-27 08:31:06 +0100
committerRichard Hughes <richard@hughsie.com>2016-08-27 08:31:06 +0100
commit96a4385236b91539ac6ce12cdbb85094e01d4986 (patch)
tree08114407172ca2bac8c01f4cddbccbf00d4cf092
parent67f486be685533602eba085fc4accdabda6be4bf (diff)
downloadappstream-glib-96a4385236b91539ac6ce12cdbb85094e01d4986.tar.gz
trivial: Actually apply the warning flags
-rw-r--r--configure.ac1
-rw-r--r--libappstream-builder/asb-package-rpm.c2
2 files changed, 2 insertions, 1 deletions
diff --git a/configure.ac b/configure.ac
index 77e53ef..8cd1b34 100644
--- a/configure.ac
+++ b/configure.ac
@@ -111,6 +111,7 @@ WARN_CFLAGS_EXTRA="
-Wunused-but-set-variable
-Wwrite-strings"
AX_APPEND_COMPILE_FLAGS([$WARN_CFLAGS_EXTRA], [WARN_CFLAGS])
+AC_SUBST(WARN_CFLAGS)
# internationalization
AM_GNU_GETTEXT([external])
diff --git a/libappstream-builder/asb-package-rpm.c b/libappstream-builder/asb-package-rpm.c
index 9c14dd1..ef80584 100644
--- a/libappstream-builder/asb-package-rpm.c
+++ b/libappstream-builder/asb-package-rpm.c
@@ -450,7 +450,7 @@ asb_package_rpm_open (AsbPackage *pkg, const gchar *filename, GError **error)
ts = rpmtsCreate ();
rpmtsSetVSFlags (ts, _RPMVSF_NODIGESTS | _RPMVSF_NOSIGNATURES);
fd = Fopen (filename, "r");
- if (fd <= 0) {
+ if (fd == NULL) {
ret = FALSE;
g_set_error (error,
ASB_PLUGIN_ERROR,