summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Hughes <richard@hughsie.com>2016-02-26 20:58:03 +0000
committerRichard Hughes <richard@hughsie.com>2016-02-26 20:58:03 +0000
commit9b13cb7d3ee4154ef646e31e91d994dad2531bf5 (patch)
tree0b86a883ce588ab9a155244bd0ffa738db0d9163
parent2b03dcc668b48f8a9e6e769a62f14470902af513 (diff)
downloadappstream-glib-9b13cb7d3ee4154ef646e31e91d994dad2531bf5.tar.gz
trivial: Do not require icons for generic component types
-rw-r--r--libappstream-builder/asb-context.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/libappstream-builder/asb-context.c b/libappstream-builder/asb-context.c
index 264b5d9..3ed3311 100644
--- a/libappstream-builder/asb-context.c
+++ b/libappstream-builder/asb-context.c
@@ -956,10 +956,15 @@ asb_context_detect_missing_data (AsbContext *ctx, GError **error)
as_app_add_veto (AS_APP (app), "No <name> in AppData");
if (as_app_get_comment (AS_APP (app), "C") == NULL)
as_app_add_veto (AS_APP (app), "No <summary> in AppData");
- if (as_app_get_kind (AS_APP (app)) != AS_APP_KIND_ADDON &&
- as_app_get_kind (AS_APP (app)) != AS_APP_KIND_FIRMWARE) {
+ switch (as_app_get_kind (AS_APP (app))) {
+ case AS_APP_KIND_ADDON:
+ case AS_APP_KIND_FIRMWARE:
+ case AS_APP_KIND_GENERIC:
+ break;
+ default:
if (as_app_get_icon_default (AS_APP (app)) == NULL)
as_app_add_veto (AS_APP (app), "Has no Icon");
+ break;
}
}
return TRUE;