diff options
| author | Richard Hughes <richard@hughsie.com> | 2016-01-21 20:11:00 +0000 |
|---|---|---|
| committer | Richard Hughes <richard@hughsie.com> | 2016-01-22 18:48:45 +0000 |
| commit | f3306629a1863dae3a03716f277952b8c65cfa9d (patch) | |
| tree | bba2bb1395bc44a40cfb134a98c637e8dde27d9e /libappstream-glib/as-app-validate.c | |
| parent | b7acc0361c6a2b14bdfe14cd2a84941f0f50d099 (diff) | |
| download | appstream-glib-f3306629a1863dae3a03716f277952b8c65cfa9d.tar.gz | |
Reject an invalid project group when parsing
Diffstat (limited to 'libappstream-glib/as-app-validate.c')
| -rw-r--r-- | libappstream-glib/as-app-validate.c | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/libappstream-glib/as-app-validate.c b/libappstream-glib/as-app-validate.c index bce8f13..445ccbe 100644 --- a/libappstream-glib/as-app-validate.c +++ b/libappstream-glib/as-app-validate.c @@ -1239,17 +1239,6 @@ as_app_validate (AsApp *app, AsAppValidateFlags flags, GError **error) } } - /* project_group */ - tmp = as_app_get_project_group (app); - if (tmp != NULL) { - if (!as_utils_is_environment_id (tmp)) { - ai_app_validate_add (&helper, - AS_PROBLEM_KIND_TAG_INVALID, - "<project_group> is not valid [%s]", - tmp); - } - } - /* pkgname */ if (as_app_get_pkgname_default (app) != NULL && as_app_get_source_kind (app) == AS_APP_SOURCE_KIND_METAINFO) { @@ -1325,6 +1314,13 @@ as_app_validate (AsApp *app, AsAppValidateFlags flags, GError **error) } } + /* check invalid values */ + if ((problems & AS_APP_PROBLEM_INVALID_PROJECT_GROUP) > 0) { + ai_app_validate_add (&helper, + AS_PROBLEM_KIND_TAG_INVALID, + "<project_group> is not valid"); + } + /* check for things that have to exist */ if (as_app_get_id (app) == NULL) { ai_app_validate_add (&helper, |