| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
| |
commit 562772 introduced the usage of pngquant (by calling out to the binary)
and makes use of the --strip parameter, which was introduced in version 2.8 of pngquant.
|
|
|
|
| |
Fixes https://github.com/hughsie/appstream-glib/issues/203
|
|
|
|
| |
Fixes an extraction issue when using OpenSUSE.
|
|
|
|
|
|
|
|
|
|
|
|
| |
When saving a 16:9 pixbuf and the image parameter is not 16:9 we create
a transparent pixbuf with this ratio and fit the image in it. However,
this calculation was not correctly done due to an integer division so
the result is that the width/height of the pixbuf's area to be copied
was bigger than what the dimensions of the pixbuf; so no image was
copied and we'd be left with a trasnparent pixbuf.
This patch fixes this problem by using multiplications instead of
a division in the mentioned code (as they avoid imprecision problems).
|
| |
|
| |
|
| |
|
|
|
|
| |
Fixes a build error with the mcomix package in openSUSE.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
follow-up from commit 9df56f2
|
|
|
|
| |
Fixes https://github.com/hughsie/appstream-glib/issues/190
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Any XML parser should ignore the extra tags or attributes, and so it serves no
purpose to artificailly hide these when building metadata for older versions of
the specification.
This also fixes a bug on i386 where 0.6 != 0.6 and I didn't want to use fabs()
all over the place for basically no reason.
|
| |
|
|
|
|
| |
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This fallback mechanism is useful when it comes to PackageKit type apps,
but for Flatpak ones will result in GNOME Software trying to look for a
remote called "flatpak" and: 1) if it exists, the app is associated with
it erroneously, or 2) if it doesn't exist, an error banner will be shown
in the UI.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
A few more assertions in the tests, as suggested by Coverity, covering
return values which aren’t currently checked.
Coverity CIDs: 1454186, 1454188
Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
|
|
|
|
|
|
|
|
|
| |
There’s a precondition check for (search != NULL), so the function will
hit an assertion failure before this branch.
Coverity CID: 1454189
Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
|
|
|
|
|
|
|
|
| |
I don’t want to have to think about the right GNU feature test macro to
get strcasecmp() to stop hiding in the system headers. Also, we only
care about ASCII here because we’re dealing with config files.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|
|
|
|
|
|
| |
We need realpath() for libappstream-builder, which needs the
_XOPEN_SOURCE feature test macro. Define it.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|
|
|
|
|
|
|
|
| |
We use C99 features (various places in as-app-validate.c), so need to
explicitly enable them in meson.build, as some compilers will not enable
them automatically, and will instead error when they encounter usage of
C99.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|
|
|
|
|
|
|
| |
This makes asglib align with the AppStream spec, which sees
/usr/share/metainfo as the canonical location for storing metadata, and
/usr/share/appdata as legacy (but still must-be-supported) location.
Signed-off-by: Richard Hughes <richard@hughsie.com>
|
|
|
|
| |
Fixes: https://github.com/hughsie/appstream-glib/issues/187
|
|
|
|
| |
Of course this was going to change the number of warnings... coffee time...
|
|
|
|
|
|
|
| |
We now have <launchable> which means the <id> is less constrained for desktop
components. The checks for the other types are somewhat dubious too.
Fixes: https://github.com/hughsie/appstream-glib/issues/146
|
|
|
|
|
|
| |
If the icon is not redistributable we have to download the icon at runtime.
Fixes: https://github.com/flathub/buildbot-config/issues/9
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
As as_app_parse_file() uses %AS_APP_TRUST_FLAG_CHECK_DUPLICATES our existing
validation rule checker to work. Add this to the AsAppProblems bitfield and
check this for a validation failure.
Now:
• tag-invalid : <screenshot> content was duplicated
Fixes: https://github.com/hughsie/appstream-glib/issues/185
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 081ced436 made the gperf dependency mandatory, but that seems to
have been partially lost in the migration to Meson. If building without
gperf available, Meson configure would succeed, but then build would
fail due to as-tag-private.h not being generated.
Fix that by removing the conditions for gperf in the meson.build files.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|
|
|
|
|
| |
Accidentally dropped when ported to meson
Fixes: https://github.com/hughsie/appstream-glib/issues/183
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling g-ir-scanner when cross-compiling with bitbake/OpenEmbedded
fails because it calls the wrong ld (the one from the host). More work
will be needed in meson.bbclass and/or gobject-introspection.bbclass
to make it work.
In the meantime, having an option to turn of introspection is useful
perhaps also in other cases where the extra work is not needed. For
example, fwupd works fine also when it is off.
The name of the new meson option matches the --disable-introspection
that is used by some autotools-based projects.
Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
|
|
|
|
|
|
|
|
|
|
| |
gdk is only needed by the asb_plugin_font, which only gets built when
both appstream-build and fonts are enabled. Therefore checking for the
dependency should also be limited to that case, otherwise gdk has to
be provided during compilation also in cases where it is not used at
all.
Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
|
|
|
|
| |
This fixes the build for appstream-glib on Mageia.
|
|
|
|
|
|
| |
So that software centres don't present them as removable.
Closes #175
|
| |
|
|
|
|
| |
Don't load data from the snap directory, this information is provided by snapd.
|
|
|
|
|
| |
This allows us to make reviews work when upstream moves or changes company,
e.g. com.github.ColorHug -> com.hughski.ColorHug.
|