summaryrefslogtreecommitdiff
path: root/libappstream-glib/as-app-desktop.c
Commit message (Collapse)AuthorAgeFilesLines
* Veto apps that have empty OnlyShowIn=Kalev Lember2018-04-171-1/+4
| | | | | | | | | Apps that have OnlyShowIn= are equivalent to NoDisplay=True (gnome-shell doesn't show them). Veto such apps to avoid them inadvertently showing up in gnome-software and to match gnome-shell behaviour. https://bugzilla.redhat.com/show_bug.cgi?id=1567689 https://gitlab.gnome.org/GNOME/gnome-software/issues/367
* as-app-desktop: don't deference invalid listsMarco Trevisan (Treviño)2018-01-231-4/+4
| | | | | Malformed .desktop files might causes crashes when returned lists are NULL.
* libappstream-glib: Use g_ascii_strcasecmp() instead of strcasecmp()Philip Withnall2017-08-151-1/+1
| | | | | | | | I don’t want to have to think about the right GNU feature test macro to get strcasecmp() to stop hiding in the system headers. Also, we only care about ASCII here because we’re dealing with config files. Signed-off-by: Philip Withnall <withnall@endlessm.com>
* Tighten a rule that classifies apps as web-appsKalev Lember2017-01-161-1/+1
| | | | | | ... so that Epiphany itself wouldn't get classified as one. https://bugzilla.gnome.org/show_bug.cgi?id=776860
* trivial: Remove two unused variablesKalev Lember2016-11-071-1/+0
|
* trivial: Only load native languages from desktop files when the flag is setRichard Hughes2016-11-031-0/+12
| | | | This saves 40ms from the AsStore startup time.
* Convert the built unknown icons to the correct kind depending on the actionRichard Hughes2016-09-051-2/+1
| | | | | | For building we want ->CACHED, for parsing local files we want ->STOCK. Fixes the other half of https://github.com/hughsie/appstream-glib/pull/128
* Refactor the desktop file icon loading codeRichard Hughes2016-09-041-26/+46
| | | | | | | Using the old logic we could have created a LOCAL icon with just the name set, which is further confused by using LOCAL for the fallback name case. Fixes half of https://github.com/hughsie/appstream-glib/pull/128
* Revert "as-app-desktop: Fix association between icon names and types (#128)"Richard Hughes2016-08-221-7/+27
| | | | This reverts commit 714e78b188872e9866956db95f22efe4e37189c5.
* as-app-desktop: Fix association between icon names and types (#128)Philip Withnall2016-08-221-27/+7
| | | | | | | | | | | AsIcon documents that STOCK icons should have the name set; and that LOCAL icons should have the filename set. The previous approach to extracting these properties from as_app_parse_file_key() could sometimes result in a LOCAL icon with no filename set, if tmp was not an icon name and not a fallback icon name. Now, we assume that (as long as tmp is not an absolute path) this means it's an icon name for an icon which is not installed, and hence the AsIcon type should be STOCK. Signed-off-by: Philip Withnall <philip.withnall@collabora.co.uk>
* Do not save the 'X-' prefixed keys to the AppStream metadataRichard Hughes2016-07-151-9/+33
| | | | Continue to load them at runtime from installed desktop files.
* Fix missing keywords in the previous commitJoaquim Rocha2016-07-121-2/+2
| | | | | While cleaning up some cosmetic issues I managed to exclude some important parts of the changes...
* Add external (X-*) keys of an app's desktop file as metadata AsAppJoaquim Rocha2016-07-121-0/+10
| | | | | This is helpful for use-cases where those keys are needed by users of the library.
* trivial: Remove the X- hack from parsing the category listRichard Hughes2016-07-121-4/+0
| | | | We already check the whitelist, so nothing changes really.
* trivial: Get rid of useless internal-only gtk-doc markupRichard Hughes2016-06-281-18/+0
|
* Ignore desktop files with X-AppStream-IgnoreRichard Hughes2016-04-041-0/+10
|
* Always veto anything with X-Unity-Settings-PanelRichard Hughes2016-03-311-0/+12
|
* Rename a symbol to reflect realityRichard Hughes2016-02-251-2/+2
| | | | | | | This has not been an ID kind since spec version 0.5, and it's confusing to have two things in GNOME Software. The old symbols and enumerated types are left to maintain ABI compatibility.
* Move the blacklisted application list to the front-end clientRichard Hughes2016-01-171-4/+0
| | | | | | | | | At the moment the blacklist list is being used to filter applications that have an AppData file, and also installed desktop files. I agree it's wrong to filter applications with valid AppData files from the metadata, and the various runtime blacklist entries are better suited to the front-end application which can adjust it as the design dictates.
* Detect web-apps which are added as .desktop filesRichard Hughes2016-01-151-0/+13
|
* Return the correct error when the desktop file has no [Desktop Entry] groupRichard Hughes2015-11-021-0/+10
| | | | Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=754313
* trivial: Fix a typo in commentKalev Lember2015-10-141-1/+1
|
* Try harder to deal with icons that have extension or full path listedKalev Lember2015-10-141-3/+14
| | | | | | | It's a common mistake in desktop files to list icons with extension, such as 'filename.png'. Try harder to handle them and special case common extensions; also while at this, make sure to handle icons with full path as well.
* trivial: Remove a now-unused veto ruleRichard Hughes2015-09-171-9/+0
|
* trivial: Drop as-cleanup.h include where not neededKalev Lember2015-09-081-1/+0
|
* Use GLib's cleanup functions instead of libgsystem'sKalev Lember2015-09-081-13/+13
| | | | | | | We still have a few types that don't support g_autoptr(), but very very close to having everything ported over. This also bumps gdk-pixbuf dep to 2.31.5 for the cleanup macro support.
* Drop the unused _len arguments on many functionsRichard Hughes2015-08-031-26/+24
| | | | | | Using the length of -1 for 'unknown' breaks the GIR-generated bindings. This breaks API and ABI and the soname has been updated to reflect this.
* When building metadata with the use-fallback flag accept legacy icon namesRichard Hughes2015-06-161-1/+27
|
* Add a flag to use non-optimal data sources when building metadataRichard Hughes2015-06-161-0/+49
| | | | | This could be, for example, using the desktop GenericName in the place of Comment or <summary> for a one line summary.
* Fix a potential crash spotted by clangRichard Hughes2015-05-281-1/+1
|
* trivial: Split off the desktop file parsing to it's own source fileRichard Hughes2015-03-091-0/+385
No logic changes other than the moved code.