From 6381fb7837f34e70eb62934c688f24d2f49b4f12 Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Sat, 26 Nov 2016 10:19:03 +0000 Subject: trivial: Fix a tiny memory leak when escaping cdata --- libappstream-glib/as-node.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libappstream-glib/as-node.c b/libappstream-glib/as-node.c index 9277f81..23ad52d 100644 --- a/libappstream-glib/as-node.c +++ b/libappstream-glib/as-node.c @@ -271,9 +271,6 @@ as_node_cdata_to_raw (AsNodeData *data) static void as_node_cdata_to_escaped (AsNodeData *data) { - GString *str; - g_autofree gchar *tmp = NULL; - if (data->is_root_node) return; if (data->is_cdata_escaped) @@ -281,7 +278,7 @@ as_node_cdata_to_escaped (AsNodeData *data) if (g_strstr_len (data->cdata, -1, "&") != NULL || g_strstr_len (data->cdata, -1, "<") != NULL || g_strstr_len (data->cdata, -1, ">") != NULL) { - str = g_string_new (data->cdata); + g_autoptr(GString) str = g_string_new (data->cdata); as_ref_string_unref (data->cdata); as_utils_string_replace (str, "&", "&"); as_utils_string_replace (str, "<", "<"); -- cgit v1.2.1