From 0ce2e0b8e8d2dd9be986a7fced0450aa71f181bd Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Tue, 14 May 2019 13:28:18 +0100 Subject: Do not require for validation unless strict Fixes some of https://github.com/hughsie/appstream-glib/issues/302 --- libappstream-glib/as-self-test.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'libappstream-glib/as-self-test.c') diff --git a/libappstream-glib/as-self-test.c b/libappstream-glib/as-self-test.c index d065256..ce00247 100644 --- a/libappstream-glib/as-self-test.c +++ b/libappstream-glib/as-self-test.c @@ -2266,8 +2266,6 @@ as_test_app_validate_file_bad_func (void) " is not valid"); as_test_app_validate_check (probs, AS_PROBLEM_KIND_TAG_INVALID, " is not valid"); - as_test_app_validate_check (probs, AS_PROBLEM_KIND_TAG_MISSING, - " is not present"); as_test_app_validate_check (probs, AS_PROBLEM_KIND_TAG_INVALID, " does not start with 'http://'"); as_test_app_validate_check (probs, AS_PROBLEM_KIND_MARKUP_INVALID, @@ -2307,7 +2305,7 @@ as_test_app_validate_file_bad_func (void) " timestamp is in the future"); as_test_app_validate_check (probs, AS_PROBLEM_KIND_MARKUP_INVALID, " has invalid character"); - g_assert_cmpint (probs->len, ==, 23); + g_assert_cmpint (probs->len, ==, 22); /* again, harder */ probs2 = as_app_validate (app, AS_APP_VALIDATE_FLAG_STRICT, &error); @@ -2343,15 +2341,13 @@ as_test_app_validate_meta_bad_func (void) problem = g_ptr_array_index (probs, i); g_debug ("%s", as_problem_get_message (problem)); } - g_assert_cmpint (probs->len, ==, 7); + g_assert_cmpint (probs->len, ==, 6); as_test_app_validate_check (probs, AS_PROBLEM_KIND_TAG_MISSING, " is not present"); as_test_app_validate_check (probs, AS_PROBLEM_KIND_TAG_MISSING, " is not present"); as_test_app_validate_check (probs, AS_PROBLEM_KIND_TAG_MISSING, " is not present"); - as_test_app_validate_check (probs, AS_PROBLEM_KIND_TAG_MISSING, - " is not present"); as_test_app_validate_check (probs, AS_PROBLEM_KIND_TAG_MISSING, " is not present"); as_test_app_validate_check (probs, AS_PROBLEM_KIND_TAG_MISSING, -- cgit v1.2.1