| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
| |
It is dangerous to unref cache objects inside a g_hash_table_foreach,
since, if the object is finalized, it will be removed, which can cause
problems with the iterator. Instead, make a GSList of the objects to
unref, then use this GSList to unref.
|
| |
|
|
|
|
|
|
|
| |
It is possible, at least in theory, that querying one accessible could
have the side effect of another accessible being dereferenced. If this
results in the accessible being finalized, then this would likely cause
a crash when potentially iterating over the newly-finalized object.
Hopefully fixes http://bugzilla.gnome.org/show_bug.cgi?id=664822
|
| | |
|
| |
|
|
|
|
|
|
| |
It should be enough to retrieve some info about the children, in the
socket adaptor's handler for the "Embedded" D-Bus method. Asking for
the number of the plug's children seems to be a good candidate.
https://bugzilla.gnome.org/show_bug.cgi?id=663876
|
| |
|
|
|
|
|
|
|
|
| |
Calls to atk_object_ref_state_set() are expected to return a valid
state set always, so it would be better if this implementation of
socket's ref_state_set() returned empty sets instead of just NULL, to
avoid calling to atk_state_set_*() functions over invalid instances of
AtkStateSet (e.g. add_pending_items() in accessible-cache.c).
https://bugs.freedesktop.org/show_bug.cgi?id=42350
|
| |
|
|
|
|
|
|
| |
spi_dbus_message_iter_append_struct has an early exit where it
forgets to call va_end(). Harmless most of the time, but it
upsets static analyzers.
https://bugzilla.gnome.org/show_bug.cgi?id=662248
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The workaround that was committed for this didn't have the
intended effect, since the timeout was added to the default
main context, not the one that is used in the recursive
mainloop.
Without this patch, my login screen would freeze when hitting
Enter in the password entry, with it, I could successfully log
in 10 out of 10 times.
https://bugzilla.gnome.org/show_bug.cgi?id=658013
|
| | |
|
| |
|
|
|
|
|
| |
For some reason, if the dbus connection goes away during a call to
NotifyListenersSync, the DBusPendingCall is not notified. This may be a
libdbus bug. Working around the issue by adding a timeout that will
check for a disconnect and abort the call as needed.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Bytestrings (ay) are formatted as b'...'.
https://bugzilla.gnome.org/show_bug.cgi?id=658102
|
| |
|
|
|
|
| |
According to Christian Persch, paths are not strings because they may be
non-UTF-8, so they must use "ay" instead of "s" for their type in a
GSettings schema.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Now ATK has AtkWindow, so the format to register to window events
is like any other ATK event
We check if we need to register using the old format, assuming that
if you are able to register to a window event using the old format
is because the ATK implementor is still using the old one. This
check should be temporal.
|
| | |
|
| |
|
|
|
|
|
| |
If gnome_accessibility_module_shutdown was called and followed by a call
to gnome_accessibility_module_init, then things would go awry because of
various resources not being freed. Fixed several of these issues,
although some issues might remain.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Remove "common" directory (it was an artifact of at-spi2-core and
at-spi2-atk originally living in the same repository). Where constants
essentially duplicated other constants in libatspi, use the constants defined
in libatspi, renaming as needed. Otherwise move code from common into
atk-adaptor.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
When a state-change:defunct is received, remove the object from the
dbus-path-to-object-mapping hash. Also, avoid enumerating an object's
children in a call to GetItems if the object is marked defunct. This
should mostly shield the ATK implementation from being called on objects
that have been marked defunct.
Also removed a seemingly unnecessary g_strdup/g_free pair.
|
| | |
|
| |
|
|
|
|
|
|
| |
Track whether clients are listening, based on calls to GetItems and
event listener registrations, and disable event handlers if no clients
are listening. Note that this currently handles event listeners in bulk
and could be refined to only connect to individual signals that are
being listened to.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
libatspi currently listens for ChildrenChanged, PropertyChange, and
StateChanged events but does not call RegisterEvent for them.
Intending to come up with a better fix for 2.2.
|
| |
|
|
|
|
|
| |
- cache-adaptor.c makes use of AtkStateSet* .
- atk-bridge uses X.
- -Werror-implicit-function-declaration doesn't contain an equal sign in
my copy of gcc, and is gcc specific.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
When we receive strings from atk, we should ensure that they are valid UTF-8
before sending them over D-Bus, since bad UTF-8 will cause dbus-daemon to
kill the connection.
|
| | |
|
