| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
Fixes https://gitlab.gnome.org/GNOME/at-spi2-atk/issues/5
|
| |
|
| |
|
|
|
|
|
| |
The AtkComponent scrolling methods have been introduced in ATK 2.29.2,
so we need to require at least that version.
|
|
|
|
| |
And bring both a bit more up to date.
|
|
|
|
|
| |
We should always use `#include "config.h"`, as the header is local to
the project, not part of the system include paths.
|
|
|
|
|
|
| |
All major build systems and distributors downstream know how to handle
Meson, these days, so there's no need to provide an Autotools
compatibility wrapper.
|
|
|
|
|
| |
Instead of using a template, we can ask Meson to generate the file for
us from the various build targets.
|
|
|
|
| |
We never even assigned its return value.
|
|
|
|
|
| |
The tests are still meant to be used by hand, not as part of a test
suite.
|
|
|
|
|
|
|
|
| |
We know we're using deprecated API, so there's no real point in keeping
the warnings.
The deprecation warnings are useful during development cycles, so we can
port away from deprecated API.
|
|
|
|
| |
Leftovers from previous iterations.
|
|
|
|
|
|
|
|
|
|
| |
Uninitialized variables in C have undefined content; some compilers,
with some debugging flags, may decide to set them to 0, but you cannot
ever rely on that.
If the text variable is unset the validation when appending it to the
message payload may still pass, and we may end up sending random junk
over the wire — or, segfault.
|
|
|
|
|
| |
We only use walkm() for debugging purposes, and if we leave it there,
the compiler is going to be very disappointed.
|
|
|
|
| |
Avoid a compiler warning.
|
|
|
|
|
|
| |
Starting for GLib 2.54, g_object_ref() warns if we acquire a reference
on a variable of a certain type, and assign the result to a variable of
a different type.
|
|
|
|
|
| |
The leak fix in commit c45b5870 removed a return in an error path. Let's
put it back.
|
|
|
|
|
| |
The precondition check for a function returning a boolean should not
return NULL.
|
|
|
|
| |
Avoid the compiler warning us that `out` is defined but unused.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
It is not possible to use cache,
after child_added_listener(or toplevel_added_listener) returns by calling
g_return_val_if_fail, without g_rec_mutex_unlock.
https://bugzilla.gnome.org/show_bug.cgi?id=793625
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
Meson is a fast, portable, easy to understand meta-build system. It is
currently being adopted in various projects inside GNOME alongside
Autotools, in the hope of making it the default build system for future
releases.
|
| |
| |
| |
| |
| |
| |
| | |
Map the new relation types from ATK to AT-SPI2. Also bump minimum version
of at-spi2-core to 2.25.3.
https://bugzilla.gnome.org/show_bug.cgi?id=783008
|
| |
| |
| |
| | |
ATK_ROLE_FOOTNOTE was added on 2.25.2
|
| | |
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=782823
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit maps the following roles:
* ATK_ROLE_DESCRIPTION_LIST to ATSPI_ROLE_DESCRIPTION_LIST
* ATK_ROLE_DESCRIPTION_TERM to ATSPI_ROLE_DESCRIPTION_TERM
* ATK_ROLE_DESCRIPTION_VALUE to ATSPI_ROLE_DESCRIPTION_VALUE
https://bugzilla.gnome.org/show_bug.cgi?id=782748
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems that not all code expects atk_object_ref_accessible_child()
returning NULL, neither that it can return an object with only one
reference, thus the following unref in the code can cause use-after-free
eventually.
At least the chunk in impl_GetChildAtIndex() avoids runtime warning about
invalid object being passed to g_object_unref(), which happened, in this
case, when evolution returned NULL. Evolution returns objects with one
reference only often, which tries to address the other chunks here.
https://bugzilla.gnome.org/show_bug.cgi?id=781716
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As pointed out by this valgrind log:
==2809== Thread 1:
==2809== Invalid write of size 8
==2809== at 0x18FCF001: remove_events (bridge.c:759)
==2809== by 0x18FCF001: handle_event_listener_deregistered (bridge.c:788)
==2809== by 0x18FCF001: signal_filter (bridge.c:827)
==2809== by 0x200ECDFD: dbus_connection_dispatch (dbus-connection.c:4631)
==2809== by 0x1FEBD0F4: ??? (in /usr/lib64/libatspi.so.0.0.1)
==2809== by 0xFD8D4C8: g_main_dispatch (gmain.c:3201)
==2809== by 0xFD8D4C8: g_main_context_dispatch (gmain.c:3854)
==2809== by 0xFD8D817: g_main_context_iterate.isra.21 (gmain.c:3927)
==2809== by 0xFD8DAE9: g_main_loop_run (gmain.c:4123)
==2809== by 0xDFF84B4: gtk_main (in /usr/lib64/libgtk-3.so.0.2200.10)
==2809== by 0x403DE0: main (in /usr/bin/evolution)
==2809== Address 0x29f22540 is 16 bytes inside a block of size 24 free'd
==2809== at 0x4C2ACDD: free (vg_replace_malloc.c:530)
==2809== by 0xFD92BCD: g_free (gmem.c:189)
==2809== by 0xFDAA518: g_slice_free1 (gslice.c:1136)
==2809== by 0xFD89463: g_list_remove (glist.c:521)
==2809== by 0x18FCF000: remove_events (bridge.c:759)
==2809== by 0x18FCF000: handle_event_listener_deregistered (bridge.c:788)
==2809== by 0x18FCF000: signal_filter (bridge.c:827)
==2809== by 0x200ECDFD: dbus_connection_dispatch (dbus-connection.c:4631)
==2809== by 0x1FEBD0F4: ??? (in /usr/lib64/libatspi.so.0.0.1)
==2809== by 0xFD8D4C8: g_main_dispatch (gmain.c:3201)
==2809== by 0xFD8D4C8: g_main_context_dispatch (gmain.c:3854)
==2809== by 0xFD8D817: g_main_context_iterate.isra.21 (gmain.c:3927)
==2809== by 0xFD8DAE9: g_main_loop_run (gmain.c:4123)
==2809== by 0xDFF84B4: gtk_main (in /usr/lib64/libgtk-3.so.0.2200.10)
==2809== by 0x403DE0: main (in /usr/bin/evolution)
==2809== Block was alloc'd at
==2809== at 0x4C29BE3: malloc (vg_replace_malloc.c:299)
==2809== by 0xFD92ABD: g_malloc (gmem.c:94)
==2809== by 0xFDA9EFD: g_slice_alloc (gslice.c:1025)
==2809== by 0xFD89983: g_list_append (glist.c:261)
==2809== by 0x18FCE7EE: add_event (bridge.c:80)
==2809== by 0x18FCE7EE: add_event_from_iter (bridge.c:217)
==2809== by 0x18FCEEF6: handle_event_listener_registered (bridge.c:721)
==2809== by 0x18FCEEF6: signal_filter (bridge.c:825)
==2809== by 0x200ECDFD: dbus_connection_dispatch (dbus-connection.c:4631)
==2809== by 0x1FEBD0F4: ??? (in /usr/lib64/libatspi.so.0.0.1)
==2809== by 0xFD8D4C8: g_main_dispatch (gmain.c:3201)
==2809== by 0xFD8D4C8: g_main_context_dispatch (gmain.c:3854)
==2809== by 0xFD8D817: g_main_context_iterate.isra.21 (gmain.c:3927)
==2809== by 0xFD8DAE9: g_main_loop_run (gmain.c:4123)
==2809== by 0xDFF84B4: gtk_main (in /usr/lib64/libgtk-3.so.0.2200.10)
This line:
list->prev = g_list_remove (list->prev, evdata);
writes over free'd memory since the list link pointed to by the 'list'
pointer is free'd by g_list_remove(). We can use g_list_delete_link()
instead to achieve the intended result (and not re-iterate the whole
list) with less code overall.
Thanks to Milan Crha <mcrha@redhat.com> for investigating and
providing the valgring log.
https://bugzilla.gnome.org/show_bug.cgi?id=781658
|
| |
|
| |
|
|
|
|
|
| |
This function no longer exists, and the test causes a build error.
TODO: we need a test for atk_table_cell_get_position.
|
| |
|
| |
|
|
|
|
|
|
| |
The include guard for accessible-stateset.h has a typo.
https://bugzilla.gnome.org/show_bug.cgi?id=773744
|
|
|
|
|
|
| |
At-spi2-core generally caches properties, so it needs notification when these
properties change. signal_is_needed() was intended to account for this but
failed to do so because of n incorrect strcmp.
|
| |
|