summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * New document on changes to the XML signaturesFederico Mena Quintero2022-12-122-0/+31
| | | | | | | | | | Let's document functional changes to help people who write bindings based on the XML.
| * DeviceEventController.xml: document the RegisterKeystrokeListener methodFederico Mena Quintero2022-12-122-2/+42
| | | | | | | | | | | | | | | | This method is still used, but is in the process of deprecation by the atspi-device-listener functions. I'm documenting it to have a reference of what the dbus demarshalling code is supposed to do.
| * DeviceEventController.xml: fix the signature of the "types" argumentFederico Mena Quintero2022-12-121-1/+1
| | | | | | | | The code uses "u"; the XML was "au" - the argument is really a bitmask.
| * Use g_new0 instead of g_mallocFederico Mena Quintero2022-12-121-5/+3
| | | | | | | | Also, g_new0 can't fail, so don't check its result value.
| * spi_dec_init_mouse_listener() - remove no-op functionFederico Mena Quintero2022-12-091-28/+0
| | | | | | | | | | All its code was inside an "#ifdef GRAB_BUTTON", which is not defined anywhere. Anyway, we don't do mouse grabs here anymore.
| * CI: run all tests under xvfb-run, i.e. under an X serverFederico Mena Quintero2022-12-091-5/+5
| | | | | | | | This lets us start getting test coverage for the X11 paths.
| * CI: install xorg-x11-devel to test the X11 code pathsFederico Mena Quintero2022-12-091-1/+2
| |
| * CI: install xvfb-run to be able to run X11 testsFederico Mena Quintero2022-12-091-1/+3
| |
| * Remove unused enum variantsFederico Mena Quintero2022-12-091-2/+0
| |
| * tests: use "gdbus wait" after launching the mocks instead of sleepingFederico Mena Quintero2022-12-082-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | On a busy system (the CI runners) or one with a cold cache (my machine when running the tests after just having started the CI container image), the "sleep 1" we had in the test runner scripts is not a reliable way for the python/dbusmock process to have acquired the name it is supposed to acquire. So, use "gdbus wait" instead as a reliable way of doing that. This should fix the spurious test failures we've been having in CI.
| * Rename de-marshaller.[ch] to marshal-dbus.[ch]Federico Mena Quintero2022-12-085-5/+5
| | | | | | | | | | | | | | I'll put all the libdbus-based marshallers in that file. Later I want to have a marshal-gdbus.[ch] counterpart, to let us port things gradually to gdbus.
* | atk-adaptor: Don't leak the socket in impl_GetChildAtIndexMike Gorse2022-12-121-0/+1
| |
* | atk-adaptor: Handle sockets in impl_GetChildrenMike Gorse2022-12-121-0/+26
|/ | | | | | | This was special-cased for ChildCount and GetChildAtIndex, but not for GetChildren. Fixes #98
* Fix links to source files in devel guideFederico Mena Quintero2022-12-071-7/+9
|
* Sigh, fix RST markupFederico Mena Quintero2022-12-071-2/+2
|
* Merge branch 'clang-format' into 'main'Federico Mena Quintero2022-12-07260-13470/+13605
|\ | | | | | | | | | | | | Add an auto-formatting check in CI Closes #97 See merge request GNOME/at-spi2-core!119
| * Note on the order of header filesFederico Mena Quintero2022-12-071-0/+20
| |
| * Note how to run clang-format by handFederico Mena Quintero2022-12-071-3/+6
| |
| * Remove detritus from the markdown->reStructuredText conversionFederico Mena Quintero2022-12-071-4/+0
| |
| * Document the code formatting machineryFederico Mena Quintero2022-12-073-11/+62
| |
| * CI: add a style-check-diff jobFederico Mena Quintero2022-12-071-12/+9
| |
| * Remove ci/search-common-ancestor.sh, it's no longer usedFederico Mena Quintero2022-12-071-43/+0
| |
| * Update ci/run-style-check.shFederico Mena Quintero2022-12-072-16/+30
| |
| * Reformat all the *.[ch] files with clang-formatFederico Mena Quintero2022-12-06255-13391/+13478
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I ran this on each directory with C files: clang-format -i *.[ch] "-i" is the in-place option. I also adjusted the order of #includes for some files which failed to build after that: Clang-format reorders blocks of #include directives alphabetically, but they can be grouped and separated by blank lines. If there is a blank line between blocks, like #include "zork.h" #include "bar.h" #include "foo.h" then it will not put zork.h after the other two. The last two header files will be sorted alphabetically. We can adjust the formatting of chunks of code by hand with comments like these: /* clang-format off */ this code { is, formatted, by, hand; } /* clang-format on */ See https://clang.llvm.org/docs/ClangFormat.html for the general manual and https://clang.llvm.org/docs/ClangFormatStyleOptions.html for the style options and the comments described above.
| * Add a .clang-format configurationFederico Mena Quintero2022-12-061-0/+10
|/ | | | | | Stolen from glib. Most of at-spi2-core's code is in GNU coding style, or something close enough, mostly due to inconsistent indentation. We'll fix it.
* Merge branch 'registry-test-coverage' into 'main'Federico Mena Quintero2022-12-078-36/+60
|\ | | | | | | | | A little more test coverage for registry.c See merge request GNOME/at-spi2-core!118
| * Remove a couple of unused macrosFederico Mena Quintero2022-12-061-3/+0
| |
| * Remove unnecessary includesFederico Mena Quintero2022-12-061-2/+0
| |
| * Move X11-specific prototypes to deviceeventcontroller-x11.hFederico Mena Quintero2022-12-063-8/+8
| | | | | | | | This removes "HAVE_X11" from deviceeventcontroller.h
| * Remove superfluous includeFederico Mena Quintero2022-12-061-3/+0
| |
| * test_root.py: Test that querying for a property on an unknown interface ↵Federico Mena Quintero2022-12-061-0/+7
| | | | | | | | yields an error
| * Test the introspection of the registry objectFederico Mena Quintero2022-12-061-0/+7
| |
| * test_introspection.py: Factor out function to test a set of advertised ↵Federico Mena Quintero2022-12-061-6/+17
| | | | | | | | interfaces
| * Rename test_root_introspectable.py to test_introspection.pyFederico Mena Quintero2022-12-061-0/+0
| | | | | | | | Let's put all the DBus introspection tests in the same file.
| * tests/registryd: add a fixture to obtain the registry objectFederico Mena Quintero2022-12-061-0/+7
|/
* Merge branch 'remove-unused-methods' into 'main'Federico Mena Quintero2022-12-066-438/+36
|\ | | | | | | | | | | | | Remove unused DeviceEventController methods Closes #94 See merge request GNOME/at-spi2-core!116
| * SpiDEController: Remove the have_mouse_listener fieldFederico Mena Quintero2022-12-052-8/+5
| | | | | | | | | | | | It's never set, and always remained as FALSE. On the other hand, we lave have_mouse_event_listener, which *is* used.
| * append_mouse_listener(): Remove unused functionFederico Mena Quintero2022-12-051-18/+0
| |
| * notify_mouse_listener(): Remove unused functionFederico Mena Quintero2022-12-051-22/+0
| |
| * spi_controller_deregister_device_listener(): Remove unused functionFederico Mena Quintero2022-12-051-17/+0
| |
| * spi_remove_device_listeners(): Remove the part that dealt with mouse_listenersFederico Mena Quintero2022-12-051-10/+0
| | | | | | | | There are no mouse_listeners created anymore.
| * spi_listener_clone(): Remove unused functionFederico Mena Quintero2022-12-051-11/+0
| |
| * spi_listener_clone_free(): Remove unused functionFederico Mena Quintero2022-12-051-8/+0
| |
| * spi_dec_set_unlatch_pending(): Remove unused functionFederico Mena Quintero2022-12-051-11/+0
| |
| * Remove variable that is set but never usedFederico Mena Quintero2022-12-051-4/+0
| |
| * Remove the other is_consumedFederico Mena Quintero2022-12-051-8/+1
| | | | | | | | And simplify the call to XAllowEvents() since now there is only one case.
| * Remove one auxiliary is_consumedFederico Mena Quintero2022-12-051-9/+2
| | | | | | | | It was used for the return value of spi_controller_notify_mouselisteners.
| * Remove another auxiliary variable that was used to call ↵Federico Mena Quintero2022-12-051-11/+0
| | | | | | | | spi_controller_notify_mouselisteners
| * Remove one auxiliary variable that was used to call ↵Federico Mena Quintero2022-12-051-13/+0
| | | | | | | | spi_controller_notify_mouselisteners
| * spi_controller_notify_mouselisteners(): RemoveFederico Mena Quintero2022-12-053-72/+1
| | | | | | | | | | | | | | | | | | | | | | | | This function immediately returns FALSE if there are no controller->mouse_listeners. The only place that ever added to the controller->mouse_listeners list was spi_controller_register_device_listener(), which we removed in the last commit. So, remove the function altogether and make the two callers do as if it just returned FALSE.