summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Version 2.5.1v2.5.1Andreas Gruenbacher2021-03-169-9/+9
|
* Fix libtool library versioning regressionAndreas Gruenbacher2021-03-161-1/+6
| | | | | | | | | | | | LT_REVISION was computed from PACKAGE_VERSION by stripping the dots from PACKAGE_VERSION. This caused LT_REVISION to change from 2448 down to 250 when the version changed from 2.4.48 to 2.5.0. This broke ldconfig versioning and caused the library symlinks to break after a package update. https://bugzilla.redhat.com/1938459#c9 Reported by: Kamil Dudka <kdudka@redhat.com>
* Version 2.5.0v2.5.0Andreas Gruenbacher2021-03-111-1/+1
|
* Update po files and German translationAndreas Gruenbacher2021-03-119-936/+955
| | | | | Add a convenience rule for updating the po files to the main Makefile. Use that for updating the po files. Update the German translation.
* getfattr: Add --one-file-system optionAndreas Gruenbacher2021-03-113-0/+17
| | | | | Add a --one-filesystem option to getfattr. With this option, getfattr will not cross mount points, similar to "tar --one-file-system".
* Move struct stat into struct walk_tree_argsAndreas Gruenbacher2021-03-111-14/+14
|
* Move list of open directories into struct walk_tree_argsAndreas Gruenbacher2021-03-111-30/+29
|
* Move walk_tree_rec arguments into a separate structAndreas Gruenbacher2021-03-111-32/+49
|
* xattr.conf: Indicate afs metadata xattrs should be skipped when copyingDavid Howells2020-11-031-0/+1
| | | | | Indicate that afs metadata xattrs should be skipped when copying, particularly ACLs as these aren't valid cross-cell.
* Fix typos in manual pagesSamanta Navarro2020-10-082-2/+2
|
* Update my email addressAndreas Gruenbacher2020-02-067-7/+7
|
* man: add examples to setfattr.1Achilles Gaikwad2020-02-061-0/+12
| | | | | | | | The current man page for setfattr does not state that the user needs to add the prefix "user." With the help of examples we demonstrate that the user needs to add a namespace as prefix. Signed-off-by: Achilles Gaikwad <agaikwad@redhat.com>
* install-data: Don't remove unrelated empty directoriesAndreas Gruenbacher2019-08-161-2/+1
| | | | | | | The conversion to automake apparently left over an rmdir statement that removed empty directories under $(DESTDIR)$(mandir). Fix that. https://savannah.nongnu.org/bugs/?56763
* attr: Replace bzero with memsetRosen Penev2019-08-123-5/+5
| | | | | | | bzero is a deprecated function that is optionally unavailable with uClibc-ng. Signed-off-by: Rosen Penev <rosenp@gmail.com>
* getfattr: don't count terminating NULL in well_enough_printableJeff Layton2019-06-131-0/+4
| | | | | | | | | | If the value is a string with the terminating NUL included in the length, then don't count that terminating NUL when determining whether the string is printable. This is consistent with the fact that getfattr doesn't print the terminating NUL character in --encoding=text (commit 7fed4441e12d). Signed-off-by: Jeff Layton <jlayton@kernel.org>
* attr_list, attr_listf: Guard against unterminated bufferAndreas Gruenbacher2018-12-171-5/+7
| | | | | | attr_list and attr_listf can crash when the listxattr, llistxattr, or flistxattr syscalls incorrectly return an unterminated buffer. Guard against that by always appending a null character.
* attr_multi, attr_multif: Don't set errno to -EINVALAndreas Gruenbacher2018-12-171-2/+2
| | | | | | When attr_multi or attr_multif are called with an invalid am_opcode, they fail with errno set to -EINVAL. Instead, the errno value should be positive.
* Switch back to syscall()Andreas Gruenbacher2018-08-171-12/+14
| | | | | | | | | | | | | | | | | | | | | Switch back to syscall() for the *xattr system calls. The current mechanism of forwarding those calls to glibc breaks libraries like libfakeroot (fakeroot) and libasan (the gcc address sanitizer; gcc -fsanitize=address). Those libraries provide wrappers for functions defined in other shared libraries, usually glibc, do their own processing, and forward calls to the original symbols looke dup via dlsym(RTLD_NEXT, "symbol_name"). In our case, dlsym returns the libattr_*xattr wrappers. However, when our wrappers try calling glibc, they end up calling the libfakeroot / libasan wrappers instead because those override the original symbols => recursion. The libattr_*xattr wrappers will only be used when symbols are looked up at runtime (dlopen / dlsym). Programs linking against libattr will directly use the glibc provided symbols. Therefore, the slightly worse performance of syscall() won't affect any of the "normal" users of libattr.
* attr_list.3: Fix the attributes.h include pathAndreas Gruenbacher2018-07-031-1/+1
| | | | | The header file is located at <attr/attributes.h>. Make the attr_list.3 man page consistent with the other man pages.
* getfattr.1: by default only user namespace attributes are dumpedSimon Ruderich2018-01-211-3/+3
|
* Enable large-file support on systems that do not enable it by defaultDmitry V. Levin2018-01-212-0/+7
| | | | | | | | | | | | | | Invoke AC_SYS_LARGEFILE to enable large-file support. This fix doesn't change the library as much as the tools because the only affected function in libattr is attr_copy_action that calls attr_parse_attr_conf that in turn calls fopen(ATTR_CONF, "r"). What is the most affected is getfattr, without the fix it just cannot process large files, e.g. $ truncate -s2G large-file && getfattr large-file getfattr: large-file: Value too large for defined data type
* man: standardize AUTHORS sectionMike Frysinger2018-01-213-2/+18
| | | | Point people to the Savannah project now.
* man: fix bold style in SEE ALSO sectionMike Frysinger2018-01-218-21/+17
| | | | See STYLE GUIDE in man-pages(7) for more details.
* test: escape left brace in a regex in test/runTroy Dawson2018-01-211-1/+1
| | | | | | ... to fix test-suite failure with perl-5.26.0 Bug: https://bugzilla.redhat.com/1473853
* attr: Fix segmentation faultv2.4.48Andreas Gruenbacher2017-09-151-0/+4
| | | | | | | | | | | When the -V option is used without -s, attr will cause a segmentation fault instead of reporting an error: $ touch somefile $ attr -V whatever somefile Segmentation fault (core dumped) https://savannah.nongnu.org/bugs/?48244
* po: updateAndreas Gruenbacher2017-09-158-188/+196
| | | | Contains no translation changes.
* setfacl: Include errno.hAndreas Gruenbacher2016-12-111-1/+1
| | | | | | In file tools/setfattr.c:33:0, gcc -Wcpp complains that including <sys/errno.h> is incorrect and that <errno.h> should be included instead. Reported by Matias A. Fonzo <selk@dragora.org>.
* copy_action: drop unused alloca.h includeMike Frysinger2016-12-091-3/+0
| | | | This file doesn't use alloca(), so no point in including the header.
* include: add uninstall target to fix distcheckMike Frysinger2016-12-091-0/+5
| | | | | | | Commit 315af30d0c1a198dc662a90e6e6ae2456abf2489 (Cleanup visibility of API functions) changed to generating headers into the install path. This means automake itself would no longer take care of uninstalling the headers for us. Add a local hook for that to fix distcheck.
* attr_copy_{fd,file}: sync changes between the filesMike Frysinger2016-12-092-18/+18
| | | | | | | | These two files are largely copies of each other but using diff APIs. Sync the minor differences between them to make `diff` more obvious. This also fixes a bug in an error message in attr_copy_fd where it had swapped the attribute name and the path.
* xattr.conf: do not copy security.evmStefan Berger2016-12-091-0/+1
| | | | | | | The security.evm extended attribute may only be written by the Linux kernel. So modify xattr.conf to always skip this extended attribute. Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
* Cleanup visibility of API functionsYury Usishchev2016-03-026-18/+84
| | | | | | | Import visibility_hidden.m4 macro from acl and use it in configure.ac This will enable -fvisibility CFLAG when supported by compiler. Mark API functions with default visibility attribute.
* Cleanup config.h usageYury Usishchev2016-03-0211-2/+22
| | | | Add config.h include to every source file before all other includes.
* Use stdint types consistentlyFelix Janda2016-01-132-6/+8
|
* walk_tree_rec: Add parentheses to clarify codeAndreas Gruenbacher2015-12-261-2/+2
| | | | | | Make the conditional easier to read. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
* Reintroduce symbols that used to be syscall wrappersDmitry V. Levin2015-09-223-1/+106
| | | | | | | | | Commit 7921157890d07858d092f4003ca4c6bae9fd2c38 removed symbols that were part of ABI. Reintroduce these symbols to fix the ABI breakage. These backward compatibility symbols just use appropriate xattr syscall wrappers provided by libc.
* Do not export symbols that are not supposed to be exportedDmitry V. Levin2015-09-221-0/+3
| | | | | As all symbols that are part of public interface are explicitly exported with corresponding versioning, mark all remaining symbols as local.
* Add explicit symbol versioning for attr_copy_actionDmitry V. Levin2015-09-221-0/+5
| | | | | As all symbols that are part of public interface are expected to be properly versioned, add versioning to attr_copy_action.
* ignore configure.linenoMike Frysinger2015-09-211-0/+1
| | | | Newer autoconf sometimes generates this file.
* walk_tree: mark internal variables as staticDmitry V. Levin2015-09-211-3/+3
| | | | walk_tree.c internal variables should not be exposed to libmisc users.
* Remove the attr.5 man page (moved to man-pages)Andreas Gruenbacher2015-05-073-156/+0
| | | | | | The attr.5 page is part of the extended attribute system call documentation, which has been moved into the man-pages package. Move the attr.5 page there as well.
* Remove <attr/xattr.h> and the syscall wrappersAndreas Gruenbacher2015-04-1511-198/+16
| | | | | | The xattr syscalls are provided by glibc since ages, so there is no need to use the indirect system call "syscall" anymore. This removes the need for the <attr/xattr.h> header; use <sys/xattr.h> instead.
* Remove the section 2 man pagesAndreas Gruenbacher2015-04-157-568/+0
| | | | | | The section 2 man pages have long since been added to the man-pages package which documents all system calls; they were disabled in attr by default since January 2014. Get rid of them here.
* Remove outdated tests from test/attr.testAndreas Gruenbacher2015-03-031-4/+0
| | | | | | Extended attributes are not accounted for in the real file size on most file systems, not even in ext* file systems with large inodes. Remove the associated tests.
* Remove test/ext/fs.testAndreas Gruenbacher2015-03-032-72/+1
| | | | | These tests don't do anything useful anymore on most ext4 file systemms, so remove it.
* Add setfattr --raw optionAndreas Gruenbacher2015-02-202-1/+13
| | | | | | With this option, attribute values are taken as they are, without traing to decode them. This can be thought of as the counterpart to "getfattr --only-values".
* Properly set and report empty attribute valuesAndreas Gruenbacher2015-02-203-9/+21
| | | | | | | Change getfattr to print empty attribute values as "" (including the quotes), 0x, or 0s, depending on the encoding chosen. Fix setfattr to set empty attribute values when the value specified is an empty string; before, an encoded empty value like "" (including the quotes) had to be specified.
* Man pages: Minor fixesAndreas Gruenbacher2015-02-202-2/+2
| | | | Two small wording fixes.
* build: unbreak attr_copy_fd() and attr_copy_file().Nick Alcock2014-10-206-9/+14
| | | | | | | | | | | | | | | Mike's build-system-revamping commit 9ce21bd of January this year accidentally dropped a crucial -include of "libattr.h". This silently undefined the HAVE_F*ATTR macros, causing attr_copy_{fd,file}.c to think that xattrs are not supported and to compile the functions in those files into a 'return 0;' stub. The code in these files uses the NLS _() macro, which was recently moved into misc.h, which can only sensibly be included by things outside libattr. So migrate the NLS macros into a new nls.h at the same time, and include it from misc.h. With these fixes in place, xattrs can be copied again.
* attr: Don't report a NULL attribute name when -l (list) failsAndreas Gruenbacher2014-07-081-2/+2
|