| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
LT_REVISION was computed from PACKAGE_VERSION by stripping the dots from
PACKAGE_VERSION. This caused LT_REVISION to change from 2448 down to
250 when the version changed from 2.4.48 to 2.5.0. This broke ldconfig
versioning and caused the library symlinks to break after a package
update.
https://bugzilla.redhat.com/1938459#c9
Reported by: Kamil Dudka <kdudka@redhat.com>
|
| |
|
|
|
|
|
| |
Add a convenience rule for updating the po files to the main Makefile. Use
that for updating the po files. Update the German translation.
|
|
|
|
|
| |
Add a --one-filesystem option to getfattr. With this option, getfattr
will not cross mount points, similar to "tar --one-file-system".
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Indicate that afs metadata xattrs should be skipped when copying,
particularly ACLs as these aren't valid cross-cell.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
The current man page for setfattr does not state that the user needs to
add the prefix "user." With the help of examples we demonstrate that the
user needs to add a namespace as prefix.
Signed-off-by: Achilles Gaikwad <agaikwad@redhat.com>
|
|
|
|
|
|
|
| |
The conversion to automake apparently left over an rmdir statement that
removed empty directories under $(DESTDIR)$(mandir). Fix that.
https://savannah.nongnu.org/bugs/?56763
|
|
|
|
|
|
|
| |
bzero is a deprecated function that is optionally unavailable with
uClibc-ng.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
|
|
|
|
|
|
|
|
|
| |
If the value is a string with the terminating NUL included in the
length, then don't count that terminating NUL when determining whether
the string is printable. This is consistent with the fact that getfattr
doesn't print the terminating NUL character in --encoding=text (commit
7fed4441e12d).
Signed-off-by: Jeff Layton <jlayton@kernel.org>
|
|
|
|
|
|
| |
attr_list and attr_listf can crash when the listxattr, llistxattr, or
flistxattr syscalls incorrectly return an unterminated buffer. Guard
against that by always appending a null character.
|
|
|
|
|
|
| |
When attr_multi or attr_multif are called with an invalid am_opcode,
they fail with errno set to -EINVAL. Instead, the errno value should be
positive.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch back to syscall() for the *xattr system calls. The current
mechanism of forwarding those calls to glibc breaks libraries like
libfakeroot (fakeroot) and libasan (the gcc address sanitizer; gcc
-fsanitize=address).
Those libraries provide wrappers for functions defined in other shared
libraries, usually glibc, do their own processing, and forward calls to
the original symbols looke dup via dlsym(RTLD_NEXT, "symbol_name"). In
our case, dlsym returns the libattr_*xattr wrappers. However, when our
wrappers try calling glibc, they end up calling the libfakeroot /
libasan wrappers instead because those override the original symbols =>
recursion.
The libattr_*xattr wrappers will only be used when symbols are looked up
at runtime (dlopen / dlsym). Programs linking against libattr will
directly use the glibc provided symbols. Therefore, the slightly worse
performance of syscall() won't affect any of the "normal" users of
libattr.
|
|
|
|
|
| |
The header file is located at <attr/attributes.h>. Make the attr_list.3
man page consistent with the other man pages.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Invoke AC_SYS_LARGEFILE to enable large-file support.
This fix doesn't change the library as much as the tools because
the only affected function in libattr is attr_copy_action that calls
attr_parse_attr_conf that in turn calls fopen(ATTR_CONF, "r").
What is the most affected is getfattr, without the fix it just cannot
process large files, e.g.
$ truncate -s2G large-file && getfattr large-file
getfattr: large-file: Value too large for defined data type
|
|
|
|
| |
Point people to the Savannah project now.
|
|
|
|
| |
See STYLE GUIDE in man-pages(7) for more details.
|
|
|
|
|
|
| |
... to fix test-suite failure with perl-5.26.0
Bug: https://bugzilla.redhat.com/1473853
|
|
|
|
|
|
|
|
|
|
|
| |
When the -V option is used without -s, attr will cause a segmentation
fault instead of reporting an error:
$ touch somefile
$ attr -V whatever somefile
Segmentation fault (core dumped)
https://savannah.nongnu.org/bugs/?48244
|
|
|
|
| |
Contains no translation changes.
|
|
|
|
|
|
| |
In file tools/setfattr.c:33:0, gcc -Wcpp complains that including
<sys/errno.h> is incorrect and that <errno.h> should be included
instead. Reported by Matias A. Fonzo <selk@dragora.org>.
|
|
|
|
| |
This file doesn't use alloca(), so no point in including the header.
|
|
|
|
|
|
|
| |
Commit 315af30d0c1a198dc662a90e6e6ae2456abf2489 (Cleanup visibility of
API functions) changed to generating headers into the install path.
This means automake itself would no longer take care of uninstalling
the headers for us. Add a local hook for that to fix distcheck.
|
|
|
|
|
|
|
|
| |
These two files are largely copies of each other but using diff APIs.
Sync the minor differences between them to make `diff` more obvious.
This also fixes a bug in an error message in attr_copy_fd where it
had swapped the attribute name and the path.
|
|
|
|
|
|
|
| |
The security.evm extended attribute may only be written by the Linux
kernel. So modify xattr.conf to always skip this extended attribute.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
|
|
|
|
|
|
|
| |
Import visibility_hidden.m4 macro from acl and use it in configure.ac
This will enable -fvisibility CFLAG when supported by compiler.
Mark API functions with default visibility attribute.
|
|
|
|
| |
Add config.h include to every source file before all other includes.
|
| |
|
|
|
|
|
|
| |
Make the conditional easier to read.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Commit 7921157890d07858d092f4003ca4c6bae9fd2c38 removed
symbols that were part of ABI.
Reintroduce these symbols to fix the ABI breakage.
These backward compatibility symbols just use appropriate
xattr syscall wrappers provided by libc.
|
|
|
|
|
| |
As all symbols that are part of public interface are explicitly exported
with corresponding versioning, mark all remaining symbols as local.
|
|
|
|
|
| |
As all symbols that are part of public interface are expected
to be properly versioned, add versioning to attr_copy_action.
|
|
|
|
| |
Newer autoconf sometimes generates this file.
|
|
|
|
| |
walk_tree.c internal variables should not be exposed to libmisc users.
|
|
|
|
|
|
| |
The attr.5 page is part of the extended attribute system call documentation,
which has been moved into the man-pages package. Move the attr.5 page there
as well.
|
|
|
|
|
|
| |
The xattr syscalls are provided by glibc since ages, so there is no need to use
the indirect system call "syscall" anymore. This removes the need for the
<attr/xattr.h> header; use <sys/xattr.h> instead.
|
|
|
|
|
|
| |
The section 2 man pages have long since been added to the man-pages package
which documents all system calls; they were disabled in attr by default since
January 2014. Get rid of them here.
|
|
|
|
|
|
| |
Extended attributes are not accounted for in the real file size on most file
systems, not even in ext* file systems with large inodes. Remove the
associated tests.
|
|
|
|
|
| |
These tests don't do anything useful anymore on most ext4 file systemms, so
remove it.
|
|
|
|
|
|
| |
With this option, attribute values are taken as they are, without traing to
decode them. This can be thought of as the counterpart to "getfattr
--only-values".
|
|
|
|
|
|
|
| |
Change getfattr to print empty attribute values as "" (including the quotes),
0x, or 0s, depending on the encoding chosen. Fix setfattr to set empty
attribute values when the value specified is an empty string; before, an
encoded empty value like "" (including the quotes) had to be specified.
|
|
|
|
| |
Two small wording fixes.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mike's build-system-revamping commit 9ce21bd of January this year
accidentally dropped a crucial -include of "libattr.h". This silently
undefined the HAVE_F*ATTR macros, causing attr_copy_{fd,file}.c to think
that xattrs are not supported and to compile the functions in those
files into a 'return 0;' stub.
The code in these files uses the NLS _() macro, which was recently moved
into misc.h, which can only sensibly be included by things outside
libattr. So migrate the NLS macros into a new nls.h at the same time,
and include it from misc.h.
With these fixes in place, xattrs can be copied again.
|
| |
|