diff options
| author | Stefano Lattarini <stefano.lattarini@gmail.com> | 2012-06-28 17:08:34 +0200 |
|---|---|---|
| committer | Stefano Lattarini <stefano.lattarini@gmail.com> | 2012-06-28 17:08:34 +0200 |
| commit | de20404a6d15db5d913de632e2099b864a373546 (patch) | |
| tree | f9e8d56bb19b301a66b491e0b6ec314bb86e9ad8 | |
| parent | 9c906bc7a82aa0cc914c724a7f7fc3518036913c (diff) | |
| download | automake-de20404a6d15db5d913de632e2099b864a373546.tar.gz | |
tests: don't skip if $(abs_builddir) or $(abs_srcdir) contain whitespace
We used to explicitly skip libtool and gettext tests if the absolute
path of the builddir or of the srcdir which Automake was configured
with contained any whitespace (or other metacharacters).
But several other tests would spuriously fail in such an unholy setup.
To be precise, it would cause 61 'FAIL's and 42 'ERROR's in the whole
Automake testsuite.
The fact that, as of today, nobody has reported any failure of this kind
means that (thankfully) nobody is building automake with $(abs_srcdir)
or $(abs_builddir) mangled by whitespace. So, instead of trying to cater
to such a broken setup consistently, we just drop the extra check in the
libtool/gettext tests.
In case someone will ever reports a failure due to extra whitespace in
either $(abs_srcdir) or or $(abs_builddir), we will simply enhance our
'configure.ac' to bail out flatly and loudly at such a setup.
* t/ax/test-init.sh: Simplify accordingly.
Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| -rw-r--r-- | t/ax/test-init.sh | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/t/ax/test-init.sh b/t/ax/test-init.sh index dce60e9fa..a414e1459 100644 --- a/t/ax/test-init.sh +++ b/t/ax/test-init.sh @@ -915,31 +915,6 @@ do esac done -# Using just $am_top_builddir for the check here is ok, since the -# further temporary subdirectory where the test will be run is -# ensured not to contain any whitespace character. -case $am_top_builddir in - *\ *|*\ *) - case " $required " in - *' libtool '* | *' libtoolize '* ) - skip_all_ "libtool has problems with spaces in builddir name";; - esac - ;; -esac - -# This test is necessary, although Automake's configure script bails out -# when $srcdir contains spaces. This is because $am_top_srcdir is in not -# configure-time $srcdir, but is instead configure-time $abs_srcdir, and -# that is allowed to contain spaces. -case $am_top_srcdir in - *\ * |*\ *) - case " $required " in - *' libtool '* | *' libtoolize '* | *' gettext '* ) - skip_all_ "spaces in srcdir name: libtool/gettext tests won't work";; - esac - ;; -esac - # We might need extra macros, e.g., from Libtool or Gettext. case " $required " in *\ libtool*) . ./t/libtool-macros.dir/get.sh;; esac case " $required " in *\ gettext*) . ./t/gettext-macros.dir/get.sh;; esac |