diff options
| author | Stefano Lattarini <stefano.lattarini@gmail.com> | 2013-05-23 20:49:39 +0200 |
|---|---|---|
| committer | Stefano Lattarini <stefano.lattarini@gmail.com> | 2013-05-23 20:49:39 +0200 |
| commit | a0db09fe9eb8b03415a5dd00ff031f5a17096108 (patch) | |
| tree | f0db7b94a5b1022318dcd8caefb8fad5d54869cf /maintainer | |
| parent | 439ca6b342e56ab75c3e26866ed05b6b9850ac19 (diff) | |
| parent | aba3b0abf71bcd600fcb142b307b9c6955205298 (diff) | |
| download | automake-a0db09fe9eb8b03415a5dd00ff031f5a17096108.tar.gz | |
Merge branch 'maint'
* maint:
tests: avoid few lingering $MAKE redirections
tests: avoid '$MAKE' redirections, use 'run_make' instead
tests: avoid use of redirected 'run_make' invocations
lint: warn against redirected 'run_make' invocations
comments: next GNU make release 4.0, not 3.83
tests: fix a potential spurious failure due to global config.site
HACKING: it's OK to do testsuite refactoring in a micro version
Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Diffstat (limited to 'maintainer')
| -rw-r--r-- | maintainer/syntax-checks.mk | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/maintainer/syntax-checks.mk b/maintainer/syntax-checks.mk index fefbcc7e2..9191757a1 100644 --- a/maintainer/syntax-checks.mk +++ b/maintainer/syntax-checks.mk @@ -62,6 +62,7 @@ sc_tests_no_source_defs \ sc_tests_obsolete_variables \ sc_tests_here_document_format \ sc_tests_command_subst \ +sc_tests_no_run_make_redirect \ sc_tests_exit_not_Exit \ sc_tests_automake_fails \ sc_tests_required_after_defs \ @@ -346,6 +347,16 @@ sc_tests_no_source_defs: exit 1; \ fi +## Invocation of 'run_make' should not have output redirections. +sc_tests_no_run_make_redirect: + @if grep -Pzo '.*(\$$MAKE|\brun_make)\b(.*(\\\n))*.*>.*' $(xtests); \ + then \ + echo 'Do not redirect stdout/stderr in "run_make" or "$$MAKE"' \ + 'invocations,' >&2; \ + echo 'use "run_make {-E|-O|-M}" instead.' >&2; \ + exit 1; \ + fi + ## Use AUTOMAKE_fails when appropriate sc_tests_automake_fails: @if grep -v '^#' $(xtests) | grep '\$$AUTOMAKE.*&&.*exit'; then \ |