diff options
author | Stefano Lattarini <stefano.lattarini@gmail.com> | 2012-06-14 13:13:58 +0200 |
---|---|---|
committer | Stefano Lattarini <stefano.lattarini@gmail.com> | 2012-06-22 14:24:38 +0200 |
commit | 6e713425a0dcede167924e7691e95ab5e54e399c (patch) | |
tree | 4ce8cbe368733dc0049b5b690b13e0e3123d7a3a /t/tap-no-spurious.sh | |
parent | d0dc448517d3a61ba55e62dd76b9a42b68bef8f8 (diff) | |
download | automake-6e713425a0dcede167924e7691e95ab5e54e399c.tar.gz |
tests: use more POSIX shell features our test scripts
Since commit 'v1.12-36-g2d68fd9' of 2012-05-07, "configure: search a
sturdy POSIX shell to be used in the testsuite", the shell running
our test script is assured to be a POSIX-conforming shell, so we can
use the more modern and flexible idioms and features that we couldn't
use when we also aimed at compatibility with non-POSIX Bourne shells,
like Solaris /bin/sh.
* t/README: Suggest to use POSIX shell features liberally in test cases,
with possible exception of Makefile recipes and configure shell code.
* Several tests: Adjust to use more POSIX shell features; e.g., $(...)
rather than `...`, $((...)) rather than `expr ...`, "if ! CMD; then ..."
instead of "if CMD; then :; else ...", and so on.
In several places, when using the 'test' built-in, prefer '-eq' over
'=' for numeric comparisons, and prefer "grep -c PATTERN FILE" over
"grep PATTERN FILE | wc -l".
Throw in other low-hanging easy improvements and fixlets while we are
at it.
* t/ax/depcomp.sh, t/ax/tap-summary-aux.sh, t/ax/tap-functions.sh,
defs, defs-static.in: Likewise.
Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Diffstat (limited to 't/tap-no-spurious.sh')
-rwxr-xr-x | t/tap-no-spurious.sh | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/t/tap-no-spurious.sh b/t/tap-no-spurious.sh index b9bca21fb..ea2993d43 100755 --- a/t/tap-no-spurious.sh +++ b/t/tap-no-spurious.sh @@ -36,9 +36,9 @@ END # According to documentation of Test::Harness::TAP(3): # -# ``Lines written to standard output matching /^(not )?ok\b/ +# Lines written to standard output matching /^(not )?ok\b/ # must be interpreted as test lines. All other lines must -# not be considered test output.'' +# not be considered test output. cat >> all.test <<END ok @@ -98,11 +98,11 @@ Bail out # Bail out! END -cat all.test # For debugging. -# Minor sanity check. -test `grep -c '^ok1$' all.test` -eq 1 \ - && test `grep -c '^not ok1$' all.test` -eq 1 \ +# Debugging info and minor sanity check. +cat all.test \ + && test $(grep -c '^ok1$' all.test) -eq 1 \ + && test $(grep -c '^not ok1$' all.test) -eq 1 \ || framework_failure_ "creating all.test" $MAKE check >stdout || { cat stdout; Exit 1; } |