Use `Exit' instead of `exit' in test suite.

Cater to Bourne shells like Solaris sh that do not pass the
`exit' argument as status to the cleanup trap.
* Makefile.am (maintainer-check): Check that here-documents
use only `END' or `EOF' as delimiter in the test suite.
Check that, outside of here-documents, the tests do not use
`exit' with an argument, but use `Exit' instead.
* tests/defs.in (Exit): New function.  Use it throughout,
starting with the introduction of the exit trap.
* tests/*.test: Use `Exit $arg' instead of `exit $arg'
throughout, except inside created files.

Signed-off-by: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>

1 files changed, 5 insertions, 5 deletions

diff --git a/tests/fnoc.test b/tests/fnoc.test
index 8186cc85c..f791fa075 100755
--- a/tests/fnoc.test
+++ b/tests/fnoc.test
@@ -18,7 +18,7 @@
 # C-specific code.
 # Matthew D. Langston <langston@SLAC.Stanford.EDU>
 
-. ./defs || exit 1
+. ./defs || Exit 1
 
 cat >> configure.in << 'END'
 AC_PROG_F77
@@ -32,8 +32,8 @@ END
 : > doe.f
 : > jane.f
 
-$ACLOCAL || exit 1
-$AUTOMAKE || exit 1
+$ACLOCAL || Exit 1
+$AUTOMAKE || Exit 1
 
-grep '[^F]CC' Makefile.in | grep -v MKDEP && exit 1
-exit 0
+grep '[^F]CC' Makefile.in | grep -v MKDEP && Exit 1
+Exit 0