summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | tests: refactor some tests on DIST_COMMONStefano Lattarini2014-12-226-111/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | So that they prefer checking the semantics of the generated Makefiles, rather than grepping their content. This will be useful in an upcoming refactoring. * t/distcom-subdir.sh: Adjust this test. * t/distcom2.sh: And this. * t/distcom3.sh: And this. * t/distcom4.sh: And this. * t/distcom5.sh: And this. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | maint: make output of 'gen-testsuite-part' deterministicStefano Lattarini2014-12-221-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | So that diffs displayed by the 'compare-autodiffs' target are less spurious and more useful. * gen-testsuite-part: Sort keys of %deps_extractor, %wrapper_setups and %depmodes before iterating on them. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | When computing lispdir, don't load emacs site wide init file.Andrew Burgess2014-12-192-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When computing the lispdir emacs was previously invoked with the '-q' option to avoid loading the users initialisation files, however, the site wide initialisation file was still loaded, in some cases this can cause emacs to hang, with the result that a configure can also hang. The lisp code that aclocal causes to be executed reduces the load-path list (in emacs) to empty. The load-path is used by emacs to find packages which it wants to load. Currently, if emacs tries to auto load a package during shut down, and the package is not found, then emacs will hang. This does seem like an emacs bug, but protecting against this in aclocal is simply a case of not loading the site wide initialisation file. In this patch then the '-q' option to emacs is replaced with '-Q', this has the same, the '-Q' option is similar to '-q --no-site-file --no-splash'. * doc/automake.texi (Hard-Coded Install Paths): Update explanation of emacs code used to get lispdir. * m4/lispdir.m4 (AM_PATH_LISPDIR): Update emacs flags. Copyright-paperwork-exempt: yes Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | PATH: quote $(PATH_SEPARATOR) as wellKO Myung-Hun2014-12-192-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On OS/2, $(PATH_SEPARATOR) is ';'. Without quote, it is recognized as a mark of end of sentence. * Makefile.am: quote $(PATH_SEPARATOR) as well. * t/Makefile.inc: Likewise. Copyright-paperwork-exempt: yes Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | Improve detection of GNU make, avoiding "Arg list too long" errors.Stefano Lattarini2014-12-192-4/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Such errors could take place when the main makefile included too many sub-makefiles, making $(MAKEFILE_LIST) too long and causing the recipes $(am__is_gnu_make) to exceed the shell's command-line length limits. This is not a theoretical issue: it could happen for projects having lots of C/C++ sources and using automatic dependency tracking, which created an included .Po sub-makefile for each of such sources. Fixes http://debbugs.gnu.org/18744 * lib/am/header-vars.am (am__is_gnu_make): Fix the logic to avoid the use of $(MAKEFILE_LIST). * NEWS: Update. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * Merge branch 'micro' into minorStefano Lattarini2014-12-190-0/+0
| | |\ | |_|/ |/| | | | | | | | * micro: Fix stupid typo in test, causing spurious failure
* | | Fix stupid typo in test, causing spurious failureStefano Lattarini2014-12-191-1/+1
| | | | | | | | | | | | | | | | | | * t/aminit-trailing-dnl-comment-pr16841.sh: s/greop/grep/ Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * Merge branch 'micro' into minorStefano Lattarini2014-12-199-22/+110
| | |\ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | * micro: sync: update third-part files from upstream Make sure AM_INIT_AUTOMAKE has a trailing newline dist: adjust warning messages about shar and tarZ deprecation docs: improve description of ${PACKAGE}, ${VERSION}, and similar variables Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | Merge branch 'pr16841' into microStefano Lattarini2014-12-195-1/+60
|\ \ \ | | | | | | | | | | | | | | | | * pr16841: Make sure AM_INIT_AUTOMAKE has a trailing newline
| * | | Make sure AM_INIT_AUTOMAKE has a trailing newlineStefano Lattarini2014-12-195-1/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This used to be the case until Automke 1.13, but we broke it in Automake 1.14 (see commit v1.13.1-71-gf78b0f0). This caused issues like http://debbugs.gnu.org/16841 * m4/init.m4 (AM_INIT_AUTOMAKE): Adjust. * t/aminit-trailing-dnl-comment-pr16841.sh: New test. * t/list-of-tests.mk: Add it. * NEWS, THANKS: Update. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | | sync: update third-part files from upstreamStefano Lattarini2014-12-195-175/+47
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | * lib/config.guess: This. * lib/config.sub: And this. * lib/gitlog-to-changelog: And this. * lib/gnupload: And this. * lib/update-copyright: And this. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | |
| \ \
*-. \ \ Merge branches 'dist-warn-pr19108' and 'docs-pr16623' into microStefano Lattarini2014-12-193-14/+26
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * dist-warn-pr19108: dist: adjust warning messages about shar and tarZ deprecation * docs-pr16623: docs: improve description of ${PACKAGE}, ${VERSION}, and similar variables
| | * | | docs: improve description of ${PACKAGE}, ${VERSION}, and similar variablesStefano Lattarini2014-12-182-10/+22
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In particular, suggesting that $PACKAGE and $VERSION should be aliases of the $PACKAGE_TARNAME and $PACKAGE_VERSION definitions coming from AC_INIT, and not be defined via an obsolete 2-argument invocation of AM_INIT_AUTOMAKE; and why that is the best default, given all our historical baggage. See discussion in http://debbugs.gnu.org/16623 for more information and background. * doc/automake.texi: Adjust. * THANKS: Update. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| * | | dist: adjust warning messages about shar and tarZ deprecationAharon Robbins2014-12-191-4/+4
|/ / / | | | | | | | | | | | | | | | They were swapped. Reported in http://debbugs.gnu.org/19108. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * Fix dumb logic error preventing $install_sh from being be overriddenThomas Jahns2014-12-172-1/+2
| | | | | | | | | | | | | | | | | | | | | * m4/install-sh.m4: Here. * THANKS: Update. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | *-. Merge branches 'pr19311' and 'micro' into minorStefano Lattarini2014-12-174-15/+62
| | |\ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * pr19311: Expose automake bug#19311 build: fix race in parallel builds * micro: Automake docs: fix typos and use of British English build: fix race in parallel builds
* | | | Automake docs: fix typos and use of British EnglishKarl Berry2014-12-171-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | * doc/automake.texi: Here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | | build: fix race in parallel buildsPaul Eggert2014-08-231-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | Reported by Friedrich Beckmann in: http://bugs.gnu.org/18301 * lib/am/texi-vers.am (?DIRSTAMP?): Put the process-ID into the temporary file name. Use a similar temporary in the source dir.
| | | * Expose automake bug#19311Stefano Lattarini2014-12-172-0/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | AC_PROG_CC called before AC_CONFIG_AUX_DIR can silently force wrong $ac_aux_dir definition. * t/auxdir-pr19311.sh: New. * t/list-of-tests.mk: Add it as an XFAIL test. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | | * build: fix race in parallel buildsPaul Eggert2014-12-171-9/+9
| | |/ | | | | | | | | | | | | | | | Reported by Friedrich Beckmann in: http://bugs.gnu.org/18301 * lib/am/texi-vers.am (?DIRSTAMP?): Put the process-ID into the temporary file name. Use a similar temporary in the source dir.
| | * init: ensure $ac_aux_dir is defined before being usedStefano Lattarini2014-04-227-6/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we use '$ac_aux_dir' to define '$am_aux_dir', we need to ensure the former has been initialized before we try to define the latter, otherwise the definition: am_aux_dir=`cd $ac_aux_dir && pwd` will set '$am_aux_dir' to '$HOME', likely causing weird and unexpected behaviours. This change fixes automake bug#15981. * m4/auxdir.m4 (AM_AUX_DIR_EXPAND): AC_REQUIRE expansion of 'AC_CONFIG_AUX_DIR_DEFAULT'. Fix redundant comment and AC_PREREQ, add extra quoting around '$ac_aux_dir'. * t/auxdir-pr15981.sh: New test. * t/auxdir-cc-pr15981.sh: Likewise. * t/list-of-tests.mk (handwritten_TESTS): Add them. * THANKS, NEWS: Update. * bin/automake.in: Fix a harmless typo in comments, that I happened to notice while writing this patch. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * plans: enabling subdir-object by default is blocked on bug#13928Stefano Lattarini2014-04-211-0/+9
| | | | | | | | | | | | Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * maint: update copyright yearsStefano Lattarini2014-04-211429-1431/+1431
| | | | | | | | | | | | | | | | | | We've been in 2014 already for few months now... Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * maint: sync files from upstream ("make fetch")Stefano Lattarini2014-04-215-168/+17
| | | | | | | | | | | | Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * Typofixes in warning messages and manualStefano Lattarini2014-04-214-5/+9
| | | | | | | | | | | | | | | | | | Fixes automake bug#16827 and bug#16997. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * Merge branch 'micro' into minorStefano Lattarini2014-04-211-0/+2
| | |\ | |_|/ |/| | | | | | | | * micro: doc: fix encoding error with UTF-8 characters
* | | doc: fix encoding error with UTF-8 charactersPaul Eggert2014-01-041-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | * doc/automake.texi: Specify @documentencoding and @documentlanguage, to prevent encoding errors for parts of this input file that are UTF-8. This also causes the .info output to use curly quotes, which is easier to read though it does assume UTF-8 support.
| | * NEWS: a typofix, and better word wrappingStefano Lattarini2013-12-311-3/+3
| | | | | | | | | | | | Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * parallel-tests: avoid possible implicit "make all" in test-suite.log ruleStefano Lattarini2013-12-302-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change fixes automake bug#16302. * lib/am/check.am ($(TEST_SUITE_LOG)): Avoid running "make $redo_logs" when $redo_logs expands to empty, since in that case we are actually ending up invoking a full "make all". That shouldn't be required, and can cause slowdowns for people implementing their extra "laziness wrappers" around check-TESTS (automake bug#16302). * NEWS: Update. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * Allow user to extend .PRECIOUS targetStefano Lattarini2013-12-267-3/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | References: <http://lists.freedesktop.org/archives/systemd-devel/2013-July/012155.html> <http://lists.gnu.org/archive/html/automake/2013-07/msg00011.html> * bin/automake.in: Adjust to ensure we handle '.PRECIOUS' the same way we do for '.PHONY' and '.MAKE'. * lib/Automake/Rule.pm: Likewise. * t/precious.sh: New test. * t/list-of-tests.mk: Add it. * t/phony.sh: Enhance a little while at it. * NEWS: Update. * THANKS: Likewise. Reported-by: Holger Hans Peter Freyther <holger@freyther.de> Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * cosmetics: remove a couple of extra trailing white spacesStefano Lattarini2013-12-262-2/+2
| | | | | | | | | | | | Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * tests: fix a spurious failure on Mac OS XStefano Lattarini2013-12-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | This change fixes bug#14706. * lib/depcomp2.sh: Also cater to spurious diagnostic from GNU rm, not only from Apple's rm. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * docs: make clear the JAVA primary is frozenStefano Lattarini2013-12-261-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | * doc/automake.texi: Here. The JAVA primary is broken in several ways, and will no longer be developed, not even for bug fixes. See also automake bugs #9088, #8662 and #8540. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * Merge branch 'install-sh-improvements' into minorStefano Lattarini2013-12-264-31/+94
| | |\ | | | | | | | | | | | | | | | | | | | | * install-sh-improvements: install-sh: a slightly better diagnostic, and tests enhancements install-sh: be stricter in catching invalid usages
| | | * install-sh: a slightly better diagnostic, and tests enhancementsStefano Lattarini2013-12-262-21/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * lib/install-sh: When called with no non-option arguments and the '-t' option with an argument that is not an existing directory, have the diagnostic output complain about the lack of required arguments rather than about the bad argument passed to '-t'. * t/install-sh-unittests.sh: Enhance to also check diagnostic printed in cases of expected failure. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | | * install-sh: be stricter in catching invalid usagesStefano Lattarini2013-12-264-25/+74
| | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Such usages (which are rejected by GNU install as well) are: - options -d and -t used together; - argument passed to option -t must be a directory; - if there are two or more SOURCEFILE arguments, the DESTINATION argument must be a directory. Note that we still allow the use of options -d and -T together, by making -d take the precedence; this is for compatibility with GNU install. This change fixes, among other things, automake bug#15376. * lib/install-sh: Adjust. * t/install-sh-unittests.sh: Enhance. * NEWS: Update. * THANKS: Add reporter of bug#15376. Helped-by: Tobias Hansen <thansen@debian.org> Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * tests: more significant names for some testsStefano Lattarini2013-12-255-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * t/insh2.sh: Rename... * t/dist-install-sh.sh: ... like this. * t/instsh.sh: Rename... * t/add-missing-install-sh.sh: ... like this. * t/instsh2.sh: Rename... * t/install-sh-unittests.sh: ... like this. * t/instsh3.sh: Rename... * t/install-sh-option-C.sh: ... like this. * t/list-of-tests.mk: Adjust. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * tests: some cosmetic fixesStefano Lattarini2013-12-254-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | * t/instdat.sh: Here. * t/instdat2.sh: And here. * t/instsh.sh: And here. * t/instsh3.sh: And here. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * tests: more significant names for a testStefano Lattarini2013-12-252-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | * t/install2.sh: Rename... * t/dist-with-unreadable-makefile-fails.sh: ... like this. * t/list-of-tests.mk: Adjust. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | *-. Merge branches 'fix-pr11814' and 'drop-perl-tap-driver' into minorStefano Lattarini2013-12-2516-148/+132
| | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * fix-pr11814: docs: drop a few obsolescent FIXME/TODO comments, and associated text testsuite harness: report test exit status in log file * drop-perl-tap-driver: TAP driver: remove perl implementation (move it into contrib/) Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | | | * TAP driver: remove perl implementation (move it into contrib/)Stefano Lattarini2013-12-2412-124/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | That implementation was only meant as a standard against which the portable awk+shell implementation was to be measured. Now, since Automake 1.12, the latter implementation is fully functional and already used in the wild, and in fact feature-par with the perl implementation. So the perl implementation is now just slowing down and complicating our testsuite. Let's move it to 'contrib/' (we don't want to remove it, in case someone is actually using it in the wild). * lib/tap-driver.pl: Move it ... * contrib/tap-driver.pl: ... here. While at it, convert quoting `like this' to quoting 'like this', and remove an obsolescent FIXME comment. * lib/Makefile.inc (dist_script_DATA): Drop '%D%/tap-driver.pl'. * Makefile.am (EXTRA_DIST): Add 'contrib/tap-driver.pl'. * doc/automake.texi: Remove one stray reference to 'tap-driver.pl', and reference 'tap-driver.sh' instead, as intended. * t/ax/am-test-lib.sh ($am_tap_implementation): Delete definition and uses. (fetch_tap_driver): Simplify to unconditionally assume the shell+awk implementation of the TAP driver is used. (get_shell_script): Make more flexible so that it can cater to the needs of 'fetch_tap_driver()'. * t/tap-bad-prog.tap: Likewise. * t/tap-bailout-leading-space.sh: Likewise. * t/tap-signal.tap: Likewise. * t/tap-test-number-0.sh: Likewise. * t/test-driver-cond.sh: Use 'tap-driver.sh' instead of 'tap-driver.pl'. * gen-testsuite-part (%test_generators): Do not generate sister tests that use the perl TAP driver rather than the shell+awk one. * NEWS: Update. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | | * | docs: drop a few obsolescent FIXME/TODO comments, and associated textStefano Lattarini2013-12-241-20/+0
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | | * | testsuite harness: report test exit status in log fileStefano Lattarini2013-12-245-4/+87
| | | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The exit status of a test should be reported in the test logs, so that one can see at a glance whether the test has succeeded or failed, without having to look also into the corresponding .trs file. This fixes automake bug#11814. * lib/test-driver: Also report the test script exit status in the test log (as the last line). * t/check-exit-status-reported.sh: Test this new behaviour. * t/list-of-tests.mk: Add the new test. * t/ax/test-lib.sh( am_exit_trap): No longer log the test exit status; this has been made redundant by the change to 'test-driver'. While at it, fix an imperfect quoting. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * | TAP driver: no need to invoke AC_PROG_AWK directlyStefano Lattarini2013-12-243-8/+5
| | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is already required by AM_INIT_AUTOMAKE anyway. * doc/automake.texi: Adjust examples. * t/tap-doc2.sh: Adjust documentation-tracking test. * m4/init.m4 (AM_INIT_AUTOMAKE): Explicitly tell that the AC_PROG_AWK requirement is also needed whenever the TAP driver is used. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * NEWS: stop reporting "new" Automake versioning schemeStefano Lattarini2013-12-241-42/+0
| | | | | | | | | | | | | | | | | | It's actually old news by now. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * Merge branch 'micro' into minorStefano Lattarini2013-12-2411-161/+55
| | |\ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * micro: post-release: micro version bump to 1.14.1a devel version release: stable micro release 1.14.1 HACKING: minor clarification tests: make install-info-dir.sh print more debugging info tests: remove too-brittle test tap-realtime.sh maintainer: am-ft: add option to cater to clock skews sync: update INSTALL, config.guess and config.sub from upstream TAP driver: cosmetic fixes Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | post-release: micro version bump to 1.14.1a devel versionStefano Lattarini2013-12-242-3/+3
|/ / | | | | | | | | | | | | * configure.ac (AC_INIT): Bump version number to 1.14.1a. * m4/amversion.m4: Likewise (auto-updated by "make bootstrap"). Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | release: stable micro release 1.14.1v1.14.1Stefano Lattarini2013-12-242-5/+5
| | | | | | | | | | | | | | * configure.ac (AC_INIT): Bump version number to 1.14.1. * m4/amversion.m4: Likewise (auto-updated by "make bootstrap"). Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | HACKING: minor clarificationStefano Lattarini2013-12-241-1/+1
| | | | | | | | Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | tests: make install-info-dir.sh print more debugging infoStefano Lattarini2013-12-231-5/+7
| | | | | | | | | | | | With the hope that this will shed more light on bug#14601 Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>