summaryrefslogtreecommitdiff
path: root/t/java-compile-run-flat.sh
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'master' into ng/masterStefano Lattarini2015-01-051-1/+1
|\ | | | | | | | | | | * master: maint: update copyright years to 2015 (branch 'master') maint: update copyright years to 2015 (branch 'micro')
| * maint: update copyright years to 2015 (branch 'micro')Stefano Lattarini2015-01-051-1/+1
| | | | | | | | Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| * maint: update copyright yearsStefano Lattarini2014-04-211-1/+1
| | | | | | | | | | | | We've been in 2014 already for few months now... Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | update copyright years in all filesStefano Lattarini2014-12-191-1/+1
| | | | | | | | Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | Merge branch 'master' into ng/masterStefano Lattarini2013-05-201-0/+0
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: tests: fix a spurious failure on NetBSD 5.1 texi: build version.texi and stamp-vti in srcdir tests: fix a botched heading comment tests: fix another spurious with FreeBSD make tests: fix a spurious failure with FreeBSD make tests: fix a spurious failure with FreeBSD make lisp: fix a failure with Solaris /usr/xpg4/bin/sh tests: sanitize 'unset' usages tests: fix some botched/outdated comments tests: use perl, not find+rm, to remove temporary directories depend: reduce code duplication, de-uglify make verbose output tests: remove remaining exec bits ('master' branch) tests: remove remaining exec bits ('maint' branch) tests: remove exec bit from all of them ('micro' branch) maint: tests no longer need to have executable bit set PLANS: subdir-objects: various updates depend: prefer $(...) over `...` in Cygwin-specific recipes depend: reduce code duplication depend: a preparatory refactoring depend: refactor and remove code duplication Automake::Language: drop unused fields 'compile_flag' and 'output_flag' depend: assume '-c' compiler flag always means to produce object files depend: assume we can always pass '-o' to the C compiler cleanup: having subdir-objects mandatory allow us some simplifications subdir-objects: enable unconditionally + Non-trivial extra changes (excerpt): * bin/automake.in: remove few remaining subroutine prototypes. * lib/am/depend2.am: Drop uses of '%-o%' and '%-c%' transforms; just assume they expand to '-o' and '-c' unconditionally. Be sure to always use a space after the '%SOURCEFLAG%' transform. Drop obsolete comments. * t/: Make those *.sh and *.tap tests that are only present for Automake-NG and not mainline Automake non-executable (as it has already been done for the tests in mainline Automake). Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| * tests: remove exec bit from all of them ('micro' branch)Stefano Lattarini2013-05-161-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It gives the impression that they are directly runnable, as with "./t/foo.sh", but it has been a while since that was the case. Today, tests are runnable only through "make check" or "./runtest". This change is for the 'micro' branch (automake 1.13.2a). It will soon be followed by similar patches for the 'maint' branch (automake 1.13a) and the 'master' branch (automake 1.99a). * t/*.sh, t/*.tap: Remove executable bit. * maint.mk (sc_tests_executable): Remove. (syntax_check_rules): Adjust. * gen-testsuite-part: Set permissions of generated tests to '444' (-r--r--r--), rather than 555 (-r-xr-xr-x). Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | Merge branch 'master' into ng/masterStefano Lattarini2012-12-311-1/+1
|\ \ | |/ | | | | | | | | * master: maint: update copyright year for 2013 (in branch master) maint: update copyright year for 2013 (in branch maint)
| * maint: update copyright year for 2013 (in branch maint)Stefano Lattarini2012-12-311-1/+1
| | | | | | | | Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | Merge branch 'master' into ng/masterStefano Lattarini2012-10-271-1/+1
|\ \ | |/ | | | | | | | | | | | | | | | | * master: tests: remove spurious leftover use of 'Exit' tests: remove an obsolete, and probably now wrong, comment tests: remove obsolescent references to './defs' tests: prefer including 'test-init.sh' rather than './defs' Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| * tests: prefer including 'test-init.sh' rather than './defs'Stefano Lattarini2012-10-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow-up to today's commit v1.12.4-22-g0610fc8, "tests: prepare to move ./defs to t/ax/test-init.sh" * All tests: To run the common setup, use the command: . test-init.sh instead of the older, "historical" one: . ./defs || exit 1 Note that the "|| exit 1" wasn't really useful, since the 'errexit' shell flag is in effect in both './defs' and 'test-init.sh', and all the known shells that are good enough to run the automake testsuite do automatically exit with error when a sourced file cannot be found (at least, they do so in non-interactive mode, which is the only mode that concerns us in the testsuite). * t/ax/tap-summary-aux.sh, t/ax/testsuite-summary-checks.sh: Likewise. * gen-testsuite-part: Do the same in the generated tests. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | Merge branch 'master' into ng/masterStefano Lattarini2012-08-131-1/+1
|\ \ | |/ | | | | | | | | | | | | | | | | * master: tests: rework tests on AM_PATH_PYTHON cosmetics: fix typos and references in comments typofix: in a test diagnostic readme: fixlets to HACKING cleanup: remove unused transform '%HAVE-MANS%' cleanup: remove stale references to 'lzma' option
| * Merge branch 'maint'Stefano Lattarini2012-08-131-1/+1
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | * maint: tests: rework tests on AM_PATH_PYTHON cosmetics: fix typos and references in comments typofix: in a test diagnostic readme: fixlets to HACKING Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * cosmetics: fix typos and references in commentsStefano Lattarini2012-08-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | * lib/am/check.am: Here. * doc/automake.texi: And here. * t/*.sh: And in several of these tests. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | Merge branch 'master' into ng/masterStefano Lattarini2012-06-281-1/+1
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: cosmetics: remove trailing whitespace in some files coverage: enhance tests in 'missing' script a little coverage: tests AM_MISSING_PROG usage docs: document AM_MISSING_PROG tests: fix a spurious failure with Solaris make tests: simpler workaround for shells losing the exit status in exit trap tests: avoid several spurious failures on Solaris tests: avoid a spurious failure on NetBSD + Extra non-trivial edits: * Several tests: Adjusted to use 'exit' rather than 'Exit'. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| * | Merge branch 'maint'Stefano Lattarini2012-06-281-1/+1
| |\ \ | | |/ | | | | | | | | | | | | | | | | | | | | | | | | * maint: tests: simpler workaround for shells losing the exit status in exit trap + Extra non-trivial edits: * Several tests: Adjusted to use 'exit' rather than 'Exit'. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * tests: simpler workaround for shells losing the exit status in exit trapStefano Lattarini2012-06-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that we can assume our tests are run by a decent POSIX shell, we can simplify our workaround aimed at having the exit status propagated correctly to the code in the exit trap. Unfortunately, we cannot dispense with such a workaround altogether, because it's still required by some shells we need to support (at least Solaris 10 /bin/ksh and /usr/xpg4/bin/sh). For more information about the need of that workaround, see the entry about 'trap' in the section "Limitations of Shell Builtins" in the Autoconf manual: <http://www.gnu.org/software/autoconf/manual/autoconf.html#trap> The new workaround has been tested successfully with the following shells: - Bash 4.1 - Bash 3.2 - Bash 3.0 - Bash 2.05b - dash 0.5.5.1 - dash 0.5.2 - AT&T Ksh 93u (from official Debian package) - MirBSD Korn Shell 40.2 (from official Debian package) - Solaris 9, 10 and 11 /bin/ksh - Solaris 9, 10 and 11 /usr/xpg4/bin/sh - NetBSD 5.1 /bin/sh - NetBSD 5.1 /bin/ksh * t/ax/test-init.sh (Exit): Rename ... (_am_exit): ... like this. (exit): New alias for '_am_exit'. We cannot simply redefine 'exit' as a shell function, because some shells (dash 0.5.5.1, Solaris 10 /bin/ksh and /usr/xpg4/bin/sh) do not allow it. (_am_exit, trap): Add extra escaping for 'exit' calls, to ensure we really invoke the 'exit' builtin and not our alias with the same name. * configure.ac: Check that the shell selected to run our testsuite supports aliases named like shell builtins. * t/REAMDE: Adjust. * All tests: Adjust, by simply using 'exit' instead of 'Exit'. * t/self-check-explicit-skips.sh: Adjust: the first usage of 'exit' after it has been redefined as an alias must be on a new line w.r.t. that where the alias is defined, in order for the redefinition to be honored. * syntax-checks.mk (sc_tests_Exit_not_exit): Delete. (sc_tests_exit_not_Exit): New. (syntax_check_rules): Adjust. (sc_tests_automake_fails): Simplify the recipe a little. * Several tests: Remove now useless spurious quoting once required to placate the 'sc_tests_Exit_not_exit' maintainer check. * gen-testsuite-part: Likewise. Also, avoid uses of 'Exit' in the generated scripts. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | Merge branch 'master' into ng/masterStefano Lattarini2012-06-221-1/+1
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: tests: prefer using 'is_newest' over 'ls -t' hacks tests: implement is_newest as an auxiliary script, not shell function tests: fix some spurious failures in VPATH setup tests: work in VPATH setup again tests: automatic re-execution works for non-POSIX shells too tests: use more POSIX shell features our test scripts docs: avoid failures with development version of Texinfo (4.13.90) typofix: s/test derivers/test drivers/ in check.am comments typofix: s/env/even/ in comments in GNUmakefile Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| * | Merge branch 'maint'Stefano Lattarini2012-06-221-1/+1
| |\ \ | | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * maint: tests: automatic re-execution works for non-POSIX shells too tests: use more POSIX shell features our test scripts + Extra non-trivial edits: * t/ax/test-init.sh: Apply the diffs between past versions of 'defs' in maint and in master; i.e., remove handling of $required entries 'texi2dvi-o' and 'makeinfo-html', and adjust to the fact that the parallel testsuite harness is now the default. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| | * tests: use more POSIX shell features our test scriptsStefano Lattarini2012-06-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since commit 'v1.12-36-g2d68fd9' of 2012-05-07, "configure: search a sturdy POSIX shell to be used in the testsuite", the shell running our test script is assured to be a POSIX-conforming shell, so we can use the more modern and flexible idioms and features that we couldn't use when we also aimed at compatibility with non-POSIX Bourne shells, like Solaris /bin/sh. * t/README: Suggest to use POSIX shell features liberally in test cases, with possible exception of Makefile recipes and configure shell code. * Several tests: Adjust to use more POSIX shell features; e.g., $(...) rather than `...`, $((...)) rather than `expr ...`, "if ! CMD; then ..." instead of "if CMD; then :; else ...", and so on. In several places, when using the 'test' built-in, prefer '-eq' over '=' for numeric comparisons, and prefer "grep -c PATTERN FILE" over "grep PATTERN FILE | wc -l". Throw in other low-hanging easy improvements and fixlets while we are at it. * t/ax/depcomp.sh, t/ax/tap-summary-aux.sh, t/ax/tap-functions.sh, defs, defs-static.in: Likewise. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | general: assume '#' comment in make recipes are okStefano Lattarini2012-05-251-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Autoconf manual (2.69) reports: Some make implementations treat anything starting with a tab as a command for the current rule, even if the tab is immediately followed by a '#'. The make from Tru64 Unix V5.1 is one of them. The issue doesn't affect GNU make though, so we can zap another now redundant automake time check * automake.in (read_am_file): Don't report rules starting with a "#" as unportable. * t/comment3.sh: Remove as obsolete. * Several tests: In make rules, use '#' comments rather than more fragile ':' comments; e.g., instead of: : Processed header files should not be distributed. test ! -r $(distdir)/one.h use: # Processed header files should not be distributed. test ! -r $(distdir)/one.h Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | | Merge branch 'master' into ng/masterStefano Lattarini2012-05-221-2/+2
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | * master: check: the parallel-tests driver is now the default ylwrap: preserve subdirectories in "#line" munging ylwrap: preparatory refactoring Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| * | check: the parallel-tests driver is now the defaultStefano Lattarini2012-05-181-2/+2
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The old serial testsuite driver is still supported, and can be activated by the 'serial-tests' option (introduced by commit 'v1.11-1989-gdeb7773' of 2012-02-20, "automake: new option 'serial-tests'"). * lib/Automake/Options.pm: Now, the 'parallel-tests' option is a no-op (but still explicitly recognized, for backward compatibility), while the 'serial-tests' option is recognized and registered. * automake.in: Adjust to ensure that the parallel test harness is used by default; mostly, this amounts at using "! option('serial-tests')" where "option('parallel-tests')" was used before. * NEWS, doc/automake.texi: Update. * configure.ac (AM_INIT_AUTOMAKE): Drop 'parallel-tests' option, is redundant now. * defs: In the generated AM_INIT_AUTOMAKE call, use the 'serial-tests' when the serial testsuite harness is to be used, and no option otherwise. * lib/am/check.am: Use (static) conditional '%SERIAL_TESTS%' instead of conditional '%PARALLEL_TESTS%'. * lib/test-driver: Adjust heading comments. * t/ax/extract-testsuite-summary.pl: Likewise. * t/check-exported-srcdir.sh: Likewise. * t/check-subst.sh: Likewise. * t/java-compile-run-nested.sh: Likewise. * t/parallel-tests-dry-run-1.sh: Likewise. * t/parallel-tests-dry-run-2.sh: Likewise. * t/parallel-tests-interrupt.sh: Likewise. * t/parallel-tests-many.sh: Likewise. * t/test-metadata-global-log.sh: Likewise. * t/tests-environment-backcompat.sh: Likewise. * m4/init.m4 (AM_INIT_AUTOMAKE): Adjust a comment. * t/check8.sh: Likewise. * t/check-tests-in-builddir.sh: Likewise. * t/java-compile-run-flat.sh: Adjust a botched comment. * t/ax/tap-summary-aux.sh: Remove explicit use of the 'parallel-tests' option. * t/ax/testsuite-summary-checks.sh: Likewise. * t/aclocal-path-precedence.sh: Likewise. * t/dist-aux-many-subdirs.sh: Likewise. * t/parallel-tests-no-color-in-log.sh: Likewise. * t/parallel-tests-reset-term.sh: Likewise. * t/parallel-tests-subdir.sh: Likewise. * t/check-no-test-driver.sh: Fix setup to adjust to the changed semantics. Update heading comments. * t/parallel-tests-driver-install.sh: Adjust to the new semantic. * t/test-driver-is-distributed.sh: Simplified according to the new semantics. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | Merge branch 'master' into ng/masterStefano Lattarini2012-05-181-1/+1
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: tests: use 'parallel-tests' Automake option by default doc: fix location of Automake's own test-suite.log file yacc tests: avoid a spurious failure with Sun C++ 5.9 self tests: cater for /bin/ksh symlinked to Zsh tests: fix spurious failures due to dpkg install-info + Non-trivial extra edits: * t/check7.sh: look at the contents of '$am_serial_tests', not of '$am_parallel_tests', to decide which kind of testsuite harness is being used. * t/parallel-tests-concatenated-suffix.sh: Don't explicitly set '$am_parallel_tests' to "yes" anymore, is not required and would cause a 'maintainer-check' failure. * t/parallel-tests-dynamic.sh: Likewise. * t/parallel-tests-longest-stem.sh: Likewise. * t/parallel-tests-no-repeat.sh: Likewise. * t/parallel-tests-per-suffix-deps.sh: Likewise. * t/parallel-tests-srcdir-in-test-name.sh: Likewise. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
| * tests: use 'parallel-tests' Automake option by defaultStefano Lattarini2012-05-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will help our transition from 'serial-tests' to 'parallel-tests' as the default test suite driver enabled by a TESTS assignment in the input Makefile.am. Note that that change of default will only take place in master, though. * defs: Pass the 'parallel-tests' option to the AM_INIT_AUTOMAKE invocation in the created 'configure.ac' stub, unless the variable 'am_serial_tests' is set to "yes". Don't pay attention anymore to the 'am_parallel_tests' variable, that's obsolete now. * defs-static.in: Warn if the 'am_serial_tests' variable is set in the environment; conversely, don't warn anymore about 'am_parallel_tests' being set in the environment. * Makefile.am (AM_TESTS_ENVIRONMENT): Nullify the 'am_serial_tests' variable instead of the now-obsolete 'am_parallel_tests' one. * syntax-checks.mk (sc_tests_obsolete_variables): Also warn against uses of 'am_parallel_tests', which is now deprecated in favor of 'am_serial_tests'. Similarly, if a use of 'parallel_tests' is seen, suggest using 'am_serial_tests' instead, not 'am_parallel_tests'. * gen-testsuite-part: Now that we use the 'parallel-tests' by default in our tests, we need to completely change the logic and semantics of generation of sibling tests for those tests that check the Automake generated testsuite harness itself. Do that, and give a complete explanation of the new logic and semantics in the relevant comments. * t/README: Update. * Lots of test cases: Adjust. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* | Merge branch 'master' into ng/masterStefano Lattarini2012-04-111-2/+2
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: vala tests: force the use of automatic dependency tracking tests: avoid spurious failures in tests on C++ and lex tests: avoid spurious failures with non-flex 'lex' programs and C++ tests: avoid a spurious failures for shells with busted 'set -e' maint: simplify generation of files with @substed@ stuff tests: remove redundant requirement tests: make two test scripts executable t/README: update w.r.t. recent overhaul (non-recursive build system) docs: fix names of relevant test cases in comments NEWS: automake build systems avoids make recursion maint: no more make recursion in Automake's build system tests: rename 'tests/' => 't/', '*.test' => '*.sh' tests: remove recipes that run tests with 'prove' tests: move most helper scripts and files into the 'ax' subdirectory maint: remove most recursion in automake's own build system tests: fix a spurious failures with non-GNU make + Extra non-trivial edits: * Makefile.am: Remove new uses of 'AM_MAKEFLAGS' throughout. (dist_automake_ac_DATA): Do not list 'm4/depout.m4' nor 'm4/make.m4'. * syntax-checks.m4: Use '$(xdefs)' instead of hard-coding the older paths of 'defs' and 'defs-static.in'. Use 't/README' instead of 'tests/README'. * t/instdir-no-empty.sh: Remove uses of 'AM_MAKEFLAGS'. * tests/depcomp-recover.test: Renamed ... * t/depcomp-recover.sh: ... to this. * tests/gmake-vars.test: Renamed ... * t/gmake-vars.sh: ... to this. * tests/interp3.test: Renamed ... * t/interp3.sh: ... to this. * tests/objdir.test: Renamed ... * t/objdir.sh: ... to this. * tests/spy-vpath-rewrite.test: Renamed ... * t/spy-vpath-rewrite.sh: ... to this. * tests/vpath-rewrite.test: Renamed ... * t/vpath-rewrite.sh: ... to this. * tests/yacc-subobj-nodep.test: Renamed ... * t/yacc-subobj-nodep.sh: ... to this. * tests/depcomp-shuffle.sh: Renamed ... * t/ax/depcomp-shuffle.sh: ... to this, and removed executable bit. * t/depcomp-shuffle-sub-vpath.sh: Adjust. * t/depcomp-shuffle-sub.sh: Likewise. * t/depcomp-shuffle-vpath.sh: Likewise. * t/depcomp-shuffle.sh: Likewise. * gen-testsuite-part: Likewise. * t/list-of-tests.mk: Do not list tests that had been already removed from the Automake-NG testsuite. Take into account the renames above. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
* tests: rename 'tests/' => 't/', '*.test' => '*.sh'Stefano Lattarini2012-04-061-0/+241
When we (soon) convert the Automake testsuite to a non-recursive make setup, we'll have to fix the entries of $(TESTS) to be prepended with the subdirectory they are in; this will increase the length of $(TESTS), and thus increase the possibility of exceeding the command-line length limits on some systems (most notably, MinGW/MSYS). See automake bug#7868 for more information. Thus we rename the 'tests/' subdirectory to 't/', and each 'x.test' script in there to 'x.sh'; this way, the $(TESTS) entry 'foo.test' will become 't/foo.sh', which have the same number of characters. * tests/: Rename ... * t/: ... to this. * t/*.test: Rename ... * t/*.sh: ... to this. * t/.gitignore: Removed as obsolete. * t/defs: Adjust. * t/gen-testsuite-part: Likewise. * t/list-of-tests.mk: Likewise. * t/ccnoco.sh: Likewise. * t/ccnoco3.sh: Likewise. * t/self-check-cleanup.tap: Likewise. * t/self-check-dir.tap: Likewise. * t/self-check-me.tap: Likewise. * t/self-check-reexec.tap: Likewise. * README: Likewise. * bootstrap: Likewise * configure.ac: Likewise. * Makefile.am: Likewise. * .gitignore: Likewise. * syntax-check.mk: Likewise. Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>