From 6e713425a0dcede167924e7691e95ab5e54e399c Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Thu, 14 Jun 2012 13:13:58 +0200 Subject: tests: use more POSIX shell features our test scripts Since commit 'v1.12-36-g2d68fd9' of 2012-05-07, "configure: search a sturdy POSIX shell to be used in the testsuite", the shell running our test script is assured to be a POSIX-conforming shell, so we can use the more modern and flexible idioms and features that we couldn't use when we also aimed at compatibility with non-POSIX Bourne shells, like Solaris /bin/sh. * t/README: Suggest to use POSIX shell features liberally in test cases, with possible exception of Makefile recipes and configure shell code. * Several tests: Adjust to use more POSIX shell features; e.g., $(...) rather than `...`, $((...)) rather than `expr ...`, "if ! CMD; then ..." instead of "if CMD; then :; else ...", and so on. In several places, when using the 'test' built-in, prefer '-eq' over '=' for numeric comparisons, and prefer "grep -c PATTERN FILE" over "grep PATTERN FILE | wc -l". Throw in other low-hanging easy improvements and fixlets while we are at it. * t/ax/depcomp.sh, t/ax/tap-summary-aux.sh, t/ax/tap-functions.sh, defs, defs-static.in: Likewise. Signed-off-by: Stefano Lattarini --- t/python.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 't/python.sh') diff --git a/t/python.sh b/t/python.sh index de8c0bbfb..0fe5d12d1 100755 --- a/t/python.sh +++ b/t/python.sh @@ -53,8 +53,8 @@ $AUTOMAKE Makefile3 grep "py" Makefile.in Makefile2.in Makefile3.in # For debugging. for f in Makefile.in Makefile2.in Makefile3.in; do - test `grep -c '^py_compile =' $f` -eq 1 - test `grep -c '^am__py_compile =' $f` -eq 1 + test $(grep -c '^py_compile =' $f) -eq 1 + test $(grep -c '^am__py_compile =' $f) -eq 1 done : -- cgit v1.2.1