From 7c797eb87385522ce1ec1ba44315ba386d82978d Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Wed, 28 Sep 2022 16:33:21 +0200 Subject: gpio: Fix gpio commands called without -d option 04443dc5fc breaks the calculation of arguments needed which effectively makes the -d option mandatory. Fix this. Fixes: 04443dc5fc ("commands: gpio: add -d argument to set/get commands") Reported-by: Enrico Scholz Signed-off-by: Sascha Hauer --- commands/gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'commands') diff --git a/commands/gpio.c b/commands/gpio.c index d04fd65bc8..5e5eb20583 100644 --- a/commands/gpio.c +++ b/commands/gpio.c @@ -11,7 +11,7 @@ static int get_gpio_and_value(int argc, char *argv[], { struct gpio_chip *chip = NULL; struct device_d *dev; - int count = 2; + int count = 1; int ret = 0; int opt; @@ -34,7 +34,7 @@ static int get_gpio_and_value(int argc, char *argv[], if (value) count++; - if (optind < count) + if (argc < optind + count) return COMMAND_ERROR_USAGE; *gpio = gpio_find_by_name(argv[optind]); -- cgit v1.2.1