diff options
| author | Pedro Alves <palves@redhat.com> | 2013-04-19 15:37:31 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2013-04-19 15:37:31 +0000 |
| commit | 9c37696b249b48558ff2162259fc77360c38f28e (patch) | |
| tree | ba8b532641b99ea9380ab5fb8c38884e31550b7b | |
| parent | a398505b407f8197a9efd80490d3c4a725aeaab0 (diff) | |
| download | binutils-gdb-9c37696b249b48558ff2162259fc77360c38f28e.tar.gz | |
-Wpointer-sign: record.c.
../../src/gdb/record.c: In function ‘set_record_insn_history_size’:
../../src/gdb/record.c:670:5: error: pointer targets in passing argument 2 of ‘validate_history_size’ differ in signedness [-Werror=pointer-sign]
../../src/gdb/record.c:646:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’
../../src/gdb/record.c: In function ‘set_record_call_history_size’:
../../src/gdb/record.c:682:5: error: pointer targets in passing argument 2 of ‘validate_history_size’ differ in signedness [-Werror=pointer-sign]
../../src/gdb/record.c:646:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’
This fixes it in the obvious way.
gdb/
2013-04-19 Pedro Alves <palves@redhat.com>
* record.c (validate_history_size): Make parameter 'setting'
unsigned.
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/record.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 379c8d22ec7..191ef31463e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2013-04-19 Pedro Alves <palves@redhat.com> + * record.c (validate_history_size): Make parameter 'setting' + unsigned. + +2013-04-19 Pedro Alves <palves@redhat.com> + * ctf.c (ctf_write_uploaded_tsv, ctf_write_uploaded_tp): Add casts to 'gdb_byte *'. diff --git a/gdb/record.c b/gdb/record.c index 0a7f0a1aa50..76d9fd2d7a9 100644 --- a/gdb/record.c +++ b/gdb/record.c @@ -643,7 +643,7 @@ cmd_record_call_history (char *arg, int from_tty) is the real setting the command allows changing. */ static void -validate_history_size (unsigned int *command_var, int *setting) +validate_history_size (unsigned int *command_var, unsigned int *setting) { if (*command_var != UINT_MAX && *command_var > INT_MAX) { |