summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJim Wilson <jimw@sifive.com>2017-11-24 09:31:59 -0800
committerJim Wilson <jimw@sifive.com>2017-11-24 09:31:59 -0800
commit0fbc35681ff0825be97802efcccf953bc4573a45 (patch)
tree3686d62476ff454bc2c9883908840b3f7616abb6
parent8b77421a20c22c9a66048e7d1484b149da060b67 (diff)
downloadbinutils-gdb-0fbc35681ff0825be97802efcccf953bc4573a45.tar.gz
Add reference to implicit use in _bfd_elf_is_local_label_name.
gas/ * write.h (FAKE_LABEL_CHAR): Expand comment.
-rw-r--r--gas/ChangeLog4
-rw-r--r--gas/write.h11
2 files changed, 13 insertions, 2 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog
index d6c9d4cd7a6..13fee06986a 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,7 @@
+2017-11-24 Jim Wilson <jimw@sifive.com>
+
+ * write.h (FAKE_LABEL_CHAR): Expand comment.
+
2017-11-24 Jan Beulich <jbeulich@suse.com>
* config/tc-i386.c (check_VecOperations): Check register type
diff --git a/gas/write.h b/gas/write.h
index 4157bc971cb..d2c6af6824b 100644
--- a/gas/write.h
+++ b/gas/write.h
@@ -27,8 +27,15 @@
#define FAKE_LABEL_NAME "L0\001"
#endif
-/* This is the special character used to indicate a fake symbol. Must be
- present in FAKE_LABEL_NAME. */
+/* This is a special character that is used to indicate a fake label.
+ It must be present in FAKE_LABEL_NAME, although it does not have to
+ be the first character. It must not be a character that would be
+ found in a valid symbol name.
+
+ Also be aware that the function _bfd_elf_is_local_label_name in
+ bfd/elf.c has an implicit assumption that FAKE_LABEL_CHAR is '\001'.
+ If this is not the case then FAKE_LABEL_NAME must start with ".L" in
+ order for the function to continue working. */
#ifndef FAKE_LABEL_CHAR
#define FAKE_LABEL_CHAR '\001'
#endif