diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2020-01-12 12:07:30 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2020-01-12 12:07:30 -0500 |
| commit | c0b0a14290e1909a6cc3febb443560c3e95562c2 (patch) | |
| tree | 9fc785d0f022406d8230ea5c5945176d466598ce | |
| parent | bb1183e25ae74ba21500fb4e39bc1ca9822e3086 (diff) | |
| download | binutils-gdb-c0b0a14290e1909a6cc3febb443560c3e95562c2.tar.gz | |
gdbserver: include linux-arm-tdesc.h in linux-arm-tdesc.c
When building with -Wmissing-declarations, I get:
CXX linux-arm-tdesc.o
/binutils-gdb/gdb/gdbserver/linux-arm-tdesc.c:29:1: error: no previous declaration for 'const target_desc* arm_linux_read_description(arm_fp_type)' [-Werror=missing-declarations]
29 | arm_linux_read_description (arm_fp_type fp_type)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
/binutils-gdb/gdb/gdbserver/linux-arm-tdesc.c:49:1: error: no previous declaration for 'arm_fp_type arm_linux_get_tdesc_fp_type(const target_desc*)' [-Werror=missing-declarations]
49 | arm_linux_get_tdesc_fp_type (const target_desc *tdesc)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Include linux-arm-tdesc.h in linux-arm-tdesc.c to fix it. And because
linux-arm-tdesc.h uses the arm_fp_type, it should include arch/arm.h as
well.
gdb/gdbserver/ChangeLog:
* linux-arm-tdesc.c: Include linux-arm-tdesc.h.
* linux-arm-tdesc.h: Include arch/arm.h.
| -rw-r--r-- | gdb/gdbserver/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/gdbserver/linux-arm-tdesc.c | 3 | ||||
| -rw-r--r-- | gdb/gdbserver/linux-arm-tdesc.h | 2 |
3 files changed, 10 insertions, 0 deletions
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 83be63c393e..67d39beba5b 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,5 +1,10 @@ 2020-01-12 Simon Marchi <simon.marchi@polymtl.ca> + * linux-arm-tdesc.c: Include linux-arm-tdesc.h. + * linux-arm-tdesc.h: Include arch/arm.h. + +2020-01-12 Simon Marchi <simon.marchi@polymtl.ca> + * linux-aarch64-low.c (aarch64_write_goto_address): Make static. 2020-01-12 Simon Marchi <simon.marchi@polymtl.ca> diff --git a/gdb/gdbserver/linux-arm-tdesc.c b/gdb/gdbserver/linux-arm-tdesc.c index 5af1f90070b..2c9fac83cd5 100644 --- a/gdb/gdbserver/linux-arm-tdesc.c +++ b/gdb/gdbserver/linux-arm-tdesc.c @@ -16,6 +16,9 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */ #include "server.h" + +#include "linux-arm-tdesc.h" + #include "tdesc.h" #include "arch/arm.h" #include <inttypes.h> diff --git a/gdb/gdbserver/linux-arm-tdesc.h b/gdb/gdbserver/linux-arm-tdesc.h index bc782e13320..5e8c6a3be57 100644 --- a/gdb/gdbserver/linux-arm-tdesc.h +++ b/gdb/gdbserver/linux-arm-tdesc.h @@ -18,6 +18,8 @@ #ifndef GDBSERVER_LINUX_ARM_TDESC_H #define GDBSERVER_LINUX_ARM_TDESC_H +#include "arch/arm.h" + /* Return the Arm target description with fp registers FP_TYPE. */ const target_desc * arm_linux_read_description (arm_fp_type fp_type); |