summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2020-01-22 13:02:11 +1030
committerAlan Modra <amodra@gmail.com>2020-01-22 17:14:08 +1030
commitabc489c64a3137f3751797e8ce60d53a2c432e1d (patch)
tree3013677f8f4a43baa9dc013411b280a51d6d1dac
parentc48acf6f26713427fb6870a8551a89ac12838e7b (diff)
downloadbinutils-gdb-abc489c64a3137f3751797e8ce60d53a2c432e1d.tar.gz
PowerPC64 TLS optimization fix
When linking with --no-tls-optimize the linker doesn't generate a call or long branch stub to __tls_get_addr in some circumstances, giving: relocation truncated to fit: R_PPC64_REL24 against symbol `__tls_get_addr' * elf64-ppc.c (ppc64_elf_size_stubs): Correct condition under which __tls_get_addr calls will be eliminated.
-rw-r--r--bfd/ChangeLog5
-rw-r--r--bfd/elf64-ppc.c3
2 files changed, 7 insertions, 1 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 45f24997353..894faec848d 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2020-01-22 Alan Modra <amodra@gmail.com>
+
+ * elf64-ppc.c (ppc64_elf_size_stubs): Correct condition under
+ which __tls_get_addr calls will be eliminated.
+
2020-01-20 Nick Clifton <nickc@redhat.com>
* po/pt.po: Updates Portuguese translation.
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 3ae294b500d..2ee9fe404cb 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -13083,7 +13083,8 @@ ppc64_elf_size_stubs (struct bfd_link_info *info)
if (!get_tls_mask (&tls_mask, NULL, NULL, &local_syms,
irela - 1, input_bfd))
goto error_ret_free_internal;
- if ((*tls_mask & TLS_TLS) != 0)
+ if ((*tls_mask & TLS_TLS) != 0
+ && (*tls_mask & (TLS_GD | TLS_LD)) == 0)
continue;
}