summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2019-01-25 09:34:14 +1030
committerAlan Modra <amodra@gmail.com>2019-01-25 09:41:41 +1030
commit0c56b5cfb68cd099e00f6fdb5ad08061c7b16b79 (patch)
tree8b653d3fe7179c2e5e61ed521962e4f072b2b07d
parentadc6a863a9c6c828425d63b12d553f0e8f21e350 (diff)
downloadbinutils-gdb-0c56b5cfb68cd099e00f6fdb5ad08061c7b16b79.tar.gz
PR24125, Assertion failure with embedded NULs in string
An assertion that can be triggered by user input is wrong, so remove it. I believe the NUL would have been accepted before the PR20902 patch. PR 20902 PR 24125 * read.c (stringer): Delete assertion.
-rw-r--r--gas/ChangeLog6
-rw-r--r--gas/read.c2
2 files changed, 6 insertions, 2 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 972e227c626..a930a842424 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,9 @@
+2019-01-25 Alan Modra <amodra@gmail.com>
+
+ PR 20902
+ PR 24125
+ * read.c (stringer): Delete assertion.
+
2019-01-21 Nick Clifton <nickc@redhat.com>
* po/uk.po: Updated Ukranian translation.
diff --git a/gas/read.c b/gas/read.c
index 3c84d4388c8..228fe7a240e 100644
--- a/gas/read.c
+++ b/gas/read.c
@@ -5364,8 +5364,6 @@ stringer (int bits_appendzero)
if (append_zero)
stringer_append_char (0, bitsize);
- know (input_line_pointer[-1] == '\"');
-
#if !defined(NO_LISTING) && defined (OBJ_ELF)
/* In ELF, when gcc is emitting DWARF 1 debugging output, it
will emit .string with a filename in the .debug section