diff options
| author | Tom Tromey <tromey@adacore.com> | 2019-09-20 11:34:21 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2019-09-20 11:34:21 -0600 |
| commit | d42076962798cd2329090cea213e797f4c69c03c (patch) | |
| tree | 6fb2ab9b364e85845a69109da5018915227c205a | |
| parent | a48931cc2df9f87596d93b319236c73ef0fe0f4e (diff) | |
| download | binutils-gdb-d42076962798cd2329090cea213e797f4c69c03c.tar.gz | |
Fix crash in Ada "catch exception"
PR ada/24919 concerns a crash that Tom de Vries noticed when running
the "catch_ex" Ada test case. He sent a test executable and tracked
this down to commit f21c2bd7b7 ("Fix Fortran regression with variables
in nested functions").
Looking at that patch, you can see the obvious error:
- return 0;
+ return true;
Oops! This patch fixes the bug.
Tested on x86-64 Fedora 29.
gdb/ChangeLog
2019-09-20 Tom Tromey <tromey@adacore.com>
PR ada/24919:
* block.c (contained_in): Fix final return value.
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/block.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5314b2746bc..b1c4db854b4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-09-20 Tom Tromey <tromey@adacore.com> + + PR ada/24919: + * block.c (contained_in): Fix final return value. + 2019-09-20 Alan Modra <amodra@gmail.com> * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata. diff --git a/gdb/block.c b/gdb/block.c index ca4dc22cf30..5ba44d47ba7 100644 --- a/gdb/block.c +++ b/gdb/block.c @@ -86,7 +86,7 @@ contained_in (const struct block *a, const struct block *b, } while (a != NULL); - return true; + return false; } |