diff options
| author | Simon Marchi <simon.marchi@ericsson.com> | 2017-04-21 21:45:15 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2017-04-21 21:45:15 -0400 |
| commit | 9be21bb4d4f30975766dfaa7d40b53ba10dcc3a0 (patch) | |
| tree | 73ed837da7e6f10565e37cc8454ee2c4e0084c00 | |
| parent | b8ac4fa43d5d37e4028ba2a7cc2d9b100ee85418 (diff) | |
| download | binutils-gdb-9be21bb4d4f30975766dfaa7d40b53ba10dcc3a0.tar.gz | |
Remove dead code and "current" field from MI thread output doc
The MI documentation says that -thread-info output contains a "current"
field in the current thread tuple, with the value "*". Current GDB
master does not do this, and I couldn't find any GDB version that did.
I suspect that it was never the case.
The code that would correspond to this in print_thread_info_1 is
essentially dead code. The calls to uiout->text end up in
mi_out::do_text, which is empty.
This patch removes the documentation bit and the dead code. This
"current" field is not necessary, since -thread-info outputs a
"current-thread-id" field.
gdb/ChangeLog:
* thread.c (print_thread_info_1): Remove dead code.
gdb/doc/ChangeLog:
* gdb.texinfo (GDB/MI Thread Commands): Remove "current" field
from -thread-info output.
| -rw-r--r-- | gdb/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/doc/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/doc/gdb.texinfo | 3 | ||||
| -rw-r--r-- | gdb/thread.c | 10 |
4 files changed, 10 insertions, 12 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b6576853df2..2aa0b5945ff 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-04-21 Simon Marchi <simon.marchi@ericsson.com> + + * thread.c (print_thread_info_1): Remove dead code. + 2017-04-21 Jan Kratochvil <jan.kratochvil@redhat.com> * aarch64-tdep.c (selftests::aarch64_process_record_test): Make it #if diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index c542c0b46ff..efce1c0a11e 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,8 @@ +2017-04-21 Simon Marchi <simon.marchi@ericsson.com> + + * gdb.texinfo (GDB/MI Thread Commands): Remove "current" field + from -thread-info output. + 2017-03-28 Anton Kolesov <anton.kolesov@synopsys.com> * gdb.texinfo (Synopsys ARC): Document "set debug arc 2". diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 300d78eefb8..9e872763b27 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -28088,9 +28088,6 @@ The result is a list of threads. The following attributes are defined for a given thread: @table @samp -@item current -This field exists only for the current thread. It has the value @samp{*}. - @item id The global identifier that @value{GDBN} uses to refer to the thread. diff --git a/gdb/thread.c b/gdb/thread.c index e4113c29d2f..7ce65ff4453 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -1308,15 +1308,7 @@ print_thread_info_1 (struct ui_out *uiout, char *requested_threads, chain2 = make_cleanup_ui_out_tuple_begin_end (uiout, NULL); - if (uiout->is_mi_like_p ()) - { - /* Compatibility. */ - if (tp->ptid == current_ptid) - uiout->text ("* "); - else - uiout->text (" "); - } - else + if (!uiout->is_mi_like_p ()) { if (tp->ptid == current_ptid) uiout->field_string ("current", "*"); |