summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Baldwin <jhb@FreeBSD.org>2017-08-21 09:35:25 -0700
committerJohn Baldwin <jhb@FreeBSD.org>2017-08-21 09:35:25 -0700
commit329d5e7e56f852dcf9956683be4345c165d277db (patch)
tree7df45a6a59af9e7fd65a02e2716e45efaa1af802
parentaf3881e612908b6c0b1283c67d18312cd219ca13 (diff)
downloadbinutils-gdb-329d5e7e56f852dcf9956683be4345c165d277db.tar.gz
Use an array type (lwpid_t[]) for the array of lwp IDs.
gdb/ChangeLog: * fbsd-nat.c (fbsd_add_threads): Use array type for `lwps'.
-rw-r--r--gdb/ChangeLog4
-rw-r--r--gdb/fbsd-nat.c9
2 files changed, 8 insertions, 5 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ddf52a3c717..74506f80a41 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-08-21 John Baldwin <jhb@FreeBSD.org>
+
+ * fbsd-nat.c (fbsd_add_threads): Use array type for `lwps'.
+
2017-08-21 Pedro Alves <palves@redhat.com>
PR gdb/19487
diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index 6ba6a01a701..80e0eca111e 100644
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -632,7 +632,7 @@ fbsd_add_threads (pid_t pid)
if (nlwps == -1)
perror_with_name (("ptrace"));
- gdb::unique_xmalloc_ptr<lwpid_t> lwps (XCNEWVEC (lwpid_t, nlwps));
+ gdb::unique_xmalloc_ptr<lwpid_t[]> lwps (XCNEWVEC (lwpid_t, nlwps));
nlwps = ptrace (PT_GETLWPLIST, pid, (caddr_t) lwps.get (), nlwps);
if (nlwps == -1)
@@ -640,8 +640,7 @@ fbsd_add_threads (pid_t pid)
for (i = 0; i < nlwps; i++)
{
- lwpid_t lwp = lwps.get ()[i];
- ptid_t ptid = ptid_build (pid, lwp, 0);
+ ptid_t ptid = ptid_build (pid, lwps[i], 0);
if (!in_thread_list (ptid))
{
@@ -650,7 +649,7 @@ fbsd_add_threads (pid_t pid)
/* Don't add exited threads. Note that this is only called
when attaching to a multi-threaded process. */
- if (ptrace (PT_LWPINFO, lwp, (caddr_t) &pl, sizeof pl) == -1)
+ if (ptrace (PT_LWPINFO, lwps[i], (caddr_t) &pl, sizeof pl) == -1)
perror_with_name (("ptrace"));
if (pl.pl_flags & PL_FLAG_EXITED)
continue;
@@ -658,7 +657,7 @@ fbsd_add_threads (pid_t pid)
if (debug_fbsd_lwp)
fprintf_unfiltered (gdb_stdlog,
"FLWP: adding thread for LWP %u\n",
- lwp);
+ lwps[i]);
add_thread (ptid);
}
}