summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tromey@adacore.com>2020-08-17 10:45:49 -0600
committerTom Tromey <tromey@adacore.com>2020-08-17 10:47:48 -0600
commit326afb722951cacc6131e2d6d1511986748ca017 (patch)
tree366ac0e48bc8dedb96350aacc462880ea93cbd1c
parent3ae7ab999277b5d668d89fed5a7707f7778f5e6b (diff)
downloadbinutils-gdb-326afb722951cacc6131e2d6d1511986748ca017.tar.gz
Update xfail pattern in gdb.rust/simple.exp
In PR rust/26197, Tom de Vries notes that the variant part rewrite caused some regressions for the Rust compiler he has. This compiler is unusual in that it combines a relatively recent rustc with a relatively old LLVM -- so variant parts are not emitted using DWARF. Most of the bugs in that PR were already fixed by earlier patches, but some lingered. After some research we found that some of these never did work -- which is consistent with the investigations we did into the debug info -- but instead were xfail'd. This patch updates the xfails to cope with the new output. (After this, just one failure remains.) Tom de Vries tested this using his rustc and suggested a fix that appears in this version. gdb/testsuite/ChangeLog 2020-08-17 Tom de Vries <tdevries@suse.de> Tom Tromey <tromey@adacore.com> PR rust/26197: * gdb.rust/simple.exp (xfail_pattern): Update for new failure.
-rw-r--r--gdb/testsuite/ChangeLog6
-rw-r--r--gdb/testsuite/gdb.rust/simple.exp3
2 files changed, 8 insertions, 1 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 9fdbcb8703c..7c624589de2 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2020-08-17 Tom de Vries <tdevries@suse.de>
+ Tom Tromey <tromey@adacore.com>
+
+ PR rust/26197:
+ * gdb.rust/simple.exp (xfail_pattern): Update for new failure.
+
2020-08-17 Tom Tromey <tromey@adacore.com>
* gdb.ada/mi_var_access.exp: New file.
diff --git a/gdb/testsuite/gdb.rust/simple.exp b/gdb/testsuite/gdb.rust/simple.exp
index f0cad4e7634..b32eaf1e4dc 100644
--- a/gdb/testsuite/gdb.rust/simple.exp
+++ b/gdb/testsuite/gdb.rust/simple.exp
@@ -239,7 +239,8 @@ gdb_test "print .." " = .*::ops::RangeFull"
set pass_pattern \
" = core::option::Option<\[a-z\]+::string::String>::Some\\(\[a-z\]+::string::String .*"
-set xfail_pattern " = <error reading variable>"
+set xfail_pattern \
+ "( = <error reading variable>|That operation is not available on .*)"
gdb_test_multiple "print str_some" "" {
-re "\[\r\n\]*(?:$pass_pattern)\[\r\n\]+$gdb_prompt $" {
pass $gdb_test_name