summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2017-11-01 18:52:30 -0600
committerTom Tromey <tom@tromey.com>2017-11-04 10:27:18 -0600
commit779bc38eca950c7f3b64173e99e25f0c0edfbe3b (patch)
treee5f1387588eb7eb94fc2d2d3f2ff8cf0ff0e3ed0
parented2b3126d1828d55d57880c6b6045a4e58c05cde (diff)
downloadbinutils-gdb-779bc38eca950c7f3b64173e99e25f0c0edfbe3b.tar.gz
Use gdb::byte_vector in ppc-linux-tdep.c
This removes a cleanup from ppc-linux-tdep.c, replacing it with gdb::byte_vector. gdb/ChangeLog 2017-11-04 Tom Tromey <tom@tromey.com> * ppc-linux-tdep.c (ppc_linux_get_syscall_number): Use gdb::byte_vector.
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/ppc-linux-tdep.c17
2 files changed, 9 insertions, 13 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6db35dd1e19..d6c4b6f8054 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2017-11-04 Tom Tromey <tom@tromey.com>
+ * ppc-linux-tdep.c (ppc_linux_get_syscall_number): Use
+ gdb::byte_vector.
+
+2017-11-04 Tom Tromey <tom@tromey.com>
+
* objfiles.c (do_free_objfile_cleanup): Remove.
* compile/compile-object-load.c (compile_object_load): Update.
* objfiles.h (make_cleanup_free_objfile): Remove.
diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c
index 847908a6da7..ee80a71c6b9 100644
--- a/gdb/ppc-linux-tdep.c
+++ b/gdb/ppc-linux-tdep.c
@@ -725,28 +725,19 @@ ppc_linux_get_syscall_number (struct gdbarch *gdbarch,
struct regcache *regcache = get_thread_regcache (ptid);
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
- struct cleanup *cleanbuf;
- /* The content of a register */
- gdb_byte *buf;
- /* The result */
- LONGEST ret;
/* Make sure we're in a 32- or 64-bit machine */
gdb_assert (tdep->wordsize == 4 || tdep->wordsize == 8);
- buf = (gdb_byte *) xmalloc (tdep->wordsize * sizeof (gdb_byte));
-
- cleanbuf = make_cleanup (xfree, buf);
+ /* The content of a register */
+ gdb::byte_vector buf (tdep->wordsize);
/* Getting the system call number from the register.
When dealing with PowerPC architecture, this information
is stored at 0th register. */
- regcache_cooked_read (regcache, tdep->ppc_gp0_regnum, buf);
-
- ret = extract_signed_integer (buf, tdep->wordsize, byte_order);
- do_cleanups (cleanbuf);
+ regcache_cooked_read (regcache, tdep->ppc_gp0_regnum, buf.data ());
- return ret;
+ return extract_signed_integer (buf.data (), tdep->wordsize, byte_order);
}
/* PPC process record-replay */