diff options
| author | Alan Modra <amodra@gmail.com> | 2021-06-18 22:27:01 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2021-06-19 11:08:55 +0930 |
| commit | 03e689aaac95da0b22f7689a2c307e8ddd99ae2c (patch) | |
| tree | 3d400c00985b288b6cde2b2a356112d20bc107b8 /gas | |
| parent | 43f71bc5df211f424e7dfafbdfb644cd03bfcd34 (diff) | |
| download | binutils-gdb-03e689aaac95da0b22f7689a2c307e8ddd99ae2c.tar.gz | |
ubsan errors when 32-bit bfd
A shift count exceeding the size of the value is undefined behaviour,
and so is negating a signed LONG_MIN.
* config/tc-z80.c (signed_overflow, unsigned_overflow): Avoid UB.
Diffstat (limited to 'gas')
| -rw-r--r-- | gas/ChangeLog | 4 | ||||
| -rw-r--r-- | gas/config/tc-z80.c | 6 |
2 files changed, 7 insertions, 3 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index ff0f65cf00d..e217c8243a4 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,5 +1,9 @@ 2021-06-19 Alan Modra <amodra@gmail.com> + * config/tc-z80.c (signed_overflow, unsigned_overflow): Avoid UB. + +2021-06-19 Alan Modra <amodra@gmail.com> + * testsuite/gas/ppc/raw.s: Use 0 as pli constant. * testsuite/gas/ppc/raw.d: Update to suit. diff --git a/gas/config/tc-z80.c b/gas/config/tc-z80.c index 47d1405c2b6..303296b7dab 100644 --- a/gas/config/tc-z80.c +++ b/gas/config/tc-z80.c @@ -3703,14 +3703,14 @@ md_assemble (char *str) static int signed_overflow (signed long value, unsigned bitsize) { - signed long max = (signed long)(1UL << (bitsize-1)); - return value < -max || value >= max; + signed long max = (signed long) ((1UL << (bitsize - 1)) - 1); + return value < -max - 1 || value > max; } static int unsigned_overflow (unsigned long value, unsigned bitsize) { - return (value >> bitsize) != 0; + return value >> (bitsize - 1) >> 1 != 0; } static int |