diff options
| author | Pedro Alves <palves@redhat.com> | 2018-11-21 11:55:12 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2018-11-21 12:06:20 +0000 |
| commit | 6b1747cd135ff9859fceb6043179b1ef94363996 (patch) | |
| tree | 9dd00eb42169b61747d43efeec410c66ba7070e3 /gdb/value.h | |
| parent | e71585ffe2e1394858f0fcf809e86f1b324fe4e6 (diff) | |
| download | binutils-gdb-6b1747cd135ff9859fceb6043179b1ef94363996.tar.gz | |
invoke_xmethod & array_view
This replaces more pointer+length with gdb::array_view. This time,
around invoke_xmethod, and then propagating the fallout around, which
inevitably leaks to the overload resolution code.
There are several places in the code that want to grab a slice of an
array, by advancing the array pointer, and decreasing the length
pointer. This patch introduces a pair of new
gdb::array_view::slice(...) methods to make that convenient and clear.
Unit test included.
gdb/ChangeLog:
2018-11-21 Pedro Alves <palves@redhat.com>
* common/array-view.h (array_view::splice(size_type, size_t)): New.
(array_view::splice(size_type)): New.
* eval.c (eval_call, evaluate_funcall): Adjust to use array_view.
* extension.c (xmethod_worker::get_arg_types): Adjust to return an
std::vector.
(xmethod_worker::get_result_type): Adjust to use gdb::array_view.
* extension.h: Include "common/array-view.h".
(xmethod_worker::invoke): Adjust to use gdb::array_view.
(xmethod_worker::get_arg_types): Adjust to return an std::vector.
(xmethod_worker::get_result_type): Adjust to use gdb::array_view.
(xmethod_worker::do_get_arg_types): Adjust to use std::vector.
(xmethod_worker::do_get_result_type): Adjust to use
gdb::array_view.
* gdbtypes.c (rank_function): Adjust to use gdb::array_view.
* gdbtypes.h: Include "common/array-view.h".
(rank_function): Adjust to use gdb::array_view.
* python/py-xmethods.c (python_xmethod_worker::invoke)
(python_xmethod_worker::do_get_arg_types)
(python_xmethod_worker::do_get_result_type)
(python_xmethod_worker::invoke): Adjust to new interfaces.
* valarith.c (value_user_defined_cpp_op, value_user_defined_op)
(value_x_binop, value_x_unop): Adjust to use gdb::array_view.
* valops.c (find_overload_match, find_oload_champ_namespace)
(find_oload_champ_namespace_loop, find_oload_champ): Adjust to use
gdb:array_view and the new xmethod_worker interfaces.
* value.c (result_type_of_xmethod, call_xmethod): Adjust to use
gdb::array_view.
* value.h (find_overload_match, result_type_of_xmethod)
(call_xmethod): Adjust to use gdb::array_view.
* unittests/array-view-selftests.c: Add slicing tests.
Diffstat (limited to 'gdb/value.h')
| -rw-r--r-- | gdb/value.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gdb/value.h b/gdb/value.h index 4d75c966edd..54caa58e7ff 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -835,7 +835,7 @@ extern struct value *value_static_field (struct type *type, int fieldno); enum oload_search_type { NON_METHOD, METHOD, BOTH }; -extern int find_overload_match (struct value **args, int nargs, +extern int find_overload_match (gdb::array_view<value *> args, const char *name, enum oload_search_type method, struct value **objp, struct symbol *fsym, @@ -1175,10 +1175,10 @@ char *value_internal_function_name (struct value *); extern struct value *value_from_xmethod (xmethod_worker_up &&worker); extern struct type *result_type_of_xmethod (struct value *method, - int argc, struct value **argv); + gdb::array_view<value *> argv); extern struct value *call_xmethod (struct value *method, - int argc, struct value **argv); + gdb::array_view<value *> argv); /* Given a discriminated union type and some corresponding value contents, this will return the field index of the currently active |