summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Brook <paul@codesourcery.com>2006-09-05 16:25:48 +0000
committerPaul Brook <paul@codesourcery.com>2006-09-05 16:25:48 +0000
commite2f3afa55addb2a910070458fe327cf962068ce2 (patch)
treee21a411378d6e5acd5d8bfc810194e6d9e042462
parent34ff8c34afe285692b860f2b2c762fdc8e1c1d45 (diff)
downloadbinutils-redhat-e2f3afa55addb2a910070458fe327cf962068ce2.tar.gz
2006-09-05 Vladimir Prus <vladimir@codesourcery.com>
bfd/ * elf32-arm.c (elf32_arm_swap_symbol_out): Remove unconditionall setting of low bit for Thumb symbol mistakenly left behind after check for external symbols was added. ld/testsuite/ * ld-arm/use-thumb-lib.sym: Use regexps instead of absolute addresses, for robustness.
-rw-r--r--ChangeLog.csl12
-rw-r--r--bfd/elf32-arm.c2
-rw-r--r--ld/testsuite/ld-arm/use-thumb-lib.sym23
3 files changed, 24 insertions, 13 deletions
diff --git a/ChangeLog.csl b/ChangeLog.csl
index 7d820e1dbc..3ad0a094f4 100644
--- a/ChangeLog.csl
+++ b/ChangeLog.csl
@@ -1,3 +1,15 @@
+2006-09-05 Vladimir Prus <vladimir@codesourcery.com>
+
+ bfd/
+ * elf32-arm.c (elf32_arm_swap_symbol_out): Remove
+ unconditionall setting of low bit for Thumb symbol
+ mistakenly left behind after check for external
+ symbols was added.
+
+ ld/testsuite/
+ * ld-arm/use-thumb-lib.sym: Use regexps instead of
+ absolute addresses, for robustness.
+
2006-09-05 Julian Brown <julian@codesourcery.com>
gas/
diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index 5de108aa26..d1fa73108d 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -9452,8 +9452,6 @@ elf32_arm_swap_symbol_out (bfd *abfd,
*/
newsym.st_value |= 1;
}
-
- newsym.st_value |= 1;
src = &newsym;
}
diff --git a/ld/testsuite/ld-arm/use-thumb-lib.sym b/ld/testsuite/ld-arm/use-thumb-lib.sym
index b4cb1805df..06cde2a2a5 100644
--- a/ld/testsuite/ld-arm/use-thumb-lib.sym
+++ b/ld/testsuite/ld-arm/use-thumb-lib.sym
@@ -1,15 +1,16 @@
Symbol table for image:
Num Buc: Value Size Type Bind Vis Ndx Name
- 11 0: 0000830c 0 NOTYPE GLOBAL DEFAULT ABS _edata
- 10 0: 00000268 20 FUNC GLOBAL DEFAULT 6 foo
- 4 0: 0000830c 0 NOTYPE GLOBAL DEFAULT ABS __bss_start__
- 12 1: 0000830c 0 NOTYPE GLOBAL DEFAULT ABS _end
- 7 1: 0000830c 0 NOTYPE GLOBAL DEFAULT ABS __bss_end__
- 5 1: 0000027c 0 NOTYPE GLOBAL DEFAULT ABS __exidx_start
- 13 2: 0000830c 0 NOTYPE GLOBAL DEFAULT ABS __data_start
- 9 2: 0000830c 0 NOTYPE GLOBAL DEFAULT ABS __end__
- 8 2: 0000830c 0 NOTYPE GLOBAL DEFAULT ABS __bss_start
+ 11 0: [0-9a-f]* 0 NOTYPE GLOBAL DEFAULT ABS _edata
+ 10 0: [0-9a-f]* 20 FUNC GLOBAL DEFAULT 6 foo
+ 4 0: [0-9a-f]* 0 NOTYPE GLOBAL DEFAULT ABS __bss_start__
+ 12 1: [0-9a-f]* 0 NOTYPE GLOBAL DEFAULT ABS _end
+ 7 1: [0-9a-f]* 0 NOTYPE GLOBAL DEFAULT ABS __bss_end__
+ 5 1: [0-9a-f]* 0 NOTYPE GLOBAL DEFAULT ABS __exidx_start
+ 14 2: [0-9a-f]* 0 NOTYPE GLOBAL DEFAULT ABS __data_start
+ 13 2: [0-9a-f]* 0 NOTYPE GLOBAL DEFAULT ABS _stack
+ 9 2: [0-9a-f]* 0 NOTYPE GLOBAL DEFAULT ABS __end__
+ 8 2: [0-9a-f]* 0 NOTYPE GLOBAL DEFAULT ABS __bss_start
6 2: 00000000 2 FUNC GLOBAL DEFAULT UND lib_func2
- 3 2: 0000830c 0 NOTYPE GLOBAL DEFAULT ABS _bss_end__
- 2 2: 0000027c 0 NOTYPE GLOBAL DEFAULT ABS __exidx_end
+ 3 2: [0-9a-f]* 0 NOTYPE GLOBAL DEFAULT ABS _bss_end__
+ 2 2: [0-9a-f]* 0 NOTYPE GLOBAL DEFAULT ABS __exidx_end