diff options
| author | Thiemo Seufer <ths@networkno.de> | 2003-09-18 05:20:04 +0000 |
|---|---|---|
| committer | Thiemo Seufer <ths@networkno.de> | 2003-09-18 05:20:04 +0000 |
| commit | b03979e3bcdf59668b47f3d16a9ac97c385fe651 (patch) | |
| tree | f9e6ad4662430ea958bb92098f3fece8c5edcd7a | |
| parent | 6f40abde25a1d0706b62e4213756a3e0a424db9a (diff) | |
| download | binutils-redhat-b03979e3bcdf59668b47f3d16a9ac97c385fe651.tar.gz | |
* config/tc-mips.c (macro_build_ldst_constoffset): Don't silently
truncate values which won't fit im 32 bits.
(load_register): Likewise.
(macro): Likewise.
| -rw-r--r-- | gas/ChangeLog | 7 | ||||
| -rw-r--r-- | gas/config/tc-mips.c | 18 |
2 files changed, 25 insertions, 0 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index bbd7ecd197..53942b7c3f 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,10 @@ +2003-09-18 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de> + + * config/tc-mips.c (macro_build_ldst_constoffset): Don't silently + truncate values which won't fit im 32 bits. + (load_register): Likewise. + (macro): Likewise. + 2003-09-17 Dmitry Diky <diwil@mail.ru> * config/tc-msp430.c (MAX_OP_LEN): Set to 256. diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c index 8c7c69e7c3..e63888354c 100644 --- a/gas/config/tc-mips.c +++ b/gas/config/tc-mips.c @@ -3229,8 +3229,14 @@ macro_build_ldst_constoffset (char *place, int *counter, expressionS *ep, /* Sign-extending 32-bit constants makes their handling easier. */ if (! dbl) + { + if (ep->X_add_number & ~((bfd_vma) 0xffffffff) + && ~(ep->X_add_number | 0xffffffff)) + as_bad (_("too large constant specified")); + ep->X_add_number = (((ep->X_add_number & 0xffffffff) ^ 0x80000000) - 0x80000000); + } /* Right now, this routine can only handle signed 32-bit contants. */ if (! IS_SEXT_32BIT_NUM(ep->X_add_number)) @@ -3387,8 +3393,14 @@ load_register (int *counter, int reg, expressionS *ep, int dbl) /* Sign-extending 32-bit constants makes their handling easier. */ if (! dbl) + { + if (ep->X_add_number & ~((bfd_vma) 0xffffffff) + && ~(ep->X_add_number | 0xffffffff)) + as_bad (_("too large constant specified")); + ep->X_add_number = (((ep->X_add_number & 0xffffffff) ^ 0x80000000) - 0x80000000); + } if (IS_SEXT_16BIT_NUM (ep->X_add_number)) { @@ -5793,8 +5805,14 @@ macro (struct mips_cl_insn *ip) if ((! HAVE_64BIT_ADDRESSES && (! HAVE_64BIT_GPRS && offset_expr.X_op == O_constant)) && (offset_expr.X_op == O_constant)) + { + if (offset_expr.X_add_number & ~((bfd_vma) 0xffffffff) + && ~(offset_expr.X_add_number | 0xffffffff)) + as_bad (_("too large constant specified")); + offset_expr.X_add_number = (((offset_expr.X_add_number & 0xffffffff) ^ 0x80000000) - 0x80000000); + } /* For embedded PIC, we allow loads where the offset is calculated by subtracting a symbol in the current segment from an unknown |