summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel E. Denny <jdenny@ces.clemson.edu>2008-11-07 16:48:57 -0500
committerJoel E. Denny <jdenny@ces.clemson.edu>2008-11-07 16:48:57 -0500
commit7ed73f82ad0d54be945b9d5146e343c8e89bf81f (patch)
tree65b20ae46aa0d6685bf3354b831de5c9df9d3019
parent4b1ebc495bd39572b60640bc469b0852e9f71447 (diff)
downloadbison-7ed73f82ad0d54be945b9d5146e343c8e89bf81f.tar.gz
Don't add a semicolon to actions for %skeleton or %language.
It breaks Java test cases as reported by Akim Demaille. * src/scan-code.l: Implement.
-rw-r--r--ChangeLog6
-rw-r--r--src/scan-code.l7
2 files changed, 11 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 4d3011f1..86aa3e5d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
2008-11-07 Joel E. Denny <jdenny@ces.clemson.edu>
+ Don't add a semicolon to actions for %skeleton or %language.
+ It breaks Java test cases as reported by Akim Demaille.
+ * src/scan-code.l: Implement.
+
+2008-11-07 Joel E. Denny <jdenny@ces.clemson.edu>
+
Clean up %skeleton and %language priority implementation.
* src/getargs.c (skeleton_prio): Use default_prio rather than 2, and
remove static qualifier because others will soon need to see it.
diff --git a/src/scan-code.l b/src/scan-code.l
index 71c90768..13a78c27 100644
--- a/src/scan-code.l
+++ b/src/scan-code.l
@@ -175,7 +175,9 @@ splice (\\[ \f\t\v]*\n)*
/* As an undocumented Bison extension, append `;' before the last
brace in braced code, so that the user code can omit trailing
`;'. But do not append `;' if emulating Yacc, since Yacc does
- not append one.
+ not append one. Also, some output languages (like Java) do not
+ accept an extra semicolon, so don't append if the user specified
+ a skeleton or language.
FIXME: Bison should warn if a semicolon seems to be necessary
here, and should omit the semicolon if it seems unnecessary
@@ -186,7 +188,8 @@ splice (\\[ \f\t\v]*\n)*
should also diagnose other Bison extensions like %yacc.
Perhaps there should also be a GCC-style --pedantic-errors
option, so that such warnings are diagnosed as errors. */
- if (outer_brace && ! yacc_flag)
+ if (outer_brace && !yacc_flag && language_prio == default_prio
+ && skeleton_prio == default_prio)
obstack_1grow (&obstack_for_string, ';');
STRING_GROW;