<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/bluez.git, branch 4.58</title>
<subtitle>git.kernel.org: pub/scm/bluetooth/bluez.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bluez.git/'/>
<entry>
<title>Release 4.58</title>
<updated>2009-11-15T11:59:42+00:00</updated>
<author>
<name>Marcel Holtmann</name>
<email>marcel@holtmann.org</email>
</author>
<published>2009-11-15T11:59:42+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bluez.git/commit/?id=09b75f4b8dff119c6da550cf122d6a0f1e0a1a7a'/>
<id>09b75f4b8dff119c6da550cf122d6a0f1e0a1a7a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix wrong order of error handling in netlink setup</title>
<updated>2009-11-14T23:11:45+00:00</updated>
<author>
<name>Marcel Holtmann</name>
<email>marcel@holtmann.org</email>
</author>
<published>2009-11-14T23:11:45+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bluez.git/commit/?id=fdf703f79f802af999f74446265396a7eb20bb62'/>
<id>fdf703f79f802af999f74446265396a7eb20bb62</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix regression introduced by 37b02c1ef9be4f989c9ad5e511f519d35f2bc088</title>
<updated>2009-11-12T22:36:53+00:00</updated>
<author>
<name>Luiz Augusto von Dentz</name>
<email>luiz.dentz@openbossa.org</email>
</author>
<published>2009-11-12T21:12:26+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bluez.git/commit/?id=a9c4e4a0aec81cecbc2bded149b924028953a952'/>
<id>a9c4e4a0aec81cecbc2bded149b924028953a952</id>
<content type='text'>
device-&gt;authr cannot be reset to NULL in initiator case as it is needed
by device_is_authenticating.

So instead of reseting device-&gt;authr just reset both device-&gt;authr-&gt;cb
and device-&gt;authr-&gt;agent to NULL, this fix the regression since the original
problem was device-&gt;authr-&gt;agent pointing to freed memory.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
device-&gt;authr cannot be reset to NULL in initiator case as it is needed
by device_is_authenticating.

So instead of reseting device-&gt;authr just reset both device-&gt;authr-&gt;cb
and device-&gt;authr-&gt;agent to NULL, this fix the regression since the original
problem was device-&gt;authr-&gt;agent pointing to freed memory.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix bluetoothd crash when adapter agent exists during authentication</title>
<updated>2009-11-11T14:53:24+00:00</updated>
<author>
<name>Johan Hedberg</name>
<email>johan.hedberg@nokia.com</email>
</author>
<published>2009-11-11T14:43:39+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bluez.git/commit/?id=37b02c1ef9be4f989c9ad5e511f519d35f2bc088'/>
<id>37b02c1ef9be4f989c9ad5e511f519d35f2bc088</id>
<content type='text'>
During general bonding or dedicated bonding acceptor
device-&gt;authr-&gt;agent will point to the adapter agent. However, there's
no direct way to access device-&gt;authr if the agent exists while
authentication is ongoing. With the current code this would lead into
accessing free'd memory since device-&gt;authr-&gt;agent becomes an invalid
pointer.

One way to fix this would be to add reference counting to the agent
objects, but that would be quite intrusive on the way that the code
expects agent_free to behave at the moment and handles agent
re-registration checks. Another option would be to iterate through all
device objects to find if any of them have a reference to the adapter
agent, however this would be quite a waste of CPU cycles (and pretty
ugly imho).

This patch takes neither of these two possibilities but comes with the
realization that maintaining device-&gt;authr is completely unnecessary
after the authentication callbacks have been called (currently
device-&gt;authr gets reset only when the full pairing process completes).
Since agent_free takes care of the bluetoothd internal callbacks in the
case that the agent exited unexpectedly we simply need to clean up
device-&gt;authr in these callbacks, which is what this patch does.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
During general bonding or dedicated bonding acceptor
device-&gt;authr-&gt;agent will point to the adapter agent. However, there's
no direct way to access device-&gt;authr if the agent exists while
authentication is ongoing. With the current code this would lead into
accessing free'd memory since device-&gt;authr-&gt;agent becomes an invalid
pointer.

One way to fix this would be to add reference counting to the agent
objects, but that would be quite intrusive on the way that the code
expects agent_free to behave at the moment and handles agent
re-registration checks. Another option would be to iterate through all
device objects to find if any of them have a reference to the adapter
agent, however this would be quite a waste of CPU cycles (and pretty
ugly imho).

This patch takes neither of these two possibilities but comes with the
realization that maintaining device-&gt;authr is completely unnecessary
after the authentication callbacks have been called (currently
device-&gt;authr gets reset only when the full pairing process completes).
Since agent_free takes care of the bluetoothd internal callbacks in the
case that the agent exited unexpectedly we simply need to clean up
device-&gt;authr in these callbacks, which is what this patch does.
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove the unnecessary agent_destroy function</title>
<updated>2009-11-11T12:17:20+00:00</updated>
<author>
<name>Johan Hedberg</name>
<email>johan.hedberg@nokia.com</email>
</author>
<published>2009-11-11T12:17:20+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bluez.git/commit/?id=cc35f24a2a728c4e8c31ea0c6c11c6b701901861'/>
<id>cc35f24a2a728c4e8c31ea0c6c11c6b701901861</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Include info(), error() and debug() as exported symbols</title>
<updated>2009-11-09T11:28:29+00:00</updated>
<author>
<name>Marcel Holtmann</name>
<email>marcel@holtmann.org</email>
</author>
<published>2009-11-09T11:28:29+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bluez.git/commit/?id=a0a8c6f1969d91714a0799e88c2cfb54fd29aee7'/>
<id>a0a8c6f1969d91714a0799e88c2cfb54fd29aee7</id>
<content type='text'>
This is needed until everything has a proper btd_ symbol prefix.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is needed until everything has a proper btd_ symbol prefix.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix CK-20W quirks for play and pause events</title>
<updated>2009-11-03T11:45:27+00:00</updated>
<author>
<name>Daniel Orstadius</name>
<email>daniel.orstadius@gmail.com</email>
</author>
<published>2009-11-03T08:22:17+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bluez.git/commit/?id=515274df91e470472a8f56c2c0faca35cf2c3040'/>
<id>515274df91e470472a8f56c2c0faca35cf2c3040</id>
<content type='text'>
It seems the play and pause key presses also lack the release event
sometimes so also add the necessary quirk to them.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It seems the play and pause key presses also lack the release event
sometimes so also add the necessary quirk to them.
</pre>
</div>
</content>
</entry>
<entry>
<title>Release 4.57</title>
<updated>2009-10-31T16:10:48+00:00</updated>
<author>
<name>Marcel Holtmann</name>
<email>marcel@holtmann.org</email>
</author>
<published>2009-10-31T16:10:48+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bluez.git/commit/?id=d82505e7c1a3c014c3975a6400b0b22ea4b32de1'/>
<id>d82505e7c1a3c014c3975a6400b0b22ea4b32de1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Mention Jaikumar's contributions</title>
<updated>2009-10-31T16:03:08+00:00</updated>
<author>
<name>Marcel Holtmann</name>
<email>marcel@holtmann.org</email>
</author>
<published>2009-10-31T16:03:08+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bluez.git/commit/?id=b072d3aef6151eaaac27381ea0c2d884c8e6118c'/>
<id>b072d3aef6151eaaac27381ea0c2d884c8e6118c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix const declarations for some storage function parameters</title>
<updated>2009-10-29T21:15:24+00:00</updated>
<author>
<name>Johan Hedberg</name>
<email>johan.hedberg@nokia.com</email>
</author>
<published>2009-10-29T21:15:24+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/bluez.git/commit/?id=adad645d0ad11c5b332058ce8e5d1797cf1c0727'/>
<id>adad645d0ad11c5b332058ce8e5d1797cf1c0727</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
