diff options
| author | Luiz Augusto von Dentz <luiz.von.dentz@intel.com> | 2014-03-13 15:26:24 +0200 |
|---|---|---|
| committer | Luiz Augusto von Dentz <luiz.von.dentz@intel.com> | 2014-03-13 18:04:56 +0200 |
| commit | 438998c440522b422ab7240b295dddfafa5c7df7 (patch) | |
| tree | ec8d4925b0a85b587a9d19d14a0070df20da1876 /profiles/audio/player.c | |
| parent | 7036010169e7278e1651608c92ce6cf5ca4c10e3 (diff) | |
| download | bluez-438998c440522b422ab7240b295dddfafa5c7df7.tar.gz | |
audio/player: Use proper errors instead of using .Failed
Diffstat (limited to 'profiles/audio/player.c')
| -rw-r--r-- | profiles/audio/player.c | 29 |
1 files changed, 10 insertions, 19 deletions
diff --git a/profiles/audio/player.c b/profiles/audio/player.c index 2bd2d6e49..c76352e64 100644 --- a/profiles/audio/player.c +++ b/profiles/audio/player.c @@ -778,19 +778,16 @@ static DBusMessage *media_folder_search(DBusConnection *conn, DBusMessage *msg, dbus_message_iter_init(msg, &iter); if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_STRING) - return btd_error_failed(msg, strerror(EINVAL)); + return btd_error_invalid_args(msg); dbus_message_iter_get_basic(&iter, &string); - if (!mp->searchable || folder != mp->folder) - return btd_error_failed(msg, strerror(ENOTSUP)); + if (!mp->searchable || folder != mp->folder || !cb->cbs->search) + return btd_error_not_supported(msg); if (folder->msg != NULL) return btd_error_failed(msg, strerror(EINVAL)); - if (cb->cbs->search == NULL) - return btd_error_failed(msg, strerror(ENOTSUP)); - err = cb->cbs->search(mp, string, cb->user_data); if (err < 0) return btd_error_failed(msg, strerror(-err)); @@ -998,14 +995,14 @@ static DBusMessage *media_folder_change_folder(DBusConnection *conn, if (!dbus_message_get_args(msg, NULL, DBUS_TYPE_OBJECT_PATH, &path, DBUS_TYPE_INVALID)) - return btd_error_failed(msg, strerror(EINVAL)); + return btd_error_invalid_args(msg); if (folder->msg != NULL) return btd_error_failed(msg, strerror(EBUSY)); folder = media_player_find_folder(mp, path); if (folder == NULL) - return btd_error_failed(msg, strerror(EINVAL)); + return btd_error_invalid_args(msg); if (mp->scope == folder) return g_dbus_create_reply(msg, DBUS_TYPE_INVALID); @@ -1017,7 +1014,7 @@ static DBusMessage *media_folder_change_folder(DBusConnection *conn, } if (cb->cbs->change_folder == NULL) - return btd_error_failed(msg, strerror(ENOTSUP)); + return btd_error_not_supported(msg); err = cb->cbs->change_folder(mp, folder->item->name, folder->item->uid, cb->user_data); @@ -1473,11 +1470,8 @@ static DBusMessage *media_item_play(DBusConnection *conn, DBusMessage *msg, struct player_callback *cb = mp->cb; int err; - if (!item->playable) - return btd_error_failed(msg, strerror(ENOTSUP)); - - if (cb->cbs->play_item == NULL) - return btd_error_failed(msg, strerror(ENOTSUP)); + if (!item->playable || !cb->cbs->play_item) + return btd_error_not_supported(msg); err = cb->cbs->play_item(mp, item->path, item->uid, cb->user_data); if (err < 0) @@ -1494,11 +1488,8 @@ static DBusMessage *media_item_add_to_nowplaying(DBusConnection *conn, struct player_callback *cb = mp->cb; int err; - if (!item->playable) - return btd_error_failed(msg, strerror(ENOTSUP)); - - if (cb->cbs->play_item == NULL) - return btd_error_failed(msg, strerror(ENOTSUP)); + if (!item->playable || !cb->cbs->play_item) + return btd_error_not_supported(msg); err = cb->cbs->add_to_nowplaying(mp, item->path, item->uid, cb->user_data); |