From b48412960ae4489efab97479f580075e45563015 Mon Sep 17 00:00:00 2001 From: Luiz Augusto von Dentz Date: Mon, 11 Apr 2016 16:37:51 +0300 Subject: HACKING: Add necessary commands to configure git send-email This is convenient for people not involved with projects using email to as review process. --- HACKING | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) (limited to 'HACKING') diff --git a/HACKING b/HACKING index a8fb403e5..28f100957 100644 --- a/HACKING +++ b/HACKING @@ -108,6 +108,19 @@ If you fixed a bug or you want to add support for something, patches are welcome! In order to ease the inclusion of your patch, it's important to follow some rules, otherwise it will likely be rejected by maintainers. +Make sure the author name and email are set properly: + + # git config --global user.name + # git config --global user.email + +The preferred way to send patches is by email, using git send-email: + + # git config --global sendemail.smtpencryption + # git config --global sendemail.smtpserver + # git config --global sendemail.smtpuser + # git config --global sendemail.smtpserverport <587> + # git config sendemail.to linux-bluetooth@vger.kernel.org + BlueZ rules for submitting patches follow most of the rules used by Linux kernel (https://www.kernel.org/doc/Documentation/SubmittingPatches) with some remarks: @@ -128,3 +141,17 @@ break compilation. should be limited to 50 characters and the description should be wrapped at 72 characters except if it contains quoted information from debug tools like backtraces, compiler errors, etc. + +6) Prefix the email subject with [PATCH BlueZ]: + + # git config format.subjectprefix "PATCH BlueZ" + +6) Add a cover letter when introducing a new feature explaning what problem +you're trying to solve: + + # git format-patch --cover-letter -M origin/master -o outgoing/ + # edit outgoing/0000-* + +7) Submit: + + # git send-email outgoing/* -- cgit v1.2.1