From f29a5de80bd49e861992f97e4479440f01e4cc7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pali=20Roh=C3=A1r?= Date: Sun, 23 Dec 2018 11:40:17 +0100 Subject: a2dp-codecs: Define a2dp_vendor_codec_t struct in endian neutral way And define new macros A2DP_GET_VENDOR_ID(), A2DP_GET_CODEC_ID() and A2DP_SET_VENDOR_ID_CODEC_ID() for easily filling a2dp_vendor_codec_t struct. --- android/a2dp.c | 8 ++++---- android/avdtp.c | 6 ++++-- android/hal-audio-aptx.c | 18 ++++++------------ 3 files changed, 14 insertions(+), 18 deletions(-) (limited to 'android') diff --git a/android/a2dp.c b/android/a2dp.c index f21904208..8bcdfd20f 100644 --- a/android/a2dp.c +++ b/android/a2dp.c @@ -417,8 +417,8 @@ static int check_capabilities(struct a2dp_preset *preset, preset->len); case A2DP_CODEC_VENDOR: vndcodec = (void *) codec->data; - if (btohl(vndcodec->vendor_id) == APTX_VENDOR_ID && - btohs(vndcodec->codec_id) == APTX_CODEC_ID) + if (A2DP_GET_VENDOR_ID(*vndcodec) == APTX_VENDOR_ID && + A2DP_GET_CODEC_ID(*vndcodec) == APTX_CODEC_ID) return aptx_check_config(codec->data, codec_len, preset->data, preset->len); return -EINVAL; @@ -1344,8 +1344,8 @@ static uint8_t register_endpoint(const uint8_t *uuid, uint8_t codec, a2dp_vendor_codec_t *vndcodec = (void *) endpoint->caps->data; avdtp_sep_set_vendor_codec(endpoint->sep, - btohl(vndcodec->vendor_id), - btohs(vndcodec->codec_id)); + A2DP_GET_VENDOR_ID(*vndcodec), + A2DP_GET_CODEC_ID(*vndcodec)); } endpoints = g_slist_append(endpoints, endpoint); diff --git a/android/avdtp.c b/android/avdtp.c index 34caf3db5..7fb8cb731 100644 --- a/android/avdtp.c +++ b/android/avdtp.c @@ -1103,10 +1103,12 @@ struct avdtp_remote_sep *avdtp_find_remote_sep(struct avdtp *session, a2dp_vendor_codec_t *vndcodec = (void *) codec_data->data; - if (btohl(vndcodec->vendor_id) != lsep->vndcodec_vendor) + if (A2DP_GET_VENDOR_ID(*vndcodec) != + lsep->vndcodec_vendor) continue; - if (btohs(vndcodec->codec_id) != lsep->vndcodec_codec) + if (A2DP_GET_CODEC_ID(*vndcodec) != + lsep->vndcodec_codec) continue; } diff --git a/android/hal-audio-aptx.c b/android/hal-audio-aptx.c index bff2331a9..4e364fc65 100644 --- a/android/hal-audio-aptx.c +++ b/android/hal-audio-aptx.c @@ -37,27 +37,21 @@ struct aptx_data { static const a2dp_aptx_t aptx_presets[] = { { - .info = { - .vendor_id = APTX_VENDOR_ID, - .codec_id = APTX_CODEC_ID, - }, + .info = + A2DP_SET_VENDOR_ID_CODEC_ID(APTX_VENDOR_ID, APTX_CODEC_ID), .frequency = APTX_SAMPLING_FREQ_44100 | APTX_SAMPLING_FREQ_48000, .channel_mode = APTX_CHANNEL_MODE_STEREO, }, { - .info = { - .vendor_id = APTX_VENDOR_ID, - .codec_id = APTX_CODEC_ID, - }, + .info = + A2DP_SET_VENDOR_ID_CODEC_ID(APTX_VENDOR_ID, APTX_CODEC_ID), .frequency = APTX_SAMPLING_FREQ_48000, .channel_mode = APTX_CHANNEL_MODE_STEREO, }, { - .info = { - .vendor_id = APTX_VENDOR_ID, - .codec_id = APTX_CODEC_ID, - }, + .info = + A2DP_SET_VENDOR_ID_CODEC_ID(APTX_VENDOR_ID, APTX_CODEC_ID), .frequency = APTX_SAMPLING_FREQ_44100, .channel_mode = APTX_CHANNEL_MODE_STEREO, }, -- cgit v1.2.1